From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80BB82FF652 for ; Thu, 16 Oct 2025 08:03:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760601830; cv=none; b=gpWzjb17WA3wGBbK/eOLDBL612DuuAYj78KK6kyLhehjVWZvt9+vZnwDO6An0g5W0qfluHOYlD2K8qBT+hPGprF6IIwgmLJsVXitEbPvGX8mC1dkpSQ67n+r/0jhMz/4KX5kI3o6f+aSgukBT7gXvuitq8SUMEejde9D6TPs9TY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760601830; c=relaxed/simple; bh=Upf+vZPf5FtAc5nFbo/GsuIEVrSiRNpKkQuMnHoDkKY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=N/dEIAbM4ffkoi7UpCkbqZZDzJaHOAPWBzjV2OLaD3UZdHSG/syuERD/VncbSjdM2SDbgQIOGDEHTkn8yPdpr3jIjP3bFUEvuKC99ZMLwuCSrsrI0pM+sgZL1Gzz+PGcXhFjTib/xwvPetM7HMzQB239H5ZOnZzgtDyebX/OEoI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Zt1JOFcr; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Zt1JOFcr" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-57bd7f0e2daso73002e87.0 for ; Thu, 16 Oct 2025 01:03:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760601827; x=1761206627; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=SI3iJaG6AehsZaDVHen+J6EpKqRu7s9HPBybFYzEdgw=; b=Zt1JOFcrWuw11go7G7bhCGUHBNOiCR0wURQMzCTqvj5T+CQqJ7CNinXWuEoc6V7ucw u26CMntWifsh9HVbnzlDLuBPVL5ZI4H5rznBH6OtknAQ8FRMbyTRFOH7DNMyERlC+LaM d6AECpWJ9gux+y+5zNewlJmSYmiKaZCOVkg7rKyoAmWXgf+RR76PoSSjj8ajQDc+kgFn yFb4aMUi1DEvZMIvfCA58C8ZeHnMGcCSFOA7fBFSlyQ8hsIHP+9iPl8PrEa3+57mou+D lfgS00hp3s/n5rMti8OsF9t0Av5LUg9KeUaKdOaLhJ3A1d8P7W8GdKj1/ZRfjUtJrKN4 mpGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760601827; x=1761206627; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=SI3iJaG6AehsZaDVHen+J6EpKqRu7s9HPBybFYzEdgw=; b=fnNoQqBHWh5l2IOX/ajGXF7oOmQciHGWVNLAEv+C3R0xjwsZGgD7SrfWReczIxkn5s MHr78+p8e03/JRnhPwA6vKSgX7tyyA665zxYaaT11nHLJONVz4nTyp0kcmNxPDPPJlV2 bBWPxQLLKojvjIPpo+RNZ+bzMMZ6dt44BniNEujld2A3DkDZ0o9kMvlRWBlva2hhlDUC EEL/MBLKfLVs/1BX8gDVLaJBZoccZUD52E5qv7GmfZy+0RJquMgjYCEkKe+TecdLWNLr o7LcOJu6G/7rMaC+GTUKxUZ+9mSZoCF31kvWcfuhtL8AwK1nDC5ZDijmtlyBnjG1+09I PHCw== X-Forwarded-Encrypted: i=1; AJvYcCVOXBlxbcanGB/x0nDIi8/jBFVupg1DLwHvSjKblMUfaYZJrpVbsCE+bbeNFNRN7AHFiEa9hFYVb1p/eio=@vger.kernel.org X-Gm-Message-State: AOJu0YybfPakf+VCPn32IwAsYaTUGpn2zODiz0rjxNvVN7sIj2IL5lfV tBGs5ffXIGec9DM4sy+AMtpS8Yk5/o0ZAvE0lG3wKqsveVzTFhfVD2/vHAMJFMtD4Hw= X-Gm-Gg: ASbGncvRPB1x1+4VhVgaPy1S9H4V+ItM/mG9yQopFkUj4WGiCIchnFRV66w0MZA8ktv Pa3TmUAc4viEWfsJUfZyCGFUKlduL++idyhEgkwCVKTo2fJOpoF+r74z2TMX9eMtQPU/HxjhZQe 6P8HRp2vPHEDMhqZGHFj1/VLTgSJpojMi9LWPqIVq+FU3BVbyGWI8sliAH2FUCfFXfEWn6y/QwL 7qfmBEtFBr9G4/07URUH8Es/E/ukf76HMh+RtI1n/QP6Id29+BSEuSgEvSTL3hiUuiOac3Q1H9r CrA2pvqeCVXX51N8hb8W7dRRbzzFxwgmr2ExCbYqTkraejlaC/xeMjZOvYeJxQPoV4PtD7H8uZF 7AN891fXwWtYcPyfvwuwvRGkWOpCSvHs4nUPG75gUA9xk1oSljZNrB1QgnDXl8AYSOZNVFeulUi SeuGGrAm/PT7xzG01HtFbPl3k0X/W7u57hhF2fV+HXasqAfD94Y8oBT9gxf32q3HCWSKuDUA== X-Google-Smtp-Source: AGHT+IHcAxdLhGzdW1NI2UBF0IVQHMl6HFpUd/jJYBtOzICKf88GKwgE5spfrmYtn/8eULnHs4lGZg== X-Received: by 2002:a05:6512:3dac:b0:57a:8ae1:6a8e with SMTP id 2adb3069b0e04-5906d8ec20bmr5447249e87.6.1760601824219; Thu, 16 Oct 2025 01:03:44 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-590881f88ddsm6922497e87.31.2025.10.16.01.03.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Oct 2025 01:03:43 -0700 (PDT) Message-ID: <3202275a-25ec-435a-93ff-80a7ff8a8153@linaro.org> Date: Thu, 16 Oct 2025 11:03:42 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/6] dt-bindings: media: camss: Add qcom,kaanapali-camss binding To: Vijay Kumar Tumati , Bryan O'Donoghue , Hangxiang Ma , Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Todor Tomov , Mauro Carvalho Chehab Cc: linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, Jingyi Wang , Atiya Kailany References: <20251014-add-support-for-camss-on-kaanapali-v2-0-f5745ba2dff9@oss.qualcomm.com> <20251014-add-support-for-camss-on-kaanapali-v2-2-f5745ba2dff9@oss.qualcomm.com> <0b6c157a-3d8d-4251-a704-31f8369f6a4e@linaro.org> <62a3f09b-50d6-4ace-8229-d71585378ae1@oss.qualcomm.com> From: Vladimir Zapolskiy In-Reply-To: <62a3f09b-50d6-4ace-8229-d71585378ae1@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/16/25 06:46, Vijay Kumar Tumati wrote: > > On 10/15/2025 4:32 PM, Vladimir Zapolskiy wrote: >> On 10/16/25 00:43, Bryan O'Donoghue wrote: >>> On 15/10/2025 20:45, Vladimir Zapolskiy wrote: >>>>> +  power-domains: >>>>> +    items: >>>>> +      - description: >>>>> +          TFE0 GDSC - Thin Front End, Global Distributed Switch >>>>> Controller. >>>>> +      - description: >>>>> +          TFE1 GDSC - Thin Front End, Global Distributed Switch >>>>> Controller. >>>>> +      - description: >>>>> +          TFE2 GDSC - Thin Front End, Global Distributed Switch >>>>> Controller. >>>>> +      - description: >>>>> +          Titan GDSC - Titan ISP Block Global Distributed Switch >>>>> Controller. >>>>> + >>>>> +  power-domain-names: >>>>> +    items: >>>>> +      - const: tfe0 >>>>> +      - const: tfe1 >>>>> +      - const: tfe2 >>>> >>>> Please remove all 'tfeX' power domains, they are not going to be >>>> utilized >>>> any time soon. >>>> >>>> When 'power-domains' list is just a single Titan GDSC, >>>> 'power-domain-names' >>>> property is not needed. >>> >>> Each one of these TFEs powers an individually power-collapsible TFEs. >>> >>> This is also so with the other xFE power-domains on previous SoC >>> generations. >> >> This is false, for instance there is no management of SFEx power domains >> in SM8550 or X1E80100 CAMSS in the upstrem, neither there is no >> management >> of SBI, IPE, BPS, CPP and so on GDSC power domans given by CAMCCs. >> >> TFEx is no more special, if it's unused, then it should not be added. > I agree with Bryan, if I understood the original comment correctly. This > is no different to the IFE0/1/2 GDSCs on SM8550. All the other modules > listed above (SFE, IPE, BPS etc.) are not supported by the CAMSS driver > and hence there is no management. However, we need to manage the TOP and > TFE0/1/2 GDSCs for the real time RDI paths. Agreed, at first glance I didn't find the management of the TFE power domains in the driver's change 3/6 from this series, however now I see it was added along with the 6/6 change. This my comment is answered, thank you. >> >>> >>> You'll need the TFEx power-domain to process any data on TFEx with the >>> 'lite' versions being tied to the TOP GDSC. >> >> When it is needed, the documentation will be updated accordingly, >> right now >> it is unknown what a data processing on TFEx looks like, it might happen >> that there will be separate device tree nodes for TFEx. >> >> TFEx power domains shall be removed right now, unti; a usecase in the >> upstream >> CAMSS appears to use them, I haven't seen such code at the moment. >> > We attach these power power domains by name in the corresponding driver. > For instance, the VFE driver attaches the TFE power domains mentioned > here and are exercised from vfe_set_power() -> vfe_get() > ->vfe_pm_domain_on(). You can also see the related codes with '.has_pd' > and '.pd_name' properties in the CAMSS subdev resource structures. Hope > this clarifies. > -- Best wishes, Vladimir