From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754097AbdBGLpZ (ORCPT ); Tue, 7 Feb 2017 06:45:25 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:46465 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753285AbdBGLpY (ORCPT ); Tue, 7 Feb 2017 06:45:24 -0500 Subject: Re: [PATCH][net-next] net: bridge: remove redundant check to see if err is set To: Nikolay Aleksandrov , Stephen Hemminger , "David S . Miller" , bridge@lists.linux-foundation.org, netdev@vger.kernel.org References: <20170207105638.17918-1-colin.king@canonical.com> Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org From: Colin Ian King Message-ID: <32024608-8430-9d89-eec2-98057d4e2eb4@canonical.com> Date: Tue, 7 Feb 2017 11:43:50 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ..and one more thing, in net/bridge/br_netlink_tunnel.c, __get_num_vlan_tunnel_infos, are the args to vlan_tunnel_id_isrange() the wrong way around? I'm not 100% sure, but I'd thought I'd flag it up. if (v_start) { if ((v_end->vid - v->vid) > 0 && vlan_tunnel_id_isrange(v_end, v) > 0) num_tinfos += 2; else num_tinfos += 1; } On 07/02/17 11:30, Nikolay Aleksandrov wrote: > On 07/02/17 11:56, Colin King wrote: >> From: Colin Ian King >> >> The error check on err is redundant as it is being checked >> previously each time it has been updated. Remove this redundant >> check. >> >> Detected with CoverityScan, CID#140030("Logically dead code") >> >> Signed-off-by: Colin Ian King >> --- >> net/bridge/br_netlink.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c >> index fc5d885..cdc4e2a 100644 >> --- a/net/bridge/br_netlink.c >> +++ b/net/bridge/br_netlink.c >> @@ -612,9 +612,6 @@ static int br_afspec(struct net_bridge *br, >> return err; >> break; >> } >> - >> - if (err) >> - return err; >> } >> >> return err; >> > > Actually that code can be reduced further, I'll follow up with a patch later. > > Reviewed-by: Nikolay Aleksandrov > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >