From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752424AbcBOJVe (ORCPT ); Mon, 15 Feb 2016 04:21:34 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:58183 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751812AbcBOJVb (ORCPT ); Mon, 15 Feb 2016 04:21:31 -0500 From: Arnd Bergmann To: Daniel Baluta Cc: Jonathan Cameron , linux-arm-kernel@lists.infradead.org, "Andrew F . Davis" , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , "linux-iio@vger.kernel.org" , Linux Kernel Mailing List Subject: Re: [PATCH] iio: health/afe4403: mark suspend/resume functions __maybe_unused Date: Mon, 15 Feb 2016 10:20:49 +0100 Message-ID: <3204595.MT2N1UgYF8@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1455526993-2132098-1-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:DPemfrMXvEktBLM+QvxHdQLCqVj5WWaRTnejVnDJIfCnh3kzn5P XS/BNj+XNecs2rHjmChE/71/t9QvEuPRfDKd4pNWCL6Q11BU0bNyml0xfcsgJI+OoonuaHo iQe+kwNdV4ec103bLt799emX91oCRUeY3ZjV+mCpiWF5sMvovSP5HAGUfk9MQYHAW+nTAMJ zOdNvv01lPUTdU2kMzZJA== X-UI-Out-Filterresults: notjunk:1;V01:K0:9T77prCa2lk=:WNG/sXp+FoXryGqa9gJCaq s1F7qzXHavAqZdfyq/a+/3PIL9fgih1shpP3ctWOnZIHQ97/WhmpzGVgz6L5widfRQlfvqNZ8 40ANviiaYgHyvMFvPCJndNgu86iarTv5F5iVyJ/g/f3p58RTaIkXH3QpixcL2wjUnsUhkMfXE 6QXTnIN/pEROx9Kxpy6dU7498rWk46a3tCGiLFZKG1/YPutuU8ko/yO8+jnauRuSs7lvq6bDz iZFXkF5LRAaEeOVr0Ey9XoIbUDk1zD5VAmk/9V7gWJT+jFHB0VW5qlNjIGpRM7RZZ7ddjJqJV N689fdf5nEMDRjJPoiG88Sh3mFdE7oOQejTGLx7vK8xR22BxSR+fgufSUz96nUawygAhrHWO9 r2Q26qYOVPuKnZMEESooxVDqrowNL1jkurJmSmKZRyq2ImWJ+MPKI5RODxcN4egCJGyFOquzk wp7C4Trwi+eboZCrKAMZU5FGfN2o4yXnQF9bZACOyAHBNsuS0fzKTKh7F4REH16fzwcHQ29bt F6b4zPnKMDPc12Ou7G1ajV8RrY3BKr0Kfdl1TaXCvqbYOP8Cdq9NUq+Jk+nn4EQV3FxNcvvIl uPEd5rR6F7UqC31WfziyEDKhzMRXHPM6gSECQBYLOxhJfvls9STE1d3EI4lX2YWyxAGXf8zv+ A1KtCWO4r5x1o1EBSe4TT8i/Oyp+kHa+F0bq/0YyOdmjg3lG1jmjX7R6yKrtvedHfjf9EVLwE 0VDx1SEkmQEhX1/N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 15 February 2016 11:18:20 Daniel Baluta wrote: > On Mon, Feb 15, 2016 at 11:02 AM, Arnd Bergmann wrote: > > The newly added afe4403 driver implements suspend/resume using the > > SIMPLE_DEV_PM_OPS() macro, which leaves out references to the actual > > functions when CONFIG_PM is disabled, causing a harmless warning: > > > > health/afe4403.c:509:12: error: 'afe4403_suspend' defined but not used > > health/afe4403.c:530:12: error: 'afe4403_resume' defined but not used > > > > This marks the functions as __maybe_unused so we don't get those > > warnings. > > > Or we could put _suspend and _resume under CONFIG_PM_SLEEP. That never works reliably. I still have a backlog of ~50 patches of drivers that got this wrong in the past. > We have: > > :~/w/iio/drivers/iio$ ack-grep SIMPLE_DEV_PM_OPS | wc -l > 31 > > and only 2 drivers using __maybe_unused. > > :~/w/iio/drivers/iio$ ack-grep maybe_unused > gyro/itg3200_core.c > 354:static int __maybe_unused itg3200_suspend(struct device *dev) > 365:static int __maybe_unused itg3200_resume(struct device *dev) > > adc/imx7d_adc.c > 553:static int __maybe_unused imx7d_adc_suspend(struct device *dev) > 566:static int __maybe_unused imx7d_adc_resume(struct device *dev) > > For consistency, we should use CONFIG_PM_SLEEP and get rid of __maybe_unused. I hope to eventually kill off all the CONFIG_PM_SLEEP checks and then make it work automatically by redefining SIMPLE_DEV_PM_OPS so it leaves an unused reference to the functions. Arnd