From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA77FCD8CAB for ; Tue, 10 Oct 2023 16:32:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233403AbjJJQch (ORCPT ); Tue, 10 Oct 2023 12:32:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231231AbjJJQcf (ORCPT ); Tue, 10 Oct 2023 12:32:35 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B83E9D for ; Tue, 10 Oct 2023 09:31:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696955511; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cf2g84KWZibabOg5Y0fsYiGgR+PAP2xFlziRJuiWttw=; b=bGoCmfrXwNWssMHpBpsG19rvmL7/DSD/xhxD2HKEnFFTdBlgHBWcBQ8VtqMvv9xENoRTxp QeBUU7/b++hb2D5xvBzbdSkgUafLw4jaTUpW5rW4O+lNpQcBpUC6wcvNNpguGqMPVJJD9u NAsSsEs1hcxoXawoBRgSqzEEBOMZ6UU= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-317-1cD934ghPi-C_8t-rNKpbQ-1; Tue, 10 Oct 2023 12:31:50 -0400 X-MC-Unique: 1cD934ghPi-C_8t-rNKpbQ-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-9b98d8f6bafso471036466b.1 for ; Tue, 10 Oct 2023 09:31:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696955507; x=1697560307; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Cf2g84KWZibabOg5Y0fsYiGgR+PAP2xFlziRJuiWttw=; b=VjcauMxyOKvgeHSukITwMz9HvMOM++cNV65fyKMB3xWcwU9DkGE9slytavws0kIKDQ 1Ym4pO5DbO7FNv0iSgCmAsKyNAdckE+ae5k1TYeRMLeOvmtpv2Vcr3uWzwIn+1EkRsuB rl3YFg7JvHeVJSTihBUUtwDREnmkG85DLzVroiC9hDj4AqOUNy2I576VIj084LZEb52d h9rPltPdlCWCU3TRBus1KTCjQNkpUj3+KCTCPFAwwMGphOsFdCZmUZajxVVnZ1fObtSY hKgyh2OnHaE5Qf9HGKabHyZ/Zzi9GtSSSyi4iyNNVNfUIm3RUrKefK2toVqqyR0wKUOo ZZCw== X-Gm-Message-State: AOJu0YyOqH50Nvl5i6IfIBOOFs3HaX5sPMKNpzbhtqZGrgZY02GgvlcI WWBUOwGE1Qv2AAfdZeq0uYDXvPnDLorUMmoiYlL1QdE+HCziVDEqq0ATUlycaIOZjyFjYoy4f/3 rrYQqInD/TYjGvPnt31DKJGnO X-Received: by 2002:a17:906:8a64:b0:9a1:d29c:6aa9 with SMTP id hy4-20020a1709068a6400b009a1d29c6aa9mr16069476ejc.11.1696955506892; Tue, 10 Oct 2023 09:31:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGClLYRPDFww0sBjKrvTM/Spzqz91u3d3y4ItD8/C3zVG0gj1Uw0FLAJtwnyE66uijuqOQM/w== X-Received: by 2002:a17:906:8a64:b0:9a1:d29c:6aa9 with SMTP id hy4-20020a1709068a6400b009a1d29c6aa9mr16069454ejc.11.1696955506572; Tue, 10 Oct 2023 09:31:46 -0700 (PDT) Received: from ?IPV6:2a02:810d:4b3f:de9c:642:1aff:fe31:a15c? ([2a02:810d:4b3f:de9c:642:1aff:fe31:a15c]) by smtp.gmail.com with ESMTPSA id g20-20020a17090613d400b009b96e88759bsm8905722ejc.13.2023.10.10.09.31.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Oct 2023 09:31:46 -0700 (PDT) Message-ID: <3205eb86-f875-e597-9df6-628d5799cb12@redhat.com> Date: Tue, 10 Oct 2023 18:31:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v7 02/20] drm/gpuvm: Helper to get range of unmap from a remap op. Content-Language: en-US To: Sarah Walker , dri-devel@lists.freedesktop.org Cc: frank.binns@imgtec.com, donald.robson@imgtec.com, boris.brezillon@collabora.com, faith.ekstrand@collabora.com, airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, afd@ti.com, hns@goldelico.com, matthew.brost@intel.com, christian.koenig@amd.com, luben.tuikov@amd.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, corbet@lwn.net, linux-doc@vger.kernel.org References: <20231010133738.35274-1-sarah.walker@imgtec.com> <20231010133738.35274-3-sarah.walker@imgtec.com> From: Danilo Krummrich Organization: RedHat In-Reply-To: <20231010133738.35274-3-sarah.walker@imgtec.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/10/23 15:37, Sarah Walker wrote: > From: Donald Robson > > Determining the start and range of the unmap stage of a remap op is a > common piece of code currently implemented by multiple drivers. Add a > helper for this. > > Changes since v6: > - Remove use of __always_inline > > Signed-off-by: Donald Robson > Signed-off-by: Sarah Walker > --- > include/drm/drm_gpuvm.h | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/include/drm/drm_gpuvm.h b/include/drm/drm_gpuvm.h > index c7ed6bf441d4..932e942da921 100644 > --- a/include/drm/drm_gpuvm.h > +++ b/include/drm/drm_gpuvm.h > @@ -702,4 +702,31 @@ void drm_gpuva_remap(struct drm_gpuva *prev, > > void drm_gpuva_unmap(struct drm_gpuva_op_unmap *op); > > +/** > + * drm_gpuva_op_remap_get_unmap_range() - Helper to get the start and range of Not a strong opinion on that, but maybe drm_gpuva_op_remap_to_unmap_range() would be a bit better. > + * the unmap stage of a remap op. > + * @op: Remap op. > + * @start_addr: Output pointer for the start of the required unmap. > + * @range: Output pointer for the length of the required unmap. > + * > + * These parameters can then be used by the caller to unmap memory pages that > + * are no longer required. I think we should be a bit more precise on what this is good for. Maybe something like: "The given start address and range will be set such that they represent the range of the address space that was previously covered by the mapping getting re-mapped, but is empty now." > + */ > +static inline void > +drm_gpuva_op_remap_get_unmap_range(const struct drm_gpuva_op_remap *op, > + u64 *start_addr, u64 *range) > +{ > + const u64 va_start = op->prev ? > + op->prev->va.addr + op->prev->va.range : > + op->unmap->va->va.addr; > + const u64 va_end = op->next ? > + op->next->va.addr : > + op->unmap->va->va.addr + op->unmap->va->va.range; > + > + if (start_addr) > + *start_addr = va_start; > + if (range) > + *range = va_end - va_start; > +} > + > #endif /* __DRM_GPUVM_H__ */