From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758441AbcHCWmf (ORCPT ); Wed, 3 Aug 2016 18:42:35 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:15783 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754467AbcHCWmd (ORCPT ); Wed, 3 Aug 2016 18:42:33 -0400 Subject: Re: [PATCH] MIPS: dont specify STACKPROTECTOR in defconfigs To: Paul Gortmaker , References: <20160803190359.6486-1-paul.gortmaker@windriver.com> CC: Ionela Voinescu , Ralf Baechle , From: James Hartley Message-ID: <32093d53-44fe-1bde-261b-daf7bab500d9@imgtec.com> Date: Wed, 3 Aug 2016 23:41:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160803190359.6486-1-paul.gortmaker@windriver.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.167.31] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, On 03/08/16 20:03, Paul Gortmaker wrote: > Only one defconfig has a STACKPROTECTOR value. And it asks for > the strong variant, which isn't supported by older toolchains. > > Due to the nature of MIPS having more platform specific code than say > x86, the allyesconfig and allmodconfig aren't as effective for build > coverage. So, in addition, I like to use a trivial script to walk all > the defconfigs and build each one. > > However I will get false positives on unsupported stackprotector values > with an older toolchain like gcc-4.6.3. As in this instance I am just > using the compiler as a glorified syntax checker on a machine where I > build a bunch of other arch for the same reason, there is no real > motivation to get a newer toolchain for improved optimization etc. > > Since there is only one of them, and there is nothing about these > settings that are board/platform specific, I propose we just eliminate > the existing instance and take the default. Are you sure that this is not platform specific - my understanding is that this can be used to give a small security enhancement, which could be platform rather than arch specific. Either way, I don't believe that pistachio requires this option, so: Acked-by: James Hartley James. > > Cc: James Hartley > Cc: Ionela Voinescu > Cc: Ralf Baechle > Cc: linux-mips@linux-mips.org > Signed-off-by: Paul Gortmaker > --- > arch/mips/configs/pistachio_defconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/mips/configs/pistachio_defconfig b/arch/mips/configs/pistachio_defconfig > index 8b7429127a1d..698631327c8c 100644 > --- a/arch/mips/configs/pistachio_defconfig > +++ b/arch/mips/configs/pistachio_defconfig > @@ -29,7 +29,6 @@ CONFIG_CC_OPTIMIZE_FOR_SIZE=y > CONFIG_EMBEDDED=y > # CONFIG_COMPAT_BRK is not set > CONFIG_PROFILING=y > -CONFIG_CC_STACKPROTECTOR_STRONG=y > CONFIG_MODULES=y > CONFIG_MODULE_UNLOAD=y > CONFIG_MODULE_FORCE_UNLOAD=y