From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84B7B355055 for ; Thu, 5 Feb 2026 06:58:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770274735; cv=none; b=eByc3YqskPwurBBffO0pd5ZEmu1f8gOvHQqtolGj4rz+M+Ec9hnUbKaY6VeHB0+akqH7KDPM05wxwF45KgXpK5u4q65dpSKMcU0uj9p1SJ9STKMAESRnuGnU2y8czRtYhZ9jI5ATHBNpPcNEIdpc0t/RYArR6Daf1/t6ek03zbw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770274735; c=relaxed/simple; bh=OsQd4OJxQCGkeIltL4axA1jAp30tN349xP7T+sKbOro=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Y8HfUU+/YYyKgkPnN7eQBdS74CUMC7Ll6S0l40hurL9l37xgk9sNOm4S/AmwnRgvKMxFBALlKqC+4zzrPUNe5sAa7vq/A171PQWTrSE7JtxNVWAmhGuh7Q/t00Oo02eU8MG7Y2imbnjF/dxYw0hguJww11ICWsvTW1d2867EGvQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TBigeP3z; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZwapX/mO; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TBigeP3z"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZwapX/mO" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6153e1Ht3031134 for ; Thu, 5 Feb 2026 06:58:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9OILCwQRqxb5lWB8oBCRCwBrY3BXjDnIuW6UlVeYlWE=; b=TBigeP3zNnx5XnAO K1k5XLjiMGNq9AWavQPALj4WrwRru2JuiGbv3mP3YVsiDKkCZnUoCwhrlSa3Kq+z /EFl4ftsE76iVVAZiLwpXcn+qzbLuhQBbgJgvatbAYlRsx14Jvv0NYBQvcOQE9aZ PUiSWJJ5XCukz5mik8RpPqcL14b2kiN1kldPgOWH0wBskA8k0X0Bq1t4i6MTeDrY L4cjT1coVUbiq8Ijlj9e2gJPoDMyupM/LarMwLgjzLVCDJHou2TufjGeyluEi8xU 42d8hEHJ0ZcH0Tj9EpM+Q5o2qhTZ6cUk3tOCsto2giz6ApE/7OhZDdMGntj8nIUL 27nS0g== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c4a7tj5pj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 05 Feb 2026 06:58:54 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c67e92aad79so375241a12.0 for ; Wed, 04 Feb 2026 22:58:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770274734; x=1770879534; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9OILCwQRqxb5lWB8oBCRCwBrY3BXjDnIuW6UlVeYlWE=; b=ZwapX/mOirU5dGAMAz/IUyTvWV6EX0qxNdac/oRxn04toofatPHqvj/eXUBS3XK0PH L61jDd4AEqVu5tufsbFa6EsRMTL5genGm05SaT5FOnQBDDOVP8VgFN1qyzSOAvwQfMUv /ByeWOxBPF3TP1M6y2EpIlMg9Sfsf29fWKgtX3HG9ETJBwz7gVRkV7swpUz8IAGuRyuF +nG9nPVCJeBT5FrM5eADEm8O+ZkvWAM1e2Fxe3oh1gZ6LzLQzd/5T0NIdxvrVwNEyu7m EQqPVAmRBitL1dwbbaErVTpVd1JkmGappDpDhWi5J3ohALwnvOBwra4/rFaEH4TSPJNp eHCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770274734; x=1770879534; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9OILCwQRqxb5lWB8oBCRCwBrY3BXjDnIuW6UlVeYlWE=; b=ulINSJnPF0hCn2FXhCJECiiqWJ/G3ToG1kR7ZjTCZvp8r7twcKW9SWTWninygaM4DA C+8rb0u4jS59Be9qVIH4G9t4M7lfeiNJQtqPy0ILdybDS8eCpqZtKax67R26dVV/P7/U v68DwpLdHy9GbTq38H591yDV02h+FbIbAJFEYAYgSU4H80QTknq6ZBWeHUDG9bZuqIY1 bHk39Pv+Ih56VWC5L6PnbWd+PSYC3M0UWH3w7VGPU80lc+0inZiEjrReyZhEdWI9nhbB QtJ6/IydJU2NCkOMgv+ettE5izvv8+TL3yB1Uwd1kq8B79W5Le/h7vH2nRJDCZpwLPqB VnCg== X-Forwarded-Encrypted: i=1; AJvYcCXHNWFryV0HkbU2KVUJWBkBnQdMMlo12mvZZec4lppmvzdjHQJ7rnF11Ui4ZTZmAcVut9aU5r8uyd3rcLs=@vger.kernel.org X-Gm-Message-State: AOJu0Yzq92HoEL4ErLjL5YHxcMtXOF/NUp48ApnRMLOVwgQRQEcsCS89 C+0rmEpxOIuewuhpAcxexJ2+SyT+fXYwLZ64h/WXd1DImulWcq1E0drk/q4b/ZY9g69l8QTtlH7 ugcVrj6fbP0wNUyjvEvgtvcmiH5olBMWhoPfZ8ciV9ghg72wJvNrel/tWaPQb3jjcK5w= X-Gm-Gg: AZuq6aIJQFfUFD0USEDVv4+rVRkEY4Z9nvMS4p0niK2fOE4d6iMJ0JpnNIjCcKj2PtZ 7D23y0XY+fG8qeHBGE5IyVQP4cQOg2QOJzYYjOVt3P2xuTQKt+9qEES4aSYff/z2rf3NE/fru7B YuXMoHDQysK7nXQs8Kfc8cUHfZLZiYV2CE45LGrh0z52ql5AuOpRiLeaVhVX9TIqDyMcrx8yy9B NbAeu3yoR4ByfYkwdNZLn0a22QZj7bOpaQctcnD01QW3N4BEihLAdxedUDtff7/fGPXscxCWXpC PN3O+9lNHrfzV44onHivcom0PoZjszTtveq0GQwBsgI2dJIbinMWPxuFQYwPRDaZ3a4T0wzgNph QHqo4LCrp7vFuiunCfymvWas1QqtDfhmO/xzh8sm8rhJ3Ew== X-Received: by 2002:a05:6a00:2d27:b0:821:8ea4:480e with SMTP id d2e1a72fcca58-8241c19cff1mr5281552b3a.10.1770274734023; Wed, 04 Feb 2026 22:58:54 -0800 (PST) X-Received: by 2002:a05:6a00:2d27:b0:821:8ea4:480e with SMTP id d2e1a72fcca58-8241c19cff1mr5281523b3a.10.1770274733498; Wed, 04 Feb 2026 22:58:53 -0800 (PST) Received: from [10.204.101.146] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8241d163865sm5163450b3a.9.2026.02.04.22.58.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Feb 2026 22:58:52 -0800 (PST) Message-ID: <3209b0f8-618b-8de1-95f3-e1bc533ba933@oss.qualcomm.com> Date: Thu, 5 Feb 2026 12:28:42 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v3 6/7] arm64: dts: qcom: sm8250: sort out Iris power domains Content-Language: en-US To: Dmitry Baryshkov , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , Jonathan Marek , Ulf Hansson , "Rafael J. Wysocki" , Bryan O'Donoghue , Vikash Garodia , Mauro Carvalho Chehab , Stanimir Varbanov , Abhinav Kumar , Hans Verkuil , Stefan Schmidt , Konrad Dybcio , Bryan O'Donoghue , Dikshita Agarwal Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-media@vger.kernel.org, Mauro Carvalho Chehab , Konrad Dybcio References: <20260204-iris-venus-fix-sm8250-v3-0-70fa68e57f96@oss.qualcomm.com> <20260204-iris-venus-fix-sm8250-v3-6-70fa68e57f96@oss.qualcomm.com> From: Dikshita Agarwal In-Reply-To: <20260204-iris-venus-fix-sm8250-v3-6-70fa68e57f96@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: NIKR-VD7g3IwtV-jn6g4EfDIj5SV3wxj X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA1MDA0OCBTYWx0ZWRfX2Yk0E72nilPl MxuQ7tB/sNUKTvbsRH/PIx1+oOI12uMGszRQiYHqawecWICUijxEMM3paoIqZ9DpD4aM+M7viJa Natpf+Vo3SYEPurzfOvPwtpms/R4qkkWaAGBRi1EQkwMD/2tNJpsl5zeiJFOaZpc5kA1kPmFSic +Y5+SLK8SiGQXKdY0en52jfmRTw5CE4viItM64lL7Z7tj9wR3Vwt2p9+dLWsmkb2jyG6PfM5Opk G+ALNmaJae3TwysPnGgQ9WT/gV+0Si4l82Zv+5DtyWbVGk6nyCGcyOZgcxM6QoambMKNgcfTQR1 lezMcZ9JfN8H1nqzoY8wBbdiIlcuUgy/wtgEEN2jLRgj+T+1GcW92SKXKrhv3B5FmPIvQoPpWxs iaDTNAHKXEN13IO6+b7e7S9ydbEKND9gEhQSmchCK11QyR3LNiNbHcf+FUeRNZgEnC45JS+qW8Y DGbu27QXFeP8RA5M2Rg== X-Proofpoint-GUID: NIKR-VD7g3IwtV-jn6g4EfDIj5SV3wxj X-Authority-Analysis: v=2.4 cv=QaVrf8bv c=1 sm=1 tr=0 ts=69843fae cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=KaDJ12nNnFZpivlZOL4A:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-05_01,2026-02-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 bulkscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602050048 On 2/4/2026 6:29 AM, Dmitry Baryshkov wrote: > On SM8250 Iris core requires two power rails to function, MX (for PLLs) > and MMCX (for everything else). The commit fa245b3f06cd ("arm64: dts: > qcom: sm8250: Add venus DT node") added only MX power rail, but, > strangely enough, using MMCX voltage levels. > > Add MMCX domain together with the (more correct) MX OPP levels. > > Fixes: fa245b3f06cd ("arm64: dts: qcom: sm8250: Add venus DT node") > Reported-by: Konrad Dybcio > Reviewed-by: Konrad Dybcio > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 20 ++++++++++++++------ > 1 file changed, 14 insertions(+), 6 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index 980d6e894b9d..d8be5c1add1b 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -4321,8 +4321,12 @@ venus: video-codec@aa00000 { > interrupts = ; > power-domains = <&videocc MVS0C_GDSC>, > <&videocc MVS0_GDSC>, > - <&rpmhpd RPMHPD_MX>; > - power-domain-names = "venus", "vcodec0", "mx"; > + <&rpmhpd RPMHPD_MX>, > + <&rpmhpd RPMHPD_MMCX>; > + power-domain-names = "venus", > + "vcodec0", > + "mx", > + "mmcx"; > operating-points-v2 = <&venus_opp_table>; > > clocks = <&gcc GCC_VIDEO_AXI0_CLK>, > @@ -4348,22 +4352,26 @@ venus_opp_table: opp-table { > > opp-720000000 { > opp-hz = /bits/ 64 <720000000>; > - required-opps = <&rpmhpd_opp_low_svs>; > + required-opps = <&rpmhpd_opp_svs>, > + <&rpmhpd_opp_low_svs>; > }; > > opp-1014000000 { > opp-hz = /bits/ 64 <1014000000>; > - required-opps = <&rpmhpd_opp_svs>; > + required-opps = <&rpmhpd_opp_svs>, > + <&rpmhpd_opp_svs>; > }; > > opp-1098000000 { > opp-hz = /bits/ 64 <1098000000>; > - required-opps = <&rpmhpd_opp_svs_l1>; > + required-opps = <&rpmhpd_opp_svs_l1>, > + <&rpmhpd_opp_svs_l1>; > }; > > opp-1332000000 { > opp-hz = /bits/ 64 <1332000000>; > - required-opps = <&rpmhpd_opp_nom>; > + required-opps = <&rpmhpd_opp_svs_l1>, > + <&rpmhpd_opp_nom>; > }; > }; > }; > Reviewed-by: Dikshita Agarwal Thanks, Dikshita