From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: Stephen Brennan <stephen@brennan.io>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
Florian Fainelli <f.fainelli@gmail.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Scott Branden <sbranden@broadcom.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-kernel@lists.infradead.org, Ray Jui <rjui@broadcom.com>,
linux-kernel@vger.kernel.org, Eric Anholt <eric@anholt.net>,
Rob Herring <robh+dt@kernel.org>,
bcm-kernel-feedback-list@broadcom.com,
Stefan Wahren <wahrenst@gmx.net>, Matt Mackall <mpm@selenic.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: dts: bcm2711: Enable HWRNG support
Date: Mon, 18 Nov 2019 12:44:59 +0100 [thread overview]
Message-ID: <3209f601ad0537a7ef01e2a752f022ccf8816210.camel@suse.de> (raw)
In-Reply-To: <20191118075807.165126-4-stephen@brennan.io>
[-- Attachment #1: Type: text/plain, Size: 1265 bytes --]
Hi Stephen,
On Sun, 2019-11-17 at 23:58 -0800, Stephen Brennan wrote:
> From: Stefan Wahren <wahrenst@gmx.net>
>
> This enables hardware random number generator support for the BCM2711
> on the Raspberry Pi 4 board.
>
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
> Signed-off-by: Stephen Brennan <stephen@brennan.io>
> ---
> arch/arm/boot/dts/bcm2711.dtsi | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi
> index ac83dac2e6ba..2c19e5de284a 100644
> --- a/arch/arm/boot/dts/bcm2711.dtsi
> +++ b/arch/arm/boot/dts/bcm2711.dtsi
> @@ -92,10 +92,9 @@ pm: watchdog@7e100000 {
> };
>
> rng@7e104000 {
> + compatible = "brcm,bcm2711-rng200";
> interrupts = <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>;
> -
> - /* RNG is incompatible with brcm,bcm2835-rng */
> - status = "disabled";
> + status = "okay";
> };
>
> uart2: serial@7e201400 {
We inherit the reg property from bcm283x.dtsi, on which we only define a size
of 0x10 bytes. I gather from the driver that iproc-rng200's register space is
at least 0x28 bytes big. We should also update the 'reg' property to:
reg = <0x7e104000 0x28>;
Regards,
Nicolas
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-11-18 11:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 7:58 [PATCH 0/3] Raspberry Pi 4 HWRNG Support Stephen Brennan
2019-11-18 7:58 ` [PATCH 1/3] dt-bindings: rng: add BCM2711 RNG compatible Stephen Brennan
2019-11-18 7:58 ` [PATCH 2/3] hwrng: iproc-rng200: Add support for BCM2711 Stephen Brennan
2019-11-18 7:58 ` [PATCH 3/3] ARM: dts: bcm2711: Enable HWRNG support Stephen Brennan
2019-11-18 11:44 ` Nicolas Saenz Julienne [this message]
2019-11-18 19:44 ` Stefan Wahren
2019-11-19 5:49 ` Stephen Brennan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3209f601ad0537a7ef01e2a752f022ccf8816210.camel@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mpm@selenic.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=stephen@brennan.io \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®