mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Laight <David.Laight@ACULAB.COM>
To: "'Martin K. Petersen'" <martin.petersen@oracle.com>,
	Stephen Kitt <steve@sk2.org>
Cc: "hare@suse.com" <hare@suse.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"kernel-hardening@lists.openwall.com"
	<kernel-hardening@lists.openwall.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] bfa: remove VLA
Date: Thu, 15 Mar 2018 11:40:05 +0000	[thread overview]
Message-ID: <32130f556f09408686626c50c70b39c9@AcuMS.aculab.com> (raw)
In-Reply-To: <yq18tau7y4f.fsf@oracle.com>

> > -		sizeof(wwn_t[iocmd->nports])) != BFA_STATUS_OK) {
> > +		sizeof(wwn_t) * iocmd->nports) != BFA_STATUS_OK) {
> 
> These parentheses made me blurry eyed but it's actually OK.

		iocmd->nports * sizeof(wwn_t)) != BFA_STATUS_OK) {

is easier to focus on :-)

	David

      reply	other threads:[~2018-03-15 11:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-08 21:38 Stephen Kitt
2018-03-08 21:43 ` Kees Cook
2018-03-09 22:15   ` Stephen Kitt
2018-03-15  4:37 ` Martin K. Petersen
2018-03-15 11:40   ` David Laight [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32130f556f09408686626c50c70b39c9@AcuMS.aculab.com \
    --to=david.laight@aculab.com \
    --cc=hare@suse.com \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=steve@sk2.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®