From: "Huang, Kai" <kai.huang@intel.com>
To: "pbonzini@redhat.com" <pbonzini@redhat.com>,
"seanjc@google.com" <seanjc@google.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 8/9] KVM: x86: Unpack msr_data structure prior to calling kvm_apic_set_base()
Date: Mon, 4 Nov 2024 10:28:56 +0000 [thread overview]
Message-ID: <3213afd28974933d7597238f4434c4589f89b2a3.camel@intel.com> (raw)
In-Reply-To: <20241101183555.1794700-9-seanjc@google.com>
On Fri, 2024-11-01 at 11:35 -0700, Sean Christopherson wrote:
> Pass in the new value and "host initiated" as separate parameters to
> kvm_apic_set_base(), as forcing the KVM_SET_SREGS path to declare and fill
> an msr_data structure is awkward and kludgy, e.g. __set_sregs_common()
> doesn't even bother to set the proper MSR index.
>
> No functional change intended.
>
> Suggested-by: Kai Huang <kai.huang@intel.com>
> Signed-off-by: Sean Christopherson <seanjc@google.com>
>
Reviewed-by: Kai Huang <kai.huang@intel.com>
next prev parent reply other threads:[~2024-11-04 10:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 18:35 [PATCH v2 0/9] KVM: x86: Clean up MSR_IA32_APICBASE_BASE code Sean Christopherson
2024-11-01 18:35 ` [PATCH v2 1/9] KVM: x86: Short-circuit all kvm_lapic_set_base() if MSR value isn't changing Sean Christopherson
2024-11-01 18:35 ` [PATCH v2 2/9] KVM: x86: Drop superfluous kvm_lapic_set_base() call when setting APIC state Sean Christopherson
2024-11-01 18:35 ` [PATCH v2 3/9] KVM: x86: Get vcpu->arch.apic_base directly and drop kvm_get_apic_base() Sean Christopherson
2024-11-01 18:35 ` [PATCH v2 4/9] KVM: x86: Inline kvm_get_apic_mode() in lapic.h Sean Christopherson
2024-11-01 18:35 ` [PATCH v2 5/9] KVM: x86: Move kvm_set_apic_base() implementation to lapic.c (from x86.c) Sean Christopherson
2024-11-01 18:35 ` [PATCH v2 6/9] KVM: x86: Rename APIC base setters to better capture their relationship Sean Christopherson
2024-11-01 18:35 ` [PATCH v2 7/9] KVM: x86: Make kvm_recalculate_apic_map() local to lapic.c Sean Christopherson
2024-11-01 18:35 ` [PATCH v2 8/9] KVM: x86: Unpack msr_data structure prior to calling kvm_apic_set_base() Sean Christopherson
2024-11-04 10:28 ` Huang, Kai [this message]
2024-11-01 18:35 ` [PATCH v2 9/9] KVM: x86: Short-circuit all of kvm_apic_set_base() if MSR value is unchanged Sean Christopherson
2024-11-04 10:59 ` Huang, Kai
2024-11-04 23:03 ` Sean Christopherson
2024-11-05 5:56 ` [PATCH v2 0/9] KVM: x86: Clean up MSR_IA32_APICBASE_BASE code Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3213afd28974933d7597238f4434c4589f89b2a3.camel@intel.com \
--to=kai.huang@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®