mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Martin Karsten <mkarsten@uwaterloo.ca>
To: Mani Tofigh <mt4022@columbia.edu>, Eric Dumazet <edumazet@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	Andrew Lunn <andrew+netdev@lunn.ch>, Joe Damato <joe@dama.to>,
	Dragos Tatulea <dtatulea@nvidia.com>,
	Kuniyuki Iwashima <kuniyu@google.com>,
	Stanislav Fomichev <sdf.kernel@gmail.com>,
	Sridhar Samudrala <sridhar.samudrala@intel.com>,
	Cosmin Ratiu <cratiu@nvidia.com>,
	Tariq Toukan <tariqt@nvidia.com>,
	Wang Zhan <wang.zhan@smartx.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	tz2294@columbia.edu
Subject: Re: [PATCH net] net: cancel napi->timer after the grace period in netif_napi_del()
Date: Sat, 14 Nov 2026 12:26:08 -0500	[thread overview]
Message-ID: <321482ad-e462-4791-b08b-652d66a2452f@uwaterloo.ca> (raw)
In-Reply-To: <06ca7638-85a6-4fb6-9cac-b495d213ac05@columbia.edu>

On 2026-11-05 16:43, Mani Tofigh wrote:
> On 11/3/26 7:55 PM, Martin Karsten wrote:
>>      if (unlikely(napi_is_scheduled(n)))
>>        hrtimer_cancel(&n->timer);
> 
> 
> This worked here too, but I think the cancel could hit a timer that a
> new owner just armed (e.g., a busy poller that clears SCHED and arms
> its own timer right before our check). I'll go with Eric's version.

Thanks, agreed, I missed that. But, could we use the new DISABLED flag 
from commit 8dc87fc5d6a0 ("net: Use a dedicated flag to track disabled 
napi instances") instead of SCHED with the same logic? Just thinking out 
loud here.

Best,
Martin


  reply	other threads:[~2026-11-14 17:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03 18:19 Mani Tofigh via B4 Relay
2026-11-03 18:37 ` Eric Dumazet
2026-11-04  0:55   ` Martin Karsten
2026-11-05 21:43     ` Mani Tofigh
2026-11-14 17:26       ` Martin Karsten [this message]
2026-11-05 21:40   ` Mani Tofigh
2026-11-06  9:22 ` netdev-bot+sashiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=321482ad-e462-4791-b08b-652d66a2452f@uwaterloo.ca \
    --to=mkarsten@uwaterloo.ca \
    --cc=andrew+netdev@lunn.ch \
    --cc=cratiu@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=dtatulea@nvidia.com \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=joe@dama.to \
    --cc=kuba@kernel.org \
    --cc=kuniyu@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mt4022@columbia.edu \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sdf.kernel@gmail.com \
    --cc=sridhar.samudrala@intel.com \
    --cc=tariqt@nvidia.com \
    --cc=tz2294@columbia.edu \
    --cc=wang.zhan@smartx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®