From: David Howells <dhowells@redhat.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: dhowells@redhat.com, linux-security-module@vger.kernel.org,
keyrings@vger.kernel.org, kernel-hardening@lists.openwall.com,
linux-kernel@vger.kernel.org, ebiggers3@gmail.com,
Herbert Xu <herbert@gondor.apana.org.au>,
Kirill Marinushkin <k.marinushkin@gmail.com>,
security@kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v7 2/2] security/keys: rewrite all of big_key crypto
Date: Mon, 25 Sep 2017 15:43:59 +0100 [thread overview]
Message-ID: <32200.1506350639@warthog.procyon.org.uk> (raw)
In-Reply-To: <20170920145839.27511-2-Jason@zx2c4.com>
Jason A. Donenfeld <Jason@zx2c4.com> wrote:
> + /* no ->update(); don't add it without changing big_key_crypt() nonce */
Should update be a problem. It's should be a complete payload replacement -
kind of like unlink and add, but keeping the same key ID and description.
David
next prev parent reply other threads:[~2017-09-25 14:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 14:58 [PATCH v7 1/2] security/keys: properly zero out sensitive key material in big_key Jason A. Donenfeld
2017-09-20 14:58 ` [PATCH v7 2/2] security/keys: rewrite all of big_key crypto Jason A. Donenfeld
2017-09-25 14:43 ` David Howells [this message]
2017-09-25 16:38 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32200.1506350639@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=Jason@zx2c4.com \
--cc=ebiggers3@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=k.marinushkin@gmail.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=security@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®