From: Marcel Holtmann <marcel@holtmann.org>
To: Joseph Hwang <josephsih@chromium.org>
Cc: linux-bluetooth <linux-bluetooth@vger.kernel.org>,
"Luiz Augusto von Dentz" <luiz.dentz@gmail.com>,
"Pali Rohár" <pali@kernel.org>,
"CrosBT Upstreaming"
<chromeos-bluetooth-upstreaming@chromium.org>,
"Joseph Hwang" <josephsih@google.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Johan Hedberg" <johan.hedberg@gmail.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH v7 1/2] Bluetooth: Add struct of reading AOSP vendor capabilities
Date: Tue, 2 Nov 2021 19:41:18 +0100 [thread overview]
Message-ID: <32223CC8-EAC3-42F3-8C34-F60A2B62F9DD@holtmann.org> (raw)
In-Reply-To: <20211102151908.v7.1.I139e71adfd3f00b88fe9edb63d013f9cd3e24506@changeid>
Hi Joseph,
> This patch adds the struct of reading AOSP vendor capabilities.
> New capabilities are added incrementally. Note that the
> version_supported octets will be used to determine whether a
> capability has been defined for the version.
>
> Signed-off-by: Joseph Hwang <josephsih@chromium.org>
>
> ---
>
> Changes in v7:
> - Use the full struct aosp_rp_le_get_vendor_capa. If the
> version_supported is >= 98, check bluetooth_quality_report_support.
> - Use __le16 and __le32.
> - Use proper bt_dev_err and bt_dev_warn per review comments.
> - Skip unnecessary bt_dev_dbg.
> - Remove unnecessary rp->status check.
> - Skip unnecessary check about version_supported on versions that we
> do not care about. For now, we only care about quality report support.
> - Add the define for the length of the struct.
> - Mediatek will submit a separate patch to enable aosp.
>
> Changes in v6:
> - Add historical versions of struct aosp_rp_le_get_vendor_capabilities.
> - Perform the basic check about the struct length.
> - Through the version, bluetooth_quality_report_support can be checked.
>
> Changes in v5:
> - This is a new patch.
> - Add struct aosp_rp_le_get_vendor_capabilities so that next patch
> can determine whether a particular capability is supported or not.
>
> include/net/bluetooth/hci_core.h | 1 +
> net/bluetooth/aosp.c | 83 +++++++++++++++++++++++++++++++-
> 2 files changed, 83 insertions(+), 1 deletion(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
prev parent reply other threads:[~2021-11-02 18:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 7:19 Joseph Hwang
2021-11-02 7:19 ` [PATCH v7 2/2] Bluetooth: aosp: Support AOSP Bluetooth Quality Report Joseph Hwang
2021-11-02 18:41 ` Marcel Holtmann
2021-11-02 7:51 ` [PATCH v7 1/2] Bluetooth: Add struct of reading AOSP vendor capabilities Marcel Holtmann
2021-11-02 18:41 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32223CC8-EAC3-42F3-8C34-F60A2B62F9DD@holtmann.org \
--to=marcel@holtmann.org \
--cc=chromeos-bluetooth-upstreaming@chromium.org \
--cc=davem@davemloft.net \
--cc=johan.hedberg@gmail.com \
--cc=josephsih@chromium.org \
--cc=josephsih@google.com \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pali@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®