Re: [PATCH] arm64: dts: qcom: qcs8300: Add support for camss

[Wenmeng Liu <quic_wenmliu@quicinc.com>]

On 2025/5/20 17:47, Krzysztof Kozlowski wrote:
> On 20/05/2025 11:45, Krzysztof Kozlowski wrote:
>> On 20/05/2025 11:40, Wenmeng Liu wrote:
>>> This change enables camera driver for QCS8300 RIDE board.
>>>
>>> ---
>>> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
>>> ---
>>> This patch series depends on patch series:
>>> - https://lore.kernel.org/all/20250214095611.2498950-1-quic_vikramsa@quicinc.com/
>>> - https://lore.kernel.org/all/20250211-sa8775p_tpg-v1-1-3f76c5f8431f@quicinc.com/
>>> - https://lore.kernel.org/all/20250217-qcs8300_tpg-v1-1-6e0f4dd3ad1f@quicinc.com/
>>> - https://lore.kernel.org/all/20250214094747.2483058-1-quic_vikramsa@quicinc.com/
>> No, please stop for now and see my other comments. You cannot send patch
>> which depends on 4 different patchsets! This is making merging
>> impossible and puts effort on maintainer to track these dependencies.
>>
>> Plus this was not even tested.
>>
> ... and:
> 
> Please run scripts/checkpatch.pl on the patches and fix reported
> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
> patches and (probably) fix more warnings. Some warnings can be ignored,
> especially from --strict run, but the code here looks like it needs a
> fix. Feel free to get in touch if the warning is not clear.
> 
> Please do not use "This commit/patch/change", but imperative mood. See
> longer explanation here:
> https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
> 
> I suggest to read your internal guideline before posting. It is quite
> comprehensive.
> 
> Best regards,
> Krzysztof


Thank you for the reminder, Will make sure to pay attention to it.

Thanks,
Wenmeng