From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EAFE36BCC9 for ; Thu, 26 Feb 2026 06:07:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772086059; cv=none; b=ou0Io9IXPiND7SWAfFW2K3qO9v8FkwSPL8B5QLXNqiQDQ12ALw/WD1GkcbL4vLjXyaQDZBMLtAKHPiQXqfBNWlzccZORUzB6VIsj5jxXiC8ooVl9VJifr30NYaQvq0UeC2GXY3F+oUSxJQjI4bimt7MkWPSB/uRQdzagZmWzo3o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772086059; c=relaxed/simple; bh=QvWibBva0xSDel4cPOlNzbIBCNUOeMrXiE379I3hyPQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hJOK9UabWsdJC+25mayg4UGw3GfD+QFCsR56AtdLL/PRECdL9cyCyckawuHgqwSyvRydVeCGJrnCfx/xoiLW+jhODP+LUA7U5mIt0fU3nRVocCZ+pPaiE2wJrI4cR9pSTK+eU/Ov/zIfEL6eE11v4aPxWbsaBsw6lS0Fl+HpAF8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mRpRAsCU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JoGIOVAw; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mRpRAsCU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JoGIOVAw" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61Q4VL7M3721872 for ; Thu, 26 Feb 2026 06:07:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BeHB229LAHK62S/IYU9XzvqGNdRbg1JR9qdKYw6/ls4=; b=mRpRAsCUzV5g29KJ MVEUWokgEgo+PlA2MbaGHY8a4G9XVYQu0ptG6vHSUzodF62jMErizfog+bGJBN8g eHKKEHT2ec9ZOYrwRGWBJyVWnaKE33f2cl9uDmCHw9ZnWkqpLgc69gijSDkpgBvQ oHFELGHm3CAPHTXEfXSiOKrDyBs0d1rP/nyDLY5wqAW8bzxpjbjBBnOVwBu84bBY Lg01IV+vUCp9dYcjYYcX04xZgviAN72bCErWZ1Mj2VV1guqKaoyfq1cae/ewtrVM yjAby7CdCJfYsyVPyGxDB0Y6mA4b/sioR/uATNkcBV7wEWFO1mejBDV60htGGEIy AJEU4g== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4chyvf33h4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 26 Feb 2026 06:07:37 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-8273855525aso620714b3a.0 for ; Wed, 25 Feb 2026 22:07:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772086056; x=1772690856; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BeHB229LAHK62S/IYU9XzvqGNdRbg1JR9qdKYw6/ls4=; b=JoGIOVAwOeEftlPVpqLsQokfwmd91BG12SXuRvXNi0zdke6l9JO2R7jtJnXeHn+N++ 1NoiqaTLJxDW2nW4ofz0nN/30BsW8tQS1mazDkEC0oeeDdZXwAJCjKbeygWAPRsmP6UP eIiMF6QO7h9eWJaEZxuwJbyNH0I/LgqDXEWe+GuWmiMg6XiPIfWXKEgPvshk1qRYGT2b EQSyAjd0qeqlPpM5XEuFcn3N+1b33A2bTlyxcqIIZcGcd9t2aap92fqlT1Zl9AiIJjpM qmnjdhOvEqkoSwGzWyfhoSTcHQeMtqMgjT2KM/47D0iFnwaVpcxQya0SfBYIOi7o7TFZ SzMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772086056; x=1772690856; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BeHB229LAHK62S/IYU9XzvqGNdRbg1JR9qdKYw6/ls4=; b=S1Jb751oFum9QbJ+zn+hN7PbWIJ+AKp/xvFLPCHnb8pBgjcVBYEzmX3JrXV8cIZXGE Xu1B/3jc8vxxj37o28DWeu0dOTkr6+UmHOOActCIQ3I7oecAUJjbyG2qV8+D3l7ol6Kf z+OUzHMo/Qcp7hCx4H7Jai6E4jyN2rLXQX1Ra/Z37bi5KczadIS8XgSBXYu4D63s60tK UKIbSCoZVnT5Sdd6Jk2PG81r+ztkF+oNmMcQqRHDD9WoGcuKVQVWqx4DjQzPs07laIQk GtQ3p0tRI6bvJCgwQRtWlm5dKIZ52muCwTFc119pq//gJlZTrBXAxfn26D9JfgMV3QXw EM3w== X-Gm-Message-State: AOJu0YxPYtDMyoM43jQI/gwaxvgIPUA8Q4o1OJ4lYeFfM5IpBK2VK4iX qMKqMOs8O6hJg6bnXQS++ZfCCBEFtvToemHGwMbESmHKoDdVrvMUoN1eVR9aigyWVOjuyb+Yu4M oE57OEKUV1UGCfWueFUXS8vAqYF/2MIWRDqdewaBCXmifSlRqSzl1NC1BnTASQrXjk9OIzCt2L+ s= X-Gm-Gg: ATEYQzwI1KNQUlK+hLqKuECdxhl8WVmktOmiBq7zQsflkduLJl2W3yo3zvoT5B2XFql tWRxWdu4OjzxMAEO+LudnzTIQ1fEhXsmORgBxY7smuN8B09gBORxw0B74w3I+ch5pP8QyvumjmL mrjNKqL/bpGUX2EWjixlv6aqx30ZjImGPONQiuUtjtBABpwmq5oHsHNeDGHA2ybb72dW55fdp6P dIkEXNFS2HOxjIYekbJD1SRLjnD0v6JswBrsZkypr7EarmCGrXo3ydVAXur7ktZRYc4OQuz0FOk wUohzOmlDK5sv9auOmxrS9AfxUIhaCZDYCCzIdRZu3suPbIwd2bR1ZPF0ZtiKvnI35/ZvXR6OSC wCx8Zz4ZEP87QwUdKIqtOGBhh4pb+E2+mYcNCbkh0Ko+sJ0qpoKSPYJYWJDpNFkJKN089hwiYol zhDbMXZ+nLaQ== X-Received: by 2002:a05:6a00:cc8:b0:827:2b7f:e1d0 with SMTP id d2e1a72fcca58-82739827658mr1697786b3a.24.1772086056044; Wed, 25 Feb 2026 22:07:36 -0800 (PST) X-Received: by 2002:a05:6a00:cc8:b0:827:2b7f:e1d0 with SMTP id d2e1a72fcca58-82739827658mr1697755b3a.24.1772086055513; Wed, 25 Feb 2026 22:07:35 -0800 (PST) Received: from [10.133.33.67] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82739dabd43sm1290899b3a.25.2026.02.25.22.07.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Feb 2026 22:07:35 -0800 (PST) Message-ID: <32309e19-e193-4f56-80c4-39b028f05876@oss.qualcomm.com> Date: Thu, 26 Feb 2026 14:07:28 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 1/7] dt-bindings: arm: Add support for Qualcomm TGU trace To: Songwei Chai , andersson@kernel.org, alexander.shishkin@linux.intel.com, mike.leach@linaro.org, konrad.dybcio@oss.qualcomm.com, suzuki.poulose@arm.com, james.clark@arm.com, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org, devicetree@vger.kernel.org, gregkh@linuxfoundation.org, Rob Herring References: <20260226020454.3210149-1-songwei.chai@oss.qualcomm.com> <20260226020454.3210149-2-songwei.chai@oss.qualcomm.com> Content-Language: en-US From: Jie Gan In-Reply-To: <20260226020454.3210149-2-songwei.chai@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: m6SdJgFCqEik08GhYEKUenhhg-jxHh-0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI2MDA1MSBTYWx0ZWRfXwVMw7eNetSNO 1xuSkqO8fjlB2YTA5YVgXftxiK/KLnLlurLumQCty6GCFyCAJpc/Ey2d3WaQKmcRJwX4hVbPCnu 5IApyAi24F2mTKnB+80BN3xeNQ+SKJfmS34LZ46qEaQLR/XIoDONgwCImlKmQvJxAKfdDUwLIBt ZSxrRWSz2QrEdIvFEHHrrDTrU/ug42FzBL/0EN+lQEzM90YnFELq8aV650Hhs0ToPkCE+0lek7r aaRlKag+LmWwQLctS47eEpGrcxzS0aYUiCbn5G/Zg0h7KMfPqMxf60+VMVDvSf4iMoxV7KsLOBT +SB0dJ6+M0QjGDYtTm21N6p9PQe+E9KAMyQ8nVwmHi5Gi1hH3IfCkMWi8gRw57u9uF+f6pTtKZX CtdWYZp5YRNvSOajG3JHNXGJNTMVrsB7YC5lJf/GXhq9mGr3ly7kmqLwEdhrkbnQxzf7IVlda0j wZanjNNIZZMnae/C8sA== X-Proofpoint-GUID: m6SdJgFCqEik08GhYEKUenhhg-jxHh-0 X-Authority-Analysis: v=2.4 cv=dZWNHHXe c=1 sm=1 tr=0 ts=699fe329 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=gEfo2CItAAAA:8 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=IwjJGIUIzvyStixYlZUA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 a=sptkURWiP4Gy88Gu7hUp:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-25_04,2026-02-25_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 suspectscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 spamscore=0 impostorscore=0 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602260051 On 2/26/2026 10:04 AM, Songwei Chai wrote: > The Trigger Generation Unit (TGU) is designed to detect patterns or > sequences within a specific region of the System on Chip (SoC). Once > configured and activated, it monitors sense inputs and can detect a > pre-programmed state or sequence across clock cycles, subsequently > producing a trigger. > > TGU configuration space > offset table > x-------------------------x > | | > | | > | | Step configuration > | | space layout > | coresight management | x-------------x > | registers | |---> | | > | | | | reserve | > | | | | | > |-------------------------| | |-------------| > | | | | priority[3] | > | step[7] |<-- | |-------------| > |-------------------------| | | | priority[2] | > | | | | |-------------| > | ... | |Steps region | | priority[1] | > | | | | |-------------| > |-------------------------| | | | priority[0] | > | |<-- | |-------------| > | step[0] |--------------------> | | > |-------------------------| | condition | > | | | | > | control and status | x-------------x > | space | | | > x-------------------------x |Timer/Counter| > | | > x-------------x > TGU Configuration in Hardware > > The TGU provides a step region for user configuration, similar > to a flow chart. Each step region consists of three register clusters: > > 1.Priority Region: Sets the required signals with priority. > 2.Condition Region: Defines specific requirements (e.g., signal A > reaches three times) and the subsequent action once the requirement is > met. > 3.Timer/Counter (Optional): Provides timing or counting functionality. > > Add a new tgu.yaml file to describe the bindings required to > define the TGU in the device trees. > > Reviewed-by: Rob Herring (Arm) > Signed-off-by: Songwei Chai > --- > .../devicetree/bindings/arm/qcom,tgu.yaml | 92 +++++++++++++++++++ > 1 file changed, 92 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/qcom,tgu.yaml > > diff --git a/Documentation/devicetree/bindings/arm/qcom,tgu.yaml b/Documentation/devicetree/bindings/arm/qcom,tgu.yaml > new file mode 100644 > index 000000000000..5b6a58ebe691 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/qcom,tgu.yaml > @@ -0,0 +1,92 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +# Copyright (c) 2025 Qualcomm Innovation Center, Inc. All rights reserved. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/qcom,tgu.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Trigger Generation Unit - TGU > + > +description: | > + The Trigger Generation Unit (TGU) is a Data Engine which can be utilized > + to sense a plurality of signals and create a trigger into the CTI or > + generate interrupts to processors. The TGU is like the trigger circuit > + of a Logic Analyzer. The corresponding trigger logic can be realized by > + configuring the conditions for each step after sensing the signal. > + Once setup and enabled, it will observe sense inputs and based upon > + the activity of those inputs, even over clock cycles, may detect a > + preprogrammed state/sequence and then produce a trigger or interrupt. > + > + The primary use case of the TGU is to detect patterns or sequences on a > + given set of signals within some region to identify the issue in time > + once there is abnormal behavior in the subsystem. > + > +maintainers: > + - Mao Jinlong > + - Songwei Chai > + > +# Need a custom select here or 'arm,primecell' will match on lots of nodes > +select: > + properties: > + compatible: > + contains: > + enum: > + - qcom,tgu > + required: > + - compatible > + > +properties: > + compatible: > + items: > + - const: qcom,tgu > + - const: arm,primecell > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + items: > + - const: apb_pclk > + > + in-ports: > + $ref: /schemas/graph.yaml#/properties/ports > + additionalProperties: false > + The TGU device is no longer a CoreSight device, so I think the in-ports property is no longer needed. Thanks, Jie > + properties: > + port: > + description: > + The port mechanism here ensures the relationship between TGU and > + TPDM, as TPDM is one of the inputs for TGU. It will allow TGU to > + function as TPDM's helper and enable TGU when the connected > + TPDM is enabled. > + $ref: /schemas/graph.yaml#/properties/port > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + > +additionalProperties: false > + > +examples: > + - | > + tgu@10b0e000 { > + compatible = "qcom,tgu", "arm,primecell"; > + reg = <0x10b0e000 0x1000>; > + > + clocks = <&aoss_qmp>; > + clock-names = "apb_pclk"; > + > + in-ports { > + port { > + tgu_in_tpdm_swao: endpoint{ > + remote-endpoint = <&tpdm_swao_out_tgu>; > + }; > + }; > + }; > + }; > +...