From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757941AbcHCQhj (ORCPT ); Wed, 3 Aug 2016 12:37:39 -0400 Received: from mail-pf0-f176.google.com ([209.85.192.176]:36096 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757899AbcHCQhh (ORCPT ); Wed, 3 Aug 2016 12:37:37 -0400 Subject: Re: [PATCH v0 1/4] i2c: bcm-iproc: Use complete() instead of complete_all() To: Daniel Wagner , Wolfram Sang References: <1470225791-16613-1-git-send-email-wagi@monom.org> <1470225791-16613-2-git-send-email-wagi@monom.org> Cc: Beniamino Galvani , Kamal Dasu , Ray Jui , Tim Kryger , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, Daniel Wagner From: Ray Jui Message-ID: <32341d5e-a3a1-368e-8319-67b95bb7ade8@broadcom.com> Date: Wed, 3 Aug 2016 09:36:10 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:47.0) Gecko/20100101 Thunderbird/47.0 MIME-Version: 1.0 In-Reply-To: <1470225791-16613-2-git-send-email-wagi@monom.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, On 8/3/2016 5:03 AM, Daniel Wagner wrote: > From: Daniel Wagner > > There is only one waiter for the completion, therefore there > is no need to use complete_all(). Let's make that clear by > using complete() instead of complete_all(). > > The usage pattern of the completion is: > > bcm_iproc_i2c_xfer_single_msg() > reinit_completion() > ... > (activate the transfer) > ... > wait_for_completion_timeout() > > Signed-off-by: Daniel Wagner > --- > drivers/i2c/busses/i2c-bcm-iproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c > index 19c8438..95f7cac 100644 > --- a/drivers/i2c/busses/i2c-bcm-iproc.c > +++ b/drivers/i2c/busses/i2c-bcm-iproc.c > @@ -158,7 +158,7 @@ static irqreturn_t bcm_iproc_i2c_isr(int irq, void *data) > > if (status & BIT(IS_M_START_BUSY_SHIFT)) { > iproc_i2c->xfer_is_done = 1; > - complete_all(&iproc_i2c->done); > + complete(&iproc_i2c->done); > } > > writel(status, iproc_i2c->base + IS_OFFSET); > Yes each time there's only one waiter invoked from the main transfer routine 'bcm_iproc_i2c_xfer_single_msg'. This change looks good to me, thanks! Acked-by: Ray Jui