mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Fabian Frederick <fabf@skynet.be>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Joe Perches <joe@perches.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH V3 1/2 linux-next] cpufreq: pxa: replace typedef pxa_freqs_t by structure
Date: Fri, 15 May 2015 02:12:02 +0200	[thread overview]
Message-ID: <3235672.1qyoOA5Ogh@vostro.rjw.lan> (raw)
In-Reply-To: <CAKohpo=tgE95M-DeNub0z-ZBqW3vi_4nMzBtyDXKh13AJP9NbA@mail.gmail.com>

On Friday, May 01, 2015 08:31:19 PM Viresh Kumar wrote:
> On 1 May 2015 at 14:04, Fabian Frederick <fabf@skynet.be> wrote:
> > typedef is not really useful here. Replace it by structure
> > to improve readability. typedef should only be used in some cases.
> > (See Documentation/CodingStyle Chapter 5 for details).
> >
> > Signed-off-by: Fabian Frederick <fabf@skynet.be>
> > ---
> > Compiled but untested.
> >
> > V3: -constify arrays(patch 2) (suggested by Joe Perches)
> >     -fix typo in changelog (thanks to Viresh Kumar)
> > V2: -verbose changelog.
> >
> >  drivers/cpufreq/pxa2xx-cpufreq.c | 20 ++++++++++----------
> >  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> For both patches:
> 
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Both queued up for 4.2, thanks!


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

      reply	other threads:[~2015-05-14 23:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-01  8:34 Fabian Frederick
2015-05-01  8:34 ` [PATCH V3 2/2 linux-next] cpufreq: pxa: make pxa_freqs arrays const Fabian Frederick
2015-05-01 15:01 ` [PATCH V3 1/2 linux-next] cpufreq: pxa: replace typedef pxa_freqs_t by structure Viresh Kumar
2015-05-15  0:12   ` Rafael J. Wysocki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3235672.1qyoOA5Ogh@vostro.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=fabf@skynet.be \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®