From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFD8038333A for ; Thu, 8 Oct 2026 05:55:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791438956; cv=none; b=UwilOR3Xe+GYopNl8rvmZ79WAnhy7l/07poBUhhvcn9bUVZFYMt/yKT0T8aZSec/SJOovqcgtvveVP07Ip0uNQKY7B0nfraJPB2MGHJvItQ5uNryIFE6Q63PMhiRB/OqSY+9mAPC+8gPZGwCStFJ8YCuBXvW845NIRLIr+c8xH8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791438956; c=relaxed/simple; bh=SnxgTjzR1Zqve9Lg5TP3239+WHiQbhWCBAAzxA6DzqE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fGidhCJVP91EmuhsN6QbnA/AHpGpeMTdrWaemio5eKvs7L9fjkYeFQTN3k2hEeZ4F11oca5rGWCnXEPx/lplKgK7/F5wogqkcrItjklvgECXsXA/GgxylH3P2fm+taKD3klwmJkx7J/aLX4+8v7IfgkqUWjGJOo4NnbrLuHWpso= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=blsdWOTV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hTWRifPm; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="blsdWOTV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hTWRifPm" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6984BXVb753833 for ; Thu, 8 Oct 2026 05:55:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= I2pabwNidMfIZQcD09ezoqQZT3EqnKdE0n3SpfgNAFc=; b=blsdWOTV1I7T8Jv4 3Q2/BTrBeKeYuu+ykt6ry8d6TEaBmpXmEspwMo4mbdRaju7QurwFjmWX3SPNB32j Zd8MqZxM76juvvWS2GtwL2JAT6drY/Ov0J9xTFb2DRpFu6twihr+X7pn4AQPTyFF QbIQzw+G9yOP/eMm8shd3Gj8uKUNXPCzsWMQ/G/jaFYb9FuCbVue0FeWYSd7J0DB ltHATrEc+IgW0hxUyqNhtD506X7FWcAGhZYF/5D2pzN+AZ+JJFHLjlAc1sD/Q9LI dgn2xm3bTAPAPWdl3uBeEtZROJWqG5mtVqVgB+ST0JDJMXhNLZkWVO9WuGaQ6rhW DddxVA== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4h5xe399pa-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 08 Oct 2026 05:55:53 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-93e46c120dfso537041185a.1 for ; Wed, 07 Oct 2026 22:55:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1791438953; x=1792043753; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=I2pabwNidMfIZQcD09ezoqQZT3EqnKdE0n3SpfgNAFc=; b=hTWRifPmAUQ1soJF4STEfgiPq49q4NjKJbX0/J/dM4sB1fTa0egGQxeFvq9oLhveQQ 6p/QsvvhzsL4JBqv/hmva/hNL6SdzwGVrzGJA2lrxZGDT/ZiO1WZJQugX5HgXzs90589 VB1NlZmWnh9dk0b9UIUpqrpmJtEXx3b9wWOTkWqrOdN0tgTaETT25Vjqm7MblD/a/o/X Oqp6UURgssmNtOKXv5CZ8heOfVE9LGfzu+Ae7w/R/vAj8iQRN31osvIvtUPl0eo2cQ7Y 5qq4RIytPnBfAVU+d19qIorQ1cv90ax0oXpRTQp6ik8cz4uF3V43pRb6dej0al0czeF+ cQTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791438953; x=1792043753; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=I2pabwNidMfIZQcD09ezoqQZT3EqnKdE0n3SpfgNAFc=; b=kBXDfiKs26cuwEvNGd85qfgcqCMdj+8zN1HI3ZuyP37ck2pzQdGsTtZcHmGbSmq9cF rhfuVG5VPg1aZp77MI+1iAmxoH9Lfxza5kxIuEAQJjEb++fE+My6iwn/KxDWr2AXxAHT 3ed3OlL0UicQvKzi8YoRULpqsemveVEFFJxIu7o28HYO9CBN2aeZHMyGEQ6+e9HVR2VO KbJjFv8/Y+BfO3IvZaF/skFmipk5EnYytOqGqkMfa/oEtIx0opTc2ql9xK128h3+UmZ2 +1xJvIZYknBxp81RK6Dtr2OOXwVtu0AHGOgIIm9mRprEVdJZOQNTFD93FjU3yDuRtZUA BsZA== X-Forwarded-Encrypted: i=1; AKwUvByY5RM3Gp6MnM5tpA/CSRCYhkHrAi/+SdrVUq9vHn76DLcNnaP+snNFeadaESDSrRYUheFTfOJdaU6z3HM=@vger.kernel.org X-Gm-Message-State: AFuF++lPJk7MZ2SgwDLtAKd+GC65FhEswdQDbWHDNDAL1Neo9Uu38bvr dS46RjMVjP1AbbDJedF4Oouf988RxpejuFtkkDgBDj33WQ4mWqAD0KGNWqaD0K2BIYnrvrAt+z/ 3LUn2fa4SGYM13R5qVgwkZwao9qr8F7dNPFqpMfj7BC+nSP9E3BUeAkKkTunTt3NQfvk= X-Gm-Gg: AYBFou1zolzaMe4BMT7yj+h+C8r7jzIQI+qt07eZAIWQPVKD4SmZNSWWl+i3f7r96jy PIesEu0sVAPnEok+5uK0UQZlbLyJkZH/DIGGyWRxtoOBvEUlRkOYr+LtJbd4hRIIpQe319hdDVh frdjaxymYQSnM4dI/QsMRqSpWLPlOd+jzJ0ocTpjnJwLsRyjip3hElWvk4a1CQtnSn3o+llPdgV onh+VIgmX02DD6pyaTb0PwK7MUDEhQF464ZvFApaivrq7lBn3djTw5d61JMLKhKXlUCLG4qmdIG c4y7Yic0SqdlhgugAz2cnknhL63QHTQKGSJXC/cl6Jr+hPcjFzQNvruw8rZGrQWKELwn/o769X1 0K55asB4fMHgwFde+5UvZe/yBHqLWnIbWE/zsQ6E= X-Received: by 2002:a05:620a:8082:b0:93e:9808:b9ec with SMTP id af79cd13be357-93e9b88401dmr908483985a.81.1791438953115; Wed, 07 Oct 2026 22:55:53 -0700 (PDT) X-Received: by 2002:a05:620a:8082:b0:93e:9808:b9ec with SMTP id af79cd13be357-93e9b88401dmr908479285a.81.1791438952627; Wed, 07 Oct 2026 22:55:52 -0700 (PDT) Received: from [192.168.1.31] ([85.196.172.179]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a1843b5f28sm49261805e9.12.2026.10.07.22.55.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Oct 2026 22:55:51 -0700 (PDT) Message-ID: <3235a3c9-4519-4af4-9ea4-8e41f15fa341@oss.qualcomm.com> Date: Thu, 8 Oct 2026 08:55:49 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 26/74] media: qcom: camss: vfe: Call vfe_subdev_init after not before significant enumeration To: Bryan O'Donoghue , Bryan O'Donoghue , Vladimir Zapolskiy , Loic Poulain , Mauro Carvalho Chehab , Jacopo Mondi , Daniel Scally , Keke Li , Richard Acayan , Hans Verkuil , Gjorgji Rosikopulos , Radoslav Tsvetkov , Robert Foss , Milen Mitkov Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20261005-linux-mainline-7-2-sm8650-hdk-rfc-0-v1-0-ed985aefd611@kernel.org> <20261005-linux-mainline-7-2-sm8650-hdk-rfc-0-v1-26-ed985aefd611@kernel.org> Content-Language: en-US From: "Gjorgji Rosikopulos (Consultant)" In-Reply-To: <20261005-linux-mainline-7-2-sm8650-hdk-rfc-0-v1-26-ed985aefd611@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: gYLaElBugeEmk1HWxtzovJyEs1K24j2F X-Authority-Analysis: v=2.4 cv=QOz91QLL c=1 sm=1 tr=0 ts=6ac73069 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=Q/e3f29T3Hw2hnAEzBPF7w==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=VwQbUJbxAAAA:8 a=lzbwJ7qkMF73zFqNUiwA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDA4MDAyMyBTYWx0ZWRfX+qJ6ez5memFD U/VG8Gmp1kJEwwJk3n1C/yERMNPooUCqMP6yziaJKilS98cGB0tsYZZGcoXZfLqPJp1S5Rf6GMx Ue0KEPQCADf/ONmqXbpOUu6bmKYvcLk= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDA4MDAyMyBTYWx0ZWRfXwlbHppn6RvOf W2QwE8Pq70ne2XppQbW50DxqvyIo9xuRjRadKZUGebHye/YT9d8Nj7zt7tiHHOmmAMnQWDT9Hn0 hWpm8iGB4KvyN7H3bfLtkaj7XLg7TZq/7S0hztwsVF6RAME7/ONt7dQalV8OXwTYy6/0fzftn16 /alaWIMRXN4Rh+ydgRu3gYLLOOnrhcEyp6umGIEuaelkxIpAyEtRT8NDoA62E2UKvFXYqVi47Kx T6wtraJlxEO3yYBFfZGnsOC/Psx+et7tOSeIkz/hBKwC0tW22R4wgsmQb9/ecCErJk6LPJroIva 637CoAMA3Hr0cid0LwqGjN8m5N8JheO7vQ8a+5HGdrk5C5aIJ8b+BFsvWZqAmYiPASbO2wKmrh/ DDxFkMcNdr59ka3PFnub+M25htXfHJAF5OelsPw7GDVaOnWiE4yN9yDfM82OOKtKsNWdfrDAlYP 3krh3dSJa+MSHh4O6gQ== X-Proofpoint-ORIG-GUID: gYLaElBugeEmk1HWxtzovJyEs1K24j2F X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-08_02,2026-10-06_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 spamscore=0 phishscore=0 impostorscore=0 adultscore=0 bulkscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610020000 definitions=main-2610080023 Please update commit message what this fixes and why is needed? On 10/5/2026 8:13 PM, Bryan O'Donoghue wrote: > Signed-off-by: Bryan O'Donoghue > --- > drivers/media/platform/qcom/camss/camss-vfe.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c > index 8899f02ceba02..667cda379be44 100644 > --- a/drivers/media/platform/qcom/camss/camss-vfe.c > +++ b/drivers/media/platform/qcom/camss/camss-vfe.c > @@ -1930,7 +1930,6 @@ int msm_vfe_subdev_init(struct camss *camss, struct vfe_device *vfe, > return -EINVAL; > > vfe->res = &res->vfe; > - vfe->res->hw_ops->subdev_init(dev, vfe); > > /* Power domain */ > > @@ -2067,6 +2066,8 @@ int msm_vfe_subdev_init(struct camss *camss, struct vfe_device *vfe, > } > } > > + vfe->res->hw_ops->subdev_init(dev, vfe); > + > init_completion(&vfe->reset_complete); > init_completion(&vfe->halt_complete); > >