RE: [PATCH v2] ufs: core: Initialize a value of an attribute as returned by uic cmd

["Wonkon Kim" <wkon.kim@samsung.com>]

> On 10/13/25 9:40 PM, Wonkon Kim wrote:
> > diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> > index 9a43102b2b21..6858f005cc8b 100644
> > --- a/drivers/ufs/core/ufshcd.c
> > +++ b/drivers/ufs/core/ufshcd.c
> > @@ -4273,8 +4273,8 @@ int ufshcd_dme_get_attr(struct ufs_hba *hba, u32
> attr_sel,
> >   			get, UIC_GET_ATTR_ID(attr_sel),
> >   			UFS_UIC_COMMAND_RETRIES - retries);
> >
> > -	if (mib_val && !ret)
> > -		*mib_val = uic_cmd.argument3;
> > +	if (mib_val)
> > +		*mib_val = ret == 0 ? uic_cmd.argument3 : 0;
> >
> >   	if (peer && (hba->quirks & UFSHCD_QUIRK_DME_PEER_ACCESS_AUTO_MODE)
> >   	    && pwr_mode_change)
> > @@ -4990,7 +4990,7 @@ EXPORT_SYMBOL_GPL(ufshcd_hba_enable);
> >
> >   static int ufshcd_disable_tx_lcc(struct ufs_hba *hba, bool peer)
> >   {
> > -	int tx_lanes = 0, i, err = 0;
> > +	int tx_lanes, i, err = 0;
> >
> >   	if (!peer)
> >   		ufshcd_dme_get(hba, UIC_ARG_MIB(PA_CONNECTEDTXDATALANES),
> 
> Please split this patch into two patches: a first patch with the
> ufshcd_dme_get_attr() change and a second patch with the
> ufshcd_disable_tx_lcc() change. Please also add a Fixes: tag to the first
> patch. That will cause the first patch to be included automatically in
> stable kernels and also in Android kernels.
> 
> Thanks,
> 
> Bart.


Sure. I'll split and update it.

Thanks,
Wonkon Kim.