From: Valdis.Kletnieks@vt.edu
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
devel@driverdev.osuosl.org, Gulsah Kose <gulsah.1004@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jarod Wilson <jarod@wilsonet.com>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
linux-kernel@vger.kernel.org,
Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>,
Martin Kaiser <martin@kaiser.cx>,
linux-media@vger.kernel.org,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Subject: Re: [PATCH] staging: media: lirc: lirc_zilog: Fix for possible null pointer dereference
Date: Fri, 30 Jan 2015 08:09:24 -0500 [thread overview]
Message-ID: <32395.1422623364@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Fri, 30 Jan 2015 16:00:02 +0300." <20150130130001.GZ6456@mwanda>
[-- Attachment #1: Type: text/plain, Size: 647 bytes --]
On Fri, 30 Jan 2015 16:00:02 +0300, Dan Carpenter said:
> > > - if (ir == NULL) {
> > > - dev_err(ir->l.dev, "close: no private_data attached to the file
!\n");
> >
> > Yes, the dev_err() call is an obvious thinko.
> >
> > However, I'm not sure whether removing it entirely is right either. If
> > there *should* be a struct IR * passed there, maybe some other printk()
> > should be issued, or even a WARN_ON(!ir), or something?
>
> We set filep->private_data to non-NULL in open() so I don't think it can
> be NULL here.
Then probably the *right* fix is to remove the *entire* if statement, as
we can't end up doing the 'return -ENODEV'....
[-- Attachment #2: Type: application/pgp-signature, Size: 848 bytes --]
next prev parent reply other threads:[~2015-01-30 13:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 18:48 Rickard Strandqvist
2015-01-29 22:12 ` Valdis.Kletnieks
2015-01-30 13:00 ` Dan Carpenter
2015-01-30 13:09 ` Valdis.Kletnieks [this message]
2015-01-30 17:06 ` Rickard Strandqvist
2015-01-31 0:01 ` Andy Walls
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32395.1422623364@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=gulsah.1004@gmail.com \
--cc=jarod@wilsonet.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mahfouz.saif.elyazal@gmail.com \
--cc=martin@kaiser.cx \
--cc=mchehab@osg.samsung.com \
--cc=rickard_strandqvist@spectrumdigital.se \
--cc=tuomas.tynkkynen@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®