From: Jens Axboe <axboe@kernel.dk>
To: "Theodore Y. Ts'o" <tytso@mit.edu>,
jannh@google.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: random: GFP_KERNEL from irq context
Date: Thu, 26 Apr 2018 22:11:53 -0600 [thread overview]
Message-ID: <323b0878-1352-90ab-6ada-b686750fd635@kernel.dk> (raw)
In-Reply-To: <20180426210357.GF5965@thunk.org>
On 4/26/18 3:03 PM, Theodore Y. Ts'o wrote:
> On Thu, Apr 26, 2018 at 10:28:13AM -0600, Jens Axboe wrote:
>> during boot. We end up doing the numa_crng_init() from interrupt context, which
>> makes things unhappy since you do GFP_KERNEL | __GFP_NOFAIL allocations from
>> there.
>
> I've already sent a pull request to Linux to fix this; see the
> random.git tree.
>
> Apologies for not noticing this earlier. My test environment had
> virtio-rng enabled by default, and while I did test the CONFIG_NUMA
> case, the call to add randomness doesn't happen from interrupt context
> with virtio-rng so I missed it in my testing.
OK, all good, just wanted to ensure it was known.
--
Jens Axboe
prev parent reply other threads:[~2018-04-27 4:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 16:28 Jens Axboe
2018-04-26 21:03 ` Theodore Y. Ts'o
2018-04-27 4:11 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=323b0878-1352-90ab-6ada-b686750fd635@kernel.dk \
--to=axboe@kernel.dk \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome