From: Krzysztof Kozlowski <krzk@kernel.org>
To: Qiang Yu <qiang.yu@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Taniya Das <taniya.das@oss.qualcomm.com>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: clock: qcom: Move x1e80100 TCSR to own binding
Date: Thu, 13 Aug 2026 09:38:36 +0200 [thread overview]
Message-ID: <323c7e9b-0ee4-42e8-bd15-b64c61723130@kernel.org> (raw)
In-Reply-To: <an1qXeZoTdzrXqVx@hu-qianyu-lv.qualcomm.com>
On 13/08/2026 08:55, Qiang Yu wrote:
>>> +required:
>>> + - compatible
>>> + - clocks
>>> + - '#clock-cells'
>>> + - '#reset-cells'
>>
>> This is unexplained ABI change. When you are asked, you need to address
>> feedback from LLM, not blindly implement it without checking its
>> validity.
>>
> After adding these two properties to the required list, I ran a dtb
> check and saw no related errors or warnings. But I overlooked one
> thing: my dtb check was against the current tree only. This change
> could make dtb checks fail for historical TCSR DT nodes that did not
> have these two properties. So to be safe, I don't think they should be
> added to the required list.
Did you change the driver code to fail when DTS is not having these?
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-08-13 7:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 7:27 [PATCH v3 0/3] clk: qcom: Migrate x1e80100 TCSR to clk_ref helper Qiang Yu
2026-08-12 7:27 ` [PATCH v3 1/3] dt-bindings: clock: qcom: Move x1e80100 TCSR to own binding Qiang Yu
2026-08-12 11:20 ` Krzysztof Kozlowski
2026-08-13 6:55 ` Qiang Yu
2026-08-13 7:38 ` Krzysztof Kozlowski [this message]
2026-08-14 3:55 ` Qiang Yu
2026-08-12 7:27 ` [PATCH v3 2/3] clk: qcom: tcsrcc-x1e80100: Migrate to clk_ref helper Qiang Yu
2026-08-12 10:24 ` Abel Vesa
2026-08-12 7:27 ` [PATCH v3 3/3] arm64: dts: qcom: hamoa/purwa: Add QREF regulator supplies Qiang Yu
2026-08-12 10:25 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=323c7e9b-0ee4-42e8-bd15-b64c61723130@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=qiang.yu@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=taniya.das@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®