From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 018D8310640 for ; Mon, 29 Dec 2025 13:23:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767014636; cv=none; b=lgl1uu5shBN7QCXgW8y2M7Ll0StP6Lxh6PTl2k3P4uAfHQqmQEmMFZHT3gpIa2UIumTnbhREEKAP16CdCundeegxTxYmC57rd8IbPqV8BMQJRQgfzP2NY9+0umkIfKHADFnTB19e1FmpjKQTeIYdqlZxBRp7IfS5k5Lu6c783Ug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767014636; c=relaxed/simple; bh=Uk1RfjVJyKQ+tgH4YRtutVqI3YFZB+T0oNkbYL96PII=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=m+64r/nBI6hjtSOsVwVrd9iJ3Wu1xlnAkqNYkN4EKyCVKvclZyoom+UbcXQUuhSjfNxGOf7PpQnMWb2NTRVMrTcy0N2v570VxmpRSo7lQ5ivLOPmXxHcqO0x7Rn7xInGIGxw4jvFg2IA+F5piF1lObB5U2Vw3hkl9lBcxw4NG88= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Do86hzAX; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Do86hzAX" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-5942b58ac81so7472147e87.2 for ; Mon, 29 Dec 2025 05:23:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767014633; x=1767619433; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JYz2s5u+HJFZpaoUYiP7p4BhV+8iFu1MO193Mzs7/UQ=; b=Do86hzAX5ViREeXoHBbfWoTLLFCVfYXJNu0Xu8xY6M3JXpZuP61lRuRcUXd4SV99Px 3DTPBbYMGLvm4XamCxcAl7gB/Wmv7JpXlSkYNmI1Cl+TfvOpGqlPqIGEEGnEJdbNpr1c //lv+eFyoa47kL/iNEcOxIpSUkpkXWMikc4RdxVpTmPSN1DwB/B12dL13+C7fXdEnGsB 5BNVqiHel0RKYiiEOPrJ267fwgamk205HKMI0c7jLboZkR4Ei3H+FavhZkxcnMeGLS1y hXNHVQ6LFANq5qXMJleZyJVv6m/8qh4Iqce76YfqtzBkJHbxt1OZ9u6EtRdOo6d3StH/ sOHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767014633; x=1767619433; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JYz2s5u+HJFZpaoUYiP7p4BhV+8iFu1MO193Mzs7/UQ=; b=XUno3HjZaK52LFJqlLZbF6T6hKCgxAPy3jxU9czToNpWm7eG/NMd5MDsewAFkdtqP5 NEx5JsEZb0LF3nQ5+UijBTCjtz7/rZf2PSh5/crG+m/6Uguam2LJmdmk1h7M5h+7Xhsu /HbwghKGUV8Eg+EONmj3x5QnUX79YjrBwBMjTm5WGNefK1MsSQtbxByjdo7Owu6FWsIw n7qIfKHHW/1b/lmvCMkOWxTDcvV0GVxWP/BJdBPgklh0kqbMKzKDtK1BG32o+q3+t3Jw 2Sad9fsDBuaNqo82nxcPRYovyESy/9X4YaeOoq8DxL0MWS+q0Jz+IIxtGiYyaWTpUxkU /XCg== X-Forwarded-Encrypted: i=1; AJvYcCW5lRxLQ00ffYprN1LJfbl2mOD/l+NvXe8N7vgHdv/wgtX4gL5TdRAYWTyfBlnnKAa5ZdrWUiY4yAAn1bY=@vger.kernel.org X-Gm-Message-State: AOJu0Yzkmh/r3Hr7FSLCjdUAvUvxIVenWvBJV/SWtz42tnhzsxYal5KU 5H5utosHRqjI920R6l2WNtTs8JGIr/UDtTOrZAO4vxi+Ql+dPF5xLU0C X-Gm-Gg: AY/fxX6oYJ9nXUJxTORrUH1/O7sBGppi5qJLLhSYXas6m5PgJyl0Zokj/VlNwjOG+Li ElhEQErZt+BPJtZqtqd6XAg+vMVPLN3sLpF2vBh815ILb42MufB+aC+WDEUYDXAs+e9ZCY0ETD8 gi7oGAB3GYH0TcSYPjZKecv5rDhR8Yv86uyc3QjpGk/ZwL34o0B6Blmou5raBLcfEmrKBeyBBzh DQ6DF0mMqGQo540haLASZuz9WKhEFF6aHduBH/Lgvnvf2bWJTwqMNN/ck/Lh5b9RD3WN66sKrY9 KDFy3hG+0hmzyZL83ib03fzg41AxPafB32u9Nt8ajRhFc/D4xvshujhLZ9qJadgQRHfQtWYjhdD Bf9YzDFMng28GDcwHuziry1EtcsXeptHO342LFr4UD+COdMOPFPdRS46ku50bIhPJyTF7MS3LIg G/Ym/KNrzSO3ZIXTurhlAuNKF5sdp0+LoRub8662esZ/WEUgID5StpGeBUnRLYkqUMJ+oI X-Google-Smtp-Source: AGHT+IFa0k3Cw2xv5tgyHJPZwAhfk3MPquGhpdE7gPKATpe5MLbPoMdSC+u2Dbj6A6onRGmI43iZrA== X-Received: by 2002:a05:6512:31ce:b0:592:f27d:75d4 with SMTP id 2adb3069b0e04-59a17df1dfcmr10799023e87.45.1767014632794; Mon, 29 Dec 2025 05:23:52 -0800 (PST) Received: from ?IPV6:2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703? ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59a18628040sm9192868e87.88.2025.12.29.05.23.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Dec 2025 05:23:52 -0800 (PST) Message-ID: <323d7c6d-3082-4775-b5eb-4bcb3ee9b1ea@gmail.com> Date: Mon, 29 Dec 2025 15:23:50 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: add Texas Instruments TLA 2528 To: Andy Shevchenko Cc: David Lechner , Maxime Chevallier , Jonathan Cameron , nuno.sa@analog.com, Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marcelo Schmitt , Antoniu Miclaus , Angelo Dureghello , Tobias Sperling , Eason Yang , Marilene Andrade Garcia , Cosmin Tanislav , duje@dujemihanovic.xyz, herve.codina@bootlin.com, Rodolfo Giometti , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com References: <20251223155534.220504-1-maxime.chevallier@bootlin.com> <20251223155534.220504-2-maxime.chevallier@bootlin.com> <56c03c7f-1e5b-4586-beb0-47a1fa3bc86c@baylibre.com> Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 29/12/2025 11:31, Andy Shevchenko wrote: > On Mon, Dec 29, 2025 at 10:04 AM Matti Vaittinen > wrote: >> On 23/12/2025 20:26, David Lechner wrote: >>> On 12/23/25 9:55 AM, Maxime Chevallier wrote: > > ... > >>> It looks like inputs can also be used as GPIOs, so >>> >>> gpio-controller: true >>> #gpio-cells: >>> const: 2 >>> >>> would be appropriate (it doesn't matter if the driver doesn't >>> implement it, we know what the correct bindings are). >>> >>>> + >>>> + "#io-channel-cells": >>>> + const: 1 >> >> I didn't check the data-sheet, but if the pins can be set to be GPIOs or >> ADC inputs, then I would require channels to be specified. It's only 8 >> channels, so always listing channels that are present shouldn't be that >> big of a problem - and it should avoid one to add extra properties to >> denote channels used for GPIO if GPIOs need to be supported. >> >> Well, I am not insisting this, there are folks that know this stuff >> better than I :) > > Why would we need an extra property for that? GPIO controller has a > property for valid_mask, should be enough to handle this case, no? > Ah. You're right. The "valid_mask" should be perfectly usable. I might still require the channel information to make it explicit - but as I said, I leave this for others to decide :) Yours, -- Matti --- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~