From: Randy Dunlap <rdunlap@infradead.org>
To: paulmck@kernel.org
Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>,
rcu@vger.kernel.org, Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Joel Fernandes <joel@joelfernandes.org>,
linux-kernel@vger.kernel.org
Subject: Re: RCU: undefined reference to irq_work_queue
Date: Thu, 17 Mar 2022 13:31:00 -0700 [thread overview]
Message-ID: <323e29c6-36ce-4aa6-22f7-7b98c1425d10@infradead.org> (raw)
In-Reply-To: <20220317202925.GS4285@paulmck-ThinkPad-P17-Gen-1>
On 3/17/22 13:29, Paul E. McKenney wrote:
> On Thu, Mar 17, 2022 at 01:26:45PM -0700, Randy Dunlap wrote:
>>
>>
>> On 3/17/22 10:36, Paul E. McKenney wrote:
>>> On Thu, Mar 17, 2022 at 04:45:11PM +0000, Hyeonggon Yoo wrote:
>>>> On Thu, Mar 17, 2022 at 09:20:33AM -0700, Paul E. McKenney wrote:
>>>>> On Thu, Mar 17, 2022 at 03:24:42PM +0000, Hyeonggon Yoo wrote:
>>>>>> On Thu, Mar 17, 2022 at 07:00:00AM -0700, Paul E. McKenney wrote:
>>>>>>> On Thu, Mar 17, 2022 at 11:32:53AM +0000, Hyeonggon Yoo wrote:
>>>>>>>> Hello RCU folks,
>>>>>>>>
>>
>>> ------------------------------------------------------------------------
>>>
>>> diff --git a/arch/Kconfig b/arch/Kconfig
>>> index 678a80713b21..66c5b5543511 100644
>>> --- a/arch/Kconfig
>>> +++ b/arch/Kconfig
>>> @@ -38,6 +38,7 @@ config KPROBES
>>> depends on MODULES
>>> depends on HAVE_KPROBES
>>> select KALLSYMS
>>> + select TASKS_RCU if PREEMPTION
>>> help
>>> Kprobes allows you to trap at almost any kernel address and
>>> execute a callback function. register_kprobe() establishes
>>> diff --git a/kernel/rcu/Kconfig b/kernel/rcu/Kconfig
>>> index f559870fbf8b..4f665ae0cf55 100644
>>> --- a/kernel/rcu/Kconfig
>>> +++ b/kernel/rcu/Kconfig
>>> @@ -78,7 +78,8 @@ config TASKS_RCU_GENERIC
>>> task-based RCU implementations. Not for manual selection.
>>>
>>> config TASKS_RCU
>>> - def_bool PREEMPTION
>>> + def_bool 0
>>
>> preferably
>> def_bool n
>>
>> but the 0 probably works... :)
>
> In a later commit, it ends up like this:
>
> config TASKS_TRACE_RCU
> bool "Enable Tasks Trace RCU"
> depends on RCU_EXPERT
> default n
> select IRQ_WORK
> help
> This option enables a task-based RCU implementation that uses
> explicit rcu_read_lock_trace() read-side markers, and allows
> these readers to appear in the idle loop as well as on the CPU
> hotplug code paths. It can force IPIs on online CPUs, including
> idle ones, so use with caution.
>
> The reason being to allow people to use rcutorture without having
> to have TASKS_TRACE_RCU enabled.
>
> So you got your wish! I think... ;-)
>
> Thanx, Paul
Yeah, thanks.
>>> + select IRQ_WORK
>>> help
>>> This option enables a task-based RCU implementation that uses
>>> only voluntary context switch (not preemption!), idle, and
>>> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
>>> index 752ed89a293b..a7aaf150b704 100644
>>> --- a/kernel/trace/Kconfig
>>> +++ b/kernel/trace/Kconfig
>>> @@ -127,6 +127,7 @@ config TRACING
>>> select BINARY_PRINTF
>>> select EVENT_TRACING
>>> select TRACE_CLOCK
>>> + select TASKS_RCU if PREEMPTION
>>>
>>> config GENERIC_TRACER
>>> bool
>>
>> --
>> ~Randy
--
~Randy
next prev parent reply other threads:[~2022-03-17 20:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 11:32 Hyeonggon Yoo
2022-03-17 14:00 ` Paul E. McKenney
2022-03-17 15:24 ` Hyeonggon Yoo
2022-03-17 16:20 ` Paul E. McKenney
2022-03-17 16:45 ` Hyeonggon Yoo
2022-03-17 17:36 ` Paul E. McKenney
2022-03-17 20:26 ` Randy Dunlap
2022-03-17 20:29 ` Paul E. McKenney
2022-03-17 20:31 ` Randy Dunlap [this message]
2022-03-17 20:41 ` Zhouyi Zhou
2022-03-17 20:53 ` Paul E. McKenney
2022-03-18 14:42 ` Hyeonggon Yoo
2022-03-17 15:22 ` Zhouyi Zhou
2022-03-17 15:54 ` Hyeonggon Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=323e29c6-36ce-4aa6-22f7-7b98c1425d10@infradead.org \
--to=rdunlap@infradead.org \
--cc=42.hyeyoo@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®