From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754550AbdEEP1Q (ORCPT ); Fri, 5 May 2017 11:27:16 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:48291 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753563AbdEEP1M (ORCPT ); Fri, 5 May 2017 11:27:12 -0400 X-AuditID: b6c32a39-f790c6d000000e85-29-590c99cdae22 From: Bartlomiej Zolnierkiewicz To: Arnd Bergmann Cc: linux-parisc@vger.kernel.org, Helge Deller , jejb@parisc-linux.org, Alexander Beregalov , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fbdev: sti: don't select CONFIG_VT Date: Fri, 05 May 2017 17:27:06 +0200 Message-id: <3242330.XRvUNh2arJ@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170428195151.57706-1-arnd@arndb.de> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprAKsWRmVeSWpSXmKPExsWy7bCmru7ZmTyRBnsXsFvM2j6B3eLvpGPs Fvc/3Wa0uL9uFavFib4PrBaXd81hs3h06gKTA7vH71+TGD12zrrL7vHhY5zHhUW/WT0+b5IL YI3isklJzcksSy3St0vgymi98oGpYJ1yxbTPT5gaGE/JdTFyckgImEhMO3OKCcIWk7hwbz1b FyMXh5DADkaJs0/+sEA4nxklfs9rYYfpOL/zKzNc1ak/l6BavjJKfJm5jgWkik3ASmJi+ypG EFtEQFFi6otnYB3MAgcZJS53vAQbJSxgLtF79QeYzSKgKtF64DpQMwcHr4CmxMn74iBhUQEv iS372plAwpwCxhLbXmeChHkFBCV+TL4HtopZQF5i3/6prBC2jsTZY+sYIQ6dxy7R9VMLpFVC QFZi0wFmiLCLxLnvb9kgbGGJV8e3QP0lJdH48iE0JKYzSmz/LQFysYTAZkaJVbsnQBVZSxw+ fhFqF5/Eu689rBDzeSU62oQgSjwkTi2aCjXfUaLvzWcwW0igjVGi+XLYBEb5WUg+mIXkg1lI PljAyLyKUSy1oDg3PbXYsMBUrzgxt7g0L10vOT93EyM4nWhZ7mA8ds7nEKMAB6MSD6+HC3ek EGtiWXFl7iFGCQ5mJRHemBk8kUK8KYmVValF+fFFpTmpxYcYpTlYlMR5RddfixASSE8sSc1O TS1ILYLJMnFwSjUwyizMeSjemphQrL+i/s8kudkRPq8Ftvzns3ihX1t672l/1N/5590/Ghrw Lzy2+eXtmLO/UljCNFRj0m0atXMOZMT0ZZ0WXR7Q0+rCw7H9koT4l8Ods2cukHij6e/y8Nn9 lOZ9vjxKfopbcue+DjFhWPVC4deiNMVdR//oP12/uDNg49bAi1p3lViKMxINtZiLihMBe+Vu IiMDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGIsWRmVeSWpSXmKPExsVy+t9jAd0zM3kiDW5ssLCYtX0Cu8XfScfY Le5/us1ocX/dKlaLE30fWC0u75rDZvHo1AUmB3aP378mMXrsnHWX3ePDxziPC4t+s3p83iQX wBrlZpORmpiSWqSQmpecn5KZl26rFBripmuhpJCXmJtqqxSh6xsSpKRQlphTCuQZGaABB+cA 92AlfbsEt4zWKx+YCtYpV0z7/ISpgfGUXBcjJ4eEgInE+Z1fmSFsMYkL99azdTFycQgJbGOU eDbxPhOE85VR4u/EhewgVWwCVhIT21cxgtgiAooSU188YwYpYhY4yCixYdZKNpCEsIC5RO/V H2ANLAKqEq0HrrN0MXJw8ApoSpy8Lw4SFhXwktiyr50JJMwpYCyx7XUmxK4ORomX+5aCXcQr ICjxY/I9FhCbWUBeYt/+qawQtpbE+p3HmSYwCsxCUjYLSdksJGULGJlXMXKlFhTnpucWGxUY bmIExtG2w1r+Oxh/nI0+xCjAwajEw8vRzBMpxJpYVlyZe4hRgoNZSYQ3ZgZQiDclsbIqtSg/ vqg0J7X4EKMp0EcTmaVEk/OBMZ5XEm9oYmlkYmBmZmhkYGymJM47IfBLhJBAemJJanZqakFq EUwfEwenVANjMnvvjFgen4h3h91NvRlKnf9cWP/l/o3uXTcall+2ttzzmFXWte509ourNVwi ZtIzTJa0zz3MHe77ahPTm7O67btUvZmvV22qbf90XnO/beTZXonZrqbfMtxlF1Q0vT730L48 vVw2tMIgcvlyw9pDDzWXGjHqlDGe+G34zfHnswmLZ6RcM2xVYinOSDTUYi4qTgQAO/6KN7kC AAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170505152708epcas1p1b20549a0e87b1fd13c414737081f3cdf X-Msg-Generator: CA X-Sender-IP: 182.195.42.79 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-CMS-RootMailID: 20170428195120epcas2p2792c14bbbd4cf86be1b84c7f3d0f2040 X-RootMTR: 20170428195120epcas2p2792c14bbbd4cf86be1b84c7f3d0f2040 References: <20170428195151.57706-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, April 28, 2017 09:51:25 PM Arnd Bergmann wrote: > While working on another build error, I ran into several variations of > this dependency loop: > > subsection "Kconfig recursive dependency limitations" > drivers/input/Kconfig:8: symbol INPUT is selected by VT > For a resolution refer to Documentation/kbuild/kconfig-language.txt > subsection "Kconfig recursive dependency limitations" > drivers/tty/Kconfig:12: symbol VT is selected by FB_STI > For a resolution refer to Documentation/kbuild/kconfig-language.txt > subsection "Kconfig recursive dependency limitations" > drivers/video/fbdev/Kconfig:677: symbol FB_STI depends on FB > For a resolution refer to Documentation/kbuild/kconfig-language.txt > subsection "Kconfig recursive dependency limitations" > drivers/video/fbdev/Kconfig:5: symbol FB is selected by DRM_KMS_FB_HELPER > For a resolution refer to Documentation/kbuild/kconfig-language.txt > subsection "Kconfig recursive dependency limitations" > drivers/gpu/drm/Kconfig:72: symbol DRM_KMS_FB_HELPER is selected by DRM_KMS_CMA_HELPER > For a resolution refer to Documentation/kbuild/kconfig-language.txt > subsection "Kconfig recursive dependency limitations" > drivers/gpu/drm/Kconfig:137: symbol DRM_KMS_CMA_HELPER is selected by DRM_HDLCD > For a resolution refer to Documentation/kbuild/kconfig-language.txt > subsection "Kconfig recursive dependency limitations" > drivers/gpu/drm/arm/Kconfig:6: symbol DRM_HDLCD depends on OF > For a resolution refer to Documentation/kbuild/kconfig-language.txt > subsection "Kconfig recursive dependency limitations" > drivers/of/Kconfig:4: symbol OF is selected by X86_INTEL_CE > For a resolution refer to Documentation/kbuild/kconfig-language.txt > subsection "Kconfig recursive dependency limitations" > arch/x86/Kconfig:523: symbol X86_INTEL_CE depends on X86_IO_APIC > For a resolution refer to Documentation/kbuild/kconfig-language.txt > subsection "Kconfig recursive dependency limitations" > arch/x86/Kconfig:1011: symbol X86_IO_APIC depends on X86_LOCAL_APIC > For a resolution refer to Documentation/kbuild/kconfig-language.txt > subsection "Kconfig recursive dependency limitations" > arch/x86/Kconfig:1005: symbol X86_LOCAL_APIC depends on X86_UP_APIC > For a resolution refer to Documentation/kbuild/kconfig-language.txt > subsection "Kconfig recursive dependency limitations" > arch/x86/Kconfig:980: symbol X86_UP_APIC depends on PCI_MSI > For a resolution refer to Documentation/kbuild/kconfig-language.txt > subsection "Kconfig recursive dependency limitations" > drivers/pci/Kconfig:11: symbol PCI_MSI is selected by AMD_IOMMU > For a resolution refer to Documentation/kbuild/kconfig-language.txt > subsection "Kconfig recursive dependency limitations" > drivers/iommu/Kconfig:106: symbol AMD_IOMMU depends on IOMMU_SUPPORT > For a resolution refer to Documentation/kbuild/kconfig-language.txt > subsection "Kconfig recursive dependency limitations" > drivers/iommu/Kconfig:5: symbol IOMMU_SUPPORT is selected by DRM_ETNAVIV > For a resolution refer to Documentation/kbuild/kconfig-language.txt > subsection "Kconfig recursive dependency limitations" > drivers/gpu/drm/etnaviv/Kconfig:2: symbol DRM_ETNAVIV depends on THERMAL > For a resolution refer to Documentation/kbuild/kconfig-language.txt > subsection "Kconfig recursive dependency limitations" > drivers/thermal/Kconfig:5: symbol THERMAL is selected by ACPI_VIDEO > For a resolution refer to Documentation/kbuild/kconfig-language.txt > subsection "Kconfig recursive dependency limitations" > drivers/acpi/Kconfig:183: symbol ACPI_VIDEO is selected by INPUT > > This doesn't currently show up as I fixed the 'THERMAL' part of it, > but I noticed that the FB_STI dependency should not be there but > was introduced by slightly incorrect bug-fix patch that tried to > fix a link error. > > Instead of selecting 'VT' to make us enter the drivers/video/console > directory at compile-time, it's sufficient to build the > drivers/video/console/sticore.c file by adding its directory > to when CONFIG_FB_STI is enabled. Alternatively, we could move the > sticore code to another directory that is always built when we > have at STI_CONSOLE or FB_STI enabled. > > Fixes: 17085a934592 ("parisc: stifb: should depend on STI_CONSOLE") > Signed-off-by: Arnd Bergmann Patch queued for 4.12, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics