From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FA6CC46470 for ; Wed, 29 May 2019 23:19:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2835324314 for ; Wed, 29 May 2019 23:19:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559171955; bh=65UEsmibtrs6StZm2XDZ/W94p9aic/O7pvQ6FRLnGZM=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=IXkYrovn4viANijyfahtVe+twlUvJQ1yKzdf+afxWDkyZjsVYIR5w7cvIVZLndXjU NH5R7xyalvVs5Y6A/ZK0dZkOFqnmK1MbU9QPOt+7PMdT7WHrDobbRuknl03+fyHJPz bXyr78CK2YU0dPsPEg/oX1nv9/g2A9MZv4ajUDJ4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726540AbfE2XTO (ORCPT ); Wed, 29 May 2019 19:19:14 -0400 Received: from mail-it1-f195.google.com ([209.85.166.195]:55062 "EHLO mail-it1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726225AbfE2XTO (ORCPT ); Wed, 29 May 2019 19:19:14 -0400 Received: by mail-it1-f195.google.com with SMTP id h20so6914461itk.4 for ; Wed, 29 May 2019 16:19:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gvVrNX9+KA12CZFtJXZ2Anjp6TlWxWYL3KFrzyQz0s4=; b=hpACezGm+Av2ZqlIHxFN5c2QAR44g3WHweR58afFeC6kGL08n0I4QDcs5CiVrhbrZ/ Q5Mh5XWreWPZRqTNLXVRYwzxFjq6KAOheuYfdnSSVKqB+LHRhmgQGi1c3XGrDFX3MO1H Ds2HX4uL++oSrI0+EG7/bN9U3yog4k4QMkBGY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gvVrNX9+KA12CZFtJXZ2Anjp6TlWxWYL3KFrzyQz0s4=; b=C0RfnO4Xyu/a5K8Wi5zu4VLYYn2Du+veft2sRRytT0GaPJFbTTw5jIsNnBO3dnu3MR 63jFM6BuHGT68nYMhU94zX0eNU/M7qCMhOSjIFZ6qNRX9W2hYhFNncg988WJY001xGY6 1dYAVfsiYEHR5cLguyge6BYQyyZ6O7BKMvWdL+hVBbS2SB8Iiw5/1UIMbM8KvMJLAuc3 0gXA0xb7sVTrMkbuYdQISQrVoL9dZfONNIs4YWNaD71m36Mg/GlZM6Oj4SwnBvDgWaVx o4v+LS9gKC6SIQP8o7jyr/lHszECmUaP4CQLTaOqzvbzVzEEbGyh+nZDmAuWW1qnEOW9 SvCA== X-Gm-Message-State: APjAAAUIwrsdVgRgdi2UkZn2e1mE1x8I7ero8BuKnjlyDaUYNuYgxqsV Iz6HfOZvjhfK/kOVYUhWaxn8wQ== X-Google-Smtp-Source: APXvYqzU1xUFaMBalwA0GtYXKzaxpry5fypYcyCY3susGO0nFSAjqjh4GCov9XeTJ7RNG6ZWqjK4dQ== X-Received: by 2002:a24:5252:: with SMTP id d79mr675333itb.14.1559171953454; Wed, 29 May 2019 16:19:13 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id d71sm382566itc.18.2019.05.29.16.19.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 May 2019 16:19:12 -0700 (PDT) Subject: Re: [PATCH] usbip: usbip_host: fix stub_dev lock context imbalance regression To: Greg KH Cc: valentina.manea.m@gmail.com, shuah@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20190529194615.18765-1-skhan@linuxfoundation.org> <20190529202557.GA27140@kroah.com> From: Shuah Khan Message-ID: <3243c1dc-d198-9733-d3d0-5963e14b2d85@linuxfoundation.org> Date: Wed, 29 May 2019 17:19:11 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190529202557.GA27140@kroah.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/29/19 2:25 PM, Greg KH wrote: > On Wed, May 29, 2019 at 01:46:15PM -0600, Shuah Khan wrote: >> Fix the following sparse context imbalance regression introduced in >> a patch that fixed sleeping function called from invalid context bug. >> >> kbuild test robot reported on: >> >> tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-linus >> >> Regressions in current branch: >> >> drivers/usb/usbip/stub_dev.c:399:9: sparse: sparse: context imbalance in 'stub_probe' - different lock contexts for basic block >> drivers/usb/usbip/stub_dev.c:418:13: sparse: sparse: context imbalance in 'stub_disconnect' - different lock contexts for basic block >> drivers/usb/usbip/stub_dev.c:464:1-10: second lock on line 476 >> >> Error ids grouped by kconfigs: >> >> recent_errors >> ├── i386-allmodconfig >> │ └── drivers-usb-usbip-stub_dev.c:second-lock-on-line >> ├── x86_64-allmodconfig >> │ ├── drivers-usb-usbip-stub_dev.c:sparse:sparse:context-imbalance-in-stub_disconnect-different-lock-contexts-for-basic-block >> │ └── drivers-usb-usbip-stub_dev.c:sparse:sparse:context-imbalance-in-stub_probe-different-lock-contexts-for-basic-block >> └── x86_64-allyesconfig >> └── drivers-usb-usbip-stub_dev.c:second-lock-on-line >> >> This is a real problem in an error leg where spin_lock() is called on an >> already held lock. >> >> Fix the imbalance in stub_probe() and stub_disconnect(). >> >> Signed-off-by: Shuah Khan > > I'll go add: > > Fixes: 0c9e8b3cad65 ("usbip: usbip_host: fix BUG: sleeping function called from invalid context") > Cc: stable > > as the patch this fixes was tagged for stable. > Sounds good. Thanks. -- Shuah