From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA012322C8A for ; Mon, 17 Nov 2025 09:10:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763370640; cv=none; b=hCrIHwRrGBGwtOVaBeJlj0Mm4ctaoBmXTdhXlTNaPhCYOxG/lpF5ejoC0JM/krX9tWL69+bnuo2XSQKpAQvKUG6LmkgBunnRBsTVpWQGi5zLNJ1VIdZz7tADY1zmgJaZ6B4a3kKkJI5gjNrZIN4P3rCyLvpcOM2cvDz8u819G0I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763370640; c=relaxed/simple; bh=1/azYDKJxaxG26nuJdj4YWbnFkUxnDmREplw9fdjxC0=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=r6ClHB8+Me6UyOvL26Gfnn3Uyb2rWi/TARqNj9nj01SSZ7/goV/vjUUZw/Go27Pfiv3NOQuOEBiPdVm3mbxHMcKt7tWj3Ntrh/e2D5oA5r+cGuxZEN6TkYFhSh51dnB9podRFh8cPdr+2f2Mvt8/SNHX1E0HNNFvu51v/D70V80= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=k/93f+Bb; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="k/93f+Bb" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-429c48e05aeso2385254f8f.1 for ; Mon, 17 Nov 2025 01:10:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763370637; x=1763975437; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=Z5xS83R6jTExGfiXtHMfiumDDrM0n3+eJ9443zfQkUA=; b=k/93f+BbSaDCFLp7Yg8fB0YpSP0UtYKK36emEfDKUqNCfsFMFEUCdisBYjowFFGYuB Jy8onF4ASBbPGJEA1TrHM2DLhiXTkI7ITjDXd9odTeC/CN0sPKqC3f1dCprHslG/bA9N 9/BNux6S80XM05tE2YIW9fjxrxTWYWf4r6Mphwpi5sAtLVVD7MejCCzrzExFDbzQBzML uYaItahWhgS4dBTZJOzva2CwpBPO58f4u3KT9puBeLr+nOfQej+xFWB9R/wIlmtmuxWD fMyNsaOkXY4TDV3G2G8exv2B7K2lGZ+F7+McyQFEUtPjeBpgwIXZBXsmyAW7f1jNgd88 zt6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763370637; x=1763975437; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z5xS83R6jTExGfiXtHMfiumDDrM0n3+eJ9443zfQkUA=; b=Ao6hF+wNdP+rvCUhFQf0XMENOWMcixkAGzB8Frt9y5NJEcJNZh8agNW8Sj6E/m8oqq HfWMpwzzdEf6ixm00+NdeRaHyYjcLF0oADBYJQHplb+Tcl79gjfmQefPp6HtNxhQ+dT7 9cWV1HmMYasfCooFpj5+RSL9kJa2EsCucedMwPrRwPTi4dAWCsHOu2LwQy4ixVFyjgnw druycqOTJeHoVqqYveqqlnKOUO2QJt3Q1i8ijTuzs9HVMg1nasLm4P7CtYo/0g0bN21X WevzaaiQe6cjL2n50JZ8VdOucVLPEPLH2mHEtp271Nmijl06s2DaPDUjWbJdJOPgc6i2 i6AA== X-Forwarded-Encrypted: i=1; AJvYcCVkhgkNx+REL+D6La8sN3OoN86Y0JysjZMia6ogFv9USRC+4VvbqvmFD/ngLdtn6z22GKU+urdHlm+t3Mg=@vger.kernel.org X-Gm-Message-State: AOJu0YzxEx662Bbdh8yZtSWCl3g9JJF1Tv3gw1DP2OOz9E3sK3nTQruh 2sXvNr+XgrzXvTHcrxtdEmq0yaadhKCvB2meRo9XMIYkMjLo/7oIi9SuEZFfGLdciecvYsIGL3X OM6uV X-Gm-Gg: ASbGncu5CDa01+RM6cTtI6TRiHSZrF7owAlOGifGicy3BRH+DFjX9ut3F2+dInCrzge roOlzRMfg9FYl4QJMy5W81cZCWtxcPt8Vx6aA0pDlB2QoTVqmJTHG4km2wyHSV0AhFypbGmypLh KoPiCcRPB4paxa3hLadGPCmCR5w+HjLvN3N8usyHpglMIY2yQG4TJJM2Or50ND+nnehFH/vp7fK z0aqUjJho2SANtJIqmpH/S3ab6xbv5LL/f/7wzFy+16TW+ISyBAhGZ0gMCtgn8PX9rQxg2HdpE/ cs4ui2UdHfj4V2tt7fAaFAW53KKPsVoxrQKuozUEGPZzShjmJ6dHgOO7W0BZfrW4mmd75RKYp9x xG3v5mS1MeUuxiW2kxUj/xhBN0mcwYZAemOFl1oYcf3Nar3y9czfw2PQmwX7xu/U86A0NfOssPl c1YiZ6XkTWInbCS3VZo64sb5m0EtMnOuOHU1wtzyOs3jUCoyFbSOeoTZIztIGY0xc= X-Google-Smtp-Source: AGHT+IFInPvL/+hlf6EvBiL3GuycrSuUEXiGcy+maGHmWCjrynz9VPYDH7y5YTt48xKHIlg1cCH8VA== X-Received: by 2002:adf:b601:0:b0:42c:a420:e755 with SMTP id ffacd0b85a97d-42ca420e9eamr1015380f8f.23.1763370637172; Mon, 17 Nov 2025 01:10:37 -0800 (PST) Received: from ?IPV6:2a01:e0a:3d9:2080:d631:aa74:9313:e9f3? ([2a01:e0a:3d9:2080:d631:aa74:9313:e9f3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53f19aa0sm25146237f8f.37.2025.11.17.01.10.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Nov 2025 01:10:36 -0800 (PST) Message-ID: <3243f07f-da15-4819-837d-4de081d336ac@linaro.org> Date: Mon, 17 Nov 2025 10:10:35 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: Neil Armstrong Subject: Re: [PATCH v1 4/7] mmc: meson-mx-sdio: Use devm_mmc_alloc_host() helper To: Martin Blumenstingl , linux-amlogic@lists.infradead.org, linux-mmc@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ulf.hansson@linaro.org, Binbin Zhou References: <20251108231253.1641927-1-martin.blumenstingl@googlemail.com> <20251108231253.1641927-5-martin.blumenstingl@googlemail.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20251108231253.1641927-5-martin.blumenstingl@googlemail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/9/25 00:12, Martin Blumenstingl wrote: > From: Binbin Zhou > > Use new function devm_mmc_alloc_host() to simplify the code. > > Signed-off-by: Binbin Zhou > Signed-off-by: Martin Blumenstingl > --- > drivers/mmc/host/meson-mx-sdio.c | 18 +++++++----------- > 1 file changed, 7 insertions(+), 11 deletions(-) > > diff --git a/drivers/mmc/host/meson-mx-sdio.c b/drivers/mmc/host/meson-mx-sdio.c > index ce1828d915da..214ce84f1ddd 100644 > --- a/drivers/mmc/host/meson-mx-sdio.c > +++ b/drivers/mmc/host/meson-mx-sdio.c > @@ -648,7 +648,7 @@ static int meson_mx_mmc_probe(struct platform_device *pdev) > else if (IS_ERR(slot_pdev)) > return PTR_ERR(slot_pdev); > > - mmc = mmc_alloc_host(sizeof(*host), &slot_pdev->dev); > + mmc = devm_mmc_alloc_host(&slot_pdev->dev, sizeof(*host)); > if (!mmc) { > ret = -ENOMEM; > goto error_unregister_slot_pdev; > @@ -667,13 +667,13 @@ static int meson_mx_mmc_probe(struct platform_device *pdev) > &meson_mx_sdio_regmap_config); > if (IS_ERR(host->regmap)) { > ret = PTR_ERR(host->regmap); > - goto error_free_mmc; > + goto error_unregister_slot_pdev; > } > > irq = platform_get_irq(pdev, 0); > if (irq < 0) { > ret = irq; > - goto error_free_mmc; > + goto error_unregister_slot_pdev; > } > > ret = devm_request_threaded_irq(host->controller_dev, irq, > @@ -681,24 +681,24 @@ static int meson_mx_mmc_probe(struct platform_device *pdev) > meson_mx_mmc_irq_thread, IRQF_ONESHOT, > NULL, host); > if (ret) > - goto error_free_mmc; > + goto error_unregister_slot_pdev; > > core_clk = devm_clk_get_enabled(host->controller_dev, "core"); > if (IS_ERR(core_clk)) { > ret = PTR_ERR(core_clk); > - goto error_free_mmc; > + goto error_unregister_slot_pdev; > } > > host->cfg_div_clk = meson_mx_mmc_register_clk(&pdev->dev, base); > if (IS_ERR(host->cfg_div_clk)) { > ret = PTR_ERR(host->cfg_div_clk); > - goto error_free_mmc; > + goto error_unregister_slot_pdev; > } > > ret = clk_prepare_enable(host->cfg_div_clk); > if (ret) { > dev_err(host->controller_dev, "Failed to enable MMC clock\n"); > - goto error_free_mmc; > + goto error_unregister_slot_pdev; > } > > conf = 0; > @@ -718,8 +718,6 @@ static int meson_mx_mmc_probe(struct platform_device *pdev) > > error_disable_div_clk: > clk_disable_unprepare(host->cfg_div_clk); > -error_free_mmc: > - mmc_free_host(mmc); > error_unregister_slot_pdev: > of_platform_device_destroy(&slot_pdev->dev, NULL); > return ret; > @@ -737,8 +735,6 @@ static void meson_mx_mmc_remove(struct platform_device *pdev) > of_platform_device_destroy(slot_dev, NULL); > > clk_disable_unprepare(host->cfg_div_clk); > - > - mmc_free_host(host->mmc); > } > > static const struct of_device_id meson_mx_mmc_of_match[] = { Reviewed-by: Neil Armstrong