From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752286AbdHBQY3 (ORCPT ); Wed, 2 Aug 2017 12:24:29 -0400 Received: from vern.gendns.com ([206.190.152.46]:46958 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752066AbdHBQY1 (ORCPT ); Wed, 2 Aug 2017 12:24:27 -0400 Subject: Re: [PATCH v2 2/4] drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD To: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Cc: Daniel Vetter , David Airlie , Rob Herring , Mark Rutland , Sekhar Nori , Kevin Hilman , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1501625510-16727-1-git-send-email-david@lechnology.com> <1501625510-16727-3-git-send-email-david@lechnology.com> <32b134d1-84f3-8e3d-1d57-05c8b7c384bc@tronnes.org> From: David Lechner Message-ID: <3244660b-64f6-8202-b505-a9796b888db5@lechnology.com> Date: Wed, 2 Aug 2017 11:24:23 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <32b134d1-84f3-8e3d-1d57-05c8b7c384bc@tronnes.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/02/2017 08:03 AM, Noralf Trønnes wrote: > > > Please use tinydrm_xrgb8888_to_gray8(). I considered this, but is seems excessive to loop through the entire fb twice just to make a 4x6 cursor blink. > You should use this function to enable the regulator and init the > controller. Don't look at mi0283qt it should have been fixed. ACK. But this is why I was not keen on writing a standalone driver. I know some things about kernel development, but not everything. How am I supposed to know what is OK to copy from other drivers and what is not? And if I am going to be put down as the maintainer of this driver, it bothers me that I don't know so much about how it all works. > > Why 2 emulation formats? > I chose DRM_FORMAT_XRGB8888 since I expected everything to support it. > Please use only that. Because my graphics library currently does not work with XRGB8888. ;-) I can fix the graphics library and drop the RGB565 format in the kernel driver.