From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751229AbdJCMKS (ORCPT ); Tue, 3 Oct 2017 08:10:18 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:13001 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750865AbdJCMKQ (ORCPT ); Tue, 3 Oct 2017 08:10:16 -0400 X-AuditID: b6c32a48-c0fff70000001005-5f-59d37e265232 From: Bartlomiej Zolnierkiewicz To: "David S. Miller" , Guenter Roeck Cc: Lorenzo Pieralisi , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Bjorn Helgaas , Richard Henderson , Ivan Kokshaysky , Matt Turner Subject: Re: [PATCH v2] drivers/ide/pci: Fix legacy IRQ assignment Date: Tue, 03 Oct 2017 14:10:11 +0200 Message-id: <3245235.QGEOI6Flcd@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <4605844.iOhxHctWQT@amdc3058> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprCKsWRmVeSWpSXmKPExsWy7bCmma5a3eVIg5Z/bBZLmjIs5pxvYbH4 d2ojs8WxHY+YLC7vmsNmcXbecTaLJwvPMFm8+f2C3eLT7YPMFtNO3WF14PJYM28No8eWlTeZ PHbOusvusWBTqcf/s1EeO783sHv0Tf/A7PF5k1wARxSXTUpqTmZZapG+XQJXxvMZ21kLzqpV /D55h7GB8ZRCFyMnh4SAicS729tZuxi5OIQEdjBKrNq3iAkkISTwnVHi2HIxmKJJD1axQRRt YJQ4MmEdI4TzlVHiW+dVdpAqNgEriYntqxhBbBGBQIm2ZWvYQGxmgaVMEtOPK3UxcnAICzhJ fJoRABJmEVCV+N3RBlbOK6Ap8WDZBbByUQEviS372plAyjkFtCSOv3WAKBGU+DH5HgvERHmJ ffunskLYOhJnj0GcIyHwmk1izsV5zBBHu0h8PvWODcIWlnh1fAs7hC0t8WzVRkYIezqjxPbf EhDNm4G+3z0Bqsha4vDxi1Ab+CQ6Dv9lBzlIQoBXoqNNCML0kFg3MRui2lFiWuMJdkiQ7GWU eNQwm20Co+wsJHfPQnL3LCR3L2BkXsUollpQnJueWmxUYKJXnJhbXJqXrpecn7uJEZxWtDx2 MB4453OIUYCDUYmHN8HtUqQQa2JZcWXuIUYJDmYlEd5XVZcjhXhTEiurUovy44tKc1KLDzFK c7AoifPWbbsWISSQnliSmp2aWpBaBJNl4uCUamBk2q3csTLv3pP1xdt739+YId1VmlWSrm2m UWrQIHzg21PB81v83E7dSNTN+LWjXMl3b5xtvJj3E6+LB/hymWPeL1c8cPd8z0S3XpnVATca Pr3b7PDVuvX1ruNRz6T3bnq06U+sKc/JyGMJkjPnGu5ILb/yP7NZVJ/ny9y1/96/OXSb/f3y iEdZSizFGYmGWsxFxYkAYBYlfycDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLLMWRmVeSWpSXmKPExsVy+t9jQV3VusuRBjcvGlksacqwmHO+hcXi 36mNzBbHdjxisri8aw6bxdl5x9ksniw8w2Tx5vcLdotPtw8yW0w7dYfVgctjzbw1jB5bVt5k 8tg56y67x4JNpR7/z0Z57PzewO7RN/0Ds8fnTXIBHFFcNimpOZllqUX6dglcGc9nbGctOKtW 8fvkHcYGxlMKXYycHBICJhKTHqxi62Lk4hASWMco8fX+FFaQhJDAV0aJxsvyIDabgJXExPZV jCC2iIC/xLSLT9lBGpgFFjNJ/FjfxtTFyMEhLOAk8WlGAEgNi4CqxO+ONrB6XgFNiQfLLrCB 2KICXhJb9rWDlXMKaEkcf+sAsSpTomftdVaIckGJH5PvsYDYzALyEvv2T2WFsLUk1u88zjSB kX8WkrJZSMpmISlbwMi8ilEytaA4Nz232KjAKC+1XK84Mbe4NC9dLzk/dxMjMBK2Hdbq38H4 eEn8IUYBDkYlHt4dHpcihVgTy4orcw8xSnAwK4nwvqq6HCnEm5JYWZValB9fVJqTWnyIUZqD RUmclz//WKSQQHpiSWp2ampBahFMlomDU6qBcWH9lfbPj179nbLqQrJ6NH+V7impC4F/JOre HXftuPszuHbjy8utF50D2OQFXiXYbbpcd+DMrfXS3zR3RN40+7/tQerCSoV9kt4dtjZPl0Xw ca5OyIspqDx8uFqvK2cZQ7fI9FJfY/7eGqWXVwKvec0KVat/0KR6ITnv0EKjQ+EZmpVzDQ3W KbEUZyQaajEXFScCAK8lVPuAAgAA X-CMS-MailID: 20171003121013epcas2p31c8ad6c89249a6e135c030e26f833496 X-Msg-Generator: CA X-Sender-IP: 182.195.42.143 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 102P X-CMS-RootMailID: 20171003121013epcas2p31c8ad6c89249a6e135c030e26f833496 X-RootMTR: 20171003121013epcas2p31c8ad6c89249a6e135c030e26f833496 References: <1506941567-10762-1-git-send-email-lorenzo.pieralisi@arm.com> <4605844.iOhxHctWQT@amdc3058> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, October 03, 2017 11:39:55 AM Bartlomiej Zolnierkiewicz wrote: > On Monday, October 02, 2017 11:52:47 AM Lorenzo Pieralisi wrote: > > Through struct pci_host_bridge->{map/swizzle}_irq() hooks is now > > possible to define IRQ mapping functions on a per PCI host bridge basis. > > > > Actual IRQ allocation is carried out by the pci_assign_irq() function in > > pci_device_probe() - to make sure a device is assigned an IRQ only if it > > is probed (ie match a driver); it retrieves a struct pci_host_bridge* > > for a given PCI device and through {map/swizzle}_irq() it carries out > > the PCI IRQ allocation. > > > > The code conversion to struct pci_host_bridge {map/swizzle}_irq() hooks > > and pci_assign_irq() to deal with legacy IRQs in > > > > commit 30fdfb929e82 ("PCI: Add a call to pci_assign_irq() in > > pci_device_probe()") > > > > did not take into account that the IDE subsystem relies on a special > > purpose IDE PCI layer, configured by CONFIG_IDEPCI_PCIBUS_ORDER to force > > devices probe ordering by sidestepping the core PCI bus layer entirely > > (and therefore pci_device_probe()) by executing the registered IDE PCI > > drivers probe routines (ie registered with ide_pci_register_driver()) > > through ide_scan_pcidev(). > > > > Since this IDE PCI specific probe mechanism bypasses the PCI core > > code generic probing (ie pci_device_probe()) it also misses the > > pci_assign_irq() call (among other PCI initialization functions); > > this triggers IDE PCI devices initialization failures caused > > by the missing IRQ allocation: > > > > ide0: disabled, no IRQ > > ide0: failed to initialize IDE interface > > ide0: disabling port > > cmd64x 0000:00:02.0: IDE controller (0x1095:0x0646 rev 0x07) > > CMD64x_IDE 0000:00:02.0: BAR 0: can't reserve [io 0x8050-0x8057] > > cmd64x 0000:00:02.0: can't reserve resources > > CMD64x_IDE: probe of 0000:00:02.0 failed with error -16 > > ide_generic: please use "probe_mask=0x3f" module parameter for probing > > all legacy ISA IDE ports > > ------------[ cut here ]------------ > > WARNING: CPU: 0 PID: 1 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x94/0xd0 > > sysfs: cannot create duplicate filename '/class/ide_port/ide0' > > ... > > > > Trace: > > [] __warn+0x160/0x190 > > [] sysfs_warn_dup+0x94/0xd0 > > [] warn_slowpath_fmt+0x58/0x70 > > [] sysfs_warn_dup+0x94/0xd0 > > [] kernfs_path_from_node+0x30/0x60 > > [] kernfs_put+0x16c/0x2c0 > > [] kernfs_put+0x16c/0x2c0 > > [] sysfs_do_create_link_sd.isra.2+0x100/0x120 > > [] device_add+0x2a4/0x7c0 > > [] device_create_groups_vargs+0x14c/0x170 > > [] device_create_groups_vargs+0x98/0x170 > > [] device_create+0x50/0x70 > > [] ide_host_register+0x48c/0xa00 > > [] ide_host_register+0x450/0xa00 > > [] device_register+0x20/0x50 > > [] ide_host_register+0x450/0xa00 > > [] ide_host_add+0x64/0xe0 > > [] kobject_uevent_env+0x16c/0x710 > > [] do_one_initcall+0x68/0x260 > > [] kernel_init+0x1c/0x1a0 > > [] kernel_init+0x0/0x1a0 > > [] ret_from_kernel_thread+0x18/0x20 > > [] kernel_init+0x0/0x1a0 > > > > ---[ end trace 24a70433c3e4d374 ]--- > > ide0: disabling port > > > > Fix the IRQ allocation issue by adding a pci_assign_irq() call in the > > ide_scan_pcidev() function before probing the IDE PCI drivers, so that > > IRQs for a given PCI device are allocated for the IDE PCI drivers to > > use them for device configuration. > > > > Fixes: 30fdfb929e82 ("PCI: Add a call to pci_assign_irq() in pci_device_probe()") > > Link: http://lkml.kernel.org/r/32ec730f-c1b0-5584-cd35-f8a809122b96@roeck-us.net > > Signed-off-by: Lorenzo Pieralisi > > Reported-by: Guenter Roeck > > Cc: Bjorn Helgaas > > Cc: Richard Henderson > > Cc: Ivan Kokshaysky > > Cc: David S. Miller > > Cc: Guenter Roeck > > Cc: Matt Turner > > Reviewed-by: Bartlomiej Zolnierkiewicz IDE specific problems uncovered by pci_assign_irq() change have been addressed in separate patches, please see: http://patchwork.ozlabs.org/patch/820859/ http://patchwork.ozlabs.org/patch/820870/ Guenter, could you please verify them (I have only compile tested them)? [ Just revert Lorenzo's fix and apply both my patches. ] Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics