From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 008D4C433EF for ; Wed, 22 Jun 2022 09:10:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357325AbiFVJKt (ORCPT ); Wed, 22 Jun 2022 05:10:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357255AbiFVJKE (ORCPT ); Wed, 22 Jun 2022 05:10:04 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A1F733A17; Wed, 22 Jun 2022 02:09:05 -0700 (PDT) X-UUID: abef69317a0946c881519c61ee345515-20220622 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.6,REQID:b7d31dec-646d-454a-8017-b02839f392ef,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:b14ad71,CLOUDID:efe2bd2d-1756-4fa3-be7f-474a6e4be921,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:nil,BEC:nil,COL:0 X-UUID: abef69317a0946c881519c61ee345515-20220622 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 17422979; Wed, 22 Jun 2022 17:09:01 +0800 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Wed, 22 Jun 2022 17:09:00 +0800 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 22 Jun 2022 17:08:59 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Wed, 22 Jun 2022 17:08:59 +0800 Message-ID: <3246fb94ec05a43b7017849198d949ce8c8636a7.camel@mediatek.com> Subject: Re: [PATCH v13 12/14] drm/mediatek: dpi: add config to control setting of direct connection to pins From: Rex-BC Chen To: AngeloGioacchino Del Regno , , , , , , , CC: , , , , , , , , , , Date: Wed, 22 Jun 2022 17:08:59 +0800 In-Reply-To: <55c98626-9b95-7721-94cf-8c471580a53b@collabora.com> References: <20220621113732.11595-1-rex-bc.chen@mediatek.com> <20220621113732.11595-13-rex-bc.chen@mediatek.com> <55c98626-9b95-7721-94cf-8c471580a53b@collabora.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2022-06-21 at 14:11 +0200, AngeloGioacchino Del Regno wrote: > Il 21/06/22 13:37, Bo-Chen Chen ha scritto: > > MediaTek dpi supports direct connection to pins while dp_intf does > > not > > support. Therefore, add a config "support_direct_pin" to control > > this. > > > > Signed-off-by: Bo-Chen Chen > > --- > > drivers/gpu/drm/mediatek/mtk_dpi.c | 17 +++++++++++++---- > > 1 file changed, 13 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c > > b/drivers/gpu/drm/mediatek/mtk_dpi.c > > index 438bf3bc5e4a..ef7f828a4b1e 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c > > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c > > @@ -129,6 +129,8 @@ struct mtk_dpi_yc_limit { > > * @is_ck_de_pol: Support CK/DE polarity. > > * @swap_input_support: Support input swap function. > > * @color_fmt_trans_support: Enable color format transfer. > > + * @support_direct_pin: Dpi can directly connect pins, and enable > > this config > > + * to do this. > > @support_direct_pin: IP supports direct connection to pins > > or > > @support_direct_pin: IP has direct connection to DP pins > > or > > @support_direct_pin: IP connects directly to DP pins > > pick one, after which: > > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > > Hello Angelo, this is not connect to "DP" pin. This setting is for dpi to connect to panel directly and there is no such usecase for dp_intf. Therefore, I will use "@support_direct_pin: IP supports direct connection to pins". Thanks BRs, Bo-Chen