From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933990AbcIFNeG convert rfc822-to-8bit (ORCPT ); Tue, 6 Sep 2016 09:34:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49348 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932893AbcIFNeE (ORCPT ); Tue, 6 Sep 2016 09:34:04 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20160906132614.2117695-1-arnd@arndb.de> References: <20160906132614.2117695-1-arnd@arndb.de> To: Arnd Bergmann Cc: dhowells@redhat.com, "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rxrpc: remove duplicate 'error' variable MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <32471.1473168842.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Tue, 06 Sep 2016 14:34:02 +0100 Message-ID: <32472.1473168842@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 06 Sep 2016 13:34:04 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann wrote: > The rxrpc_process_call function has debug code to print a failure code, > but instead of printing the code from the rxrpc_call structure, it > prints an uninitialized variable: > > net/rxrpc/call_event.c: In function 'rxrpc_process_call': > net/rxrpc/call_event.c:879:58: error: 'error' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > This removes the extraneous variable and prints the correct > code instead. > > Signed-off-by: Arnd Bergmann > Fixes: f5c17aaeb2ae ("rxrpc: Calls should only have one terminal state") I've already posted a fix and it's waiting on DaveM. https://patchwork.ozlabs.org/patch/665550/ http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/commit/?h=rxrpc-rewrite&id=00b5407e427ac2588a2496b92035a94602b3cd1b David