From: Daniel Almeida <daniel.almeida@collabora.com>
To: "Guilherme Giácomo Simões" <trintaeoitogc@gmail.com>
Cc: rafael@kernel.org, ojeda@kernel.org, alex.gaynor@gmail.com,
boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com,
benno.lossin@proton.me, aliceryhl@google.com, mcgrof@kernel.org,
russ.weight@linux.dev, dakr@redhat.com, a.hindborg@kernel.org,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] device: rust: change the name function
Date: Sun, 29 Sep 2024 12:35:09 -0300 [thread overview]
Message-ID: <32476CD7-74D6-4575-9D93-2FBCD5AE3E10@collabora.com> (raw)
In-Reply-To: <CAM_RzfavjM9VPJhTi1czOSC0BFOc3FUHRMdzFrU9fJE+WJMKbw@mail.gmail.com>
Hi Guilherme, welcome to the community!
The commit message needs some work IMHO. In particular, links may become stale,
so please do not link to anything.
It’s also written in first person and in a verbose way, which is not good.
Just describe what you did and why the change was necessary succinctly.
You can find some more tips at
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
Lastly, I can’t see a diff anywhere. Make sure everything you send can
actually be applied and *at least* compile-check your changes. Submitting
patches that do not apply and/or do not compile can make people lose interest.
Send a v2 with the fixes above and we can start to actually discuss your code.
BR
— Daniel
next prev parent reply other threads:[~2024-09-29 15:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-29 13:30 Guilherme Giácomo Simões
2024-09-29 15:35 ` Daniel Almeida [this message]
2024-09-30 4:33 ` Dirk Behme
2024-09-30 11:14 ` Guilherme Giácomo Simões
2024-09-30 12:04 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32476CD7-74D6-4575-9D93-2FBCD5AE3E10@collabora.com \
--to=daniel.almeida@collabora.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@redhat.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=russ.weight@linux.dev \
--cc=rust-for-linux@vger.kernel.org \
--cc=trintaeoitogc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®