From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753250AbbE1J6Z (ORCPT ); Thu, 28 May 2015 05:58:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54161 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751415AbbE1J6Q (ORCPT ); Thu, 28 May 2015 05:58:16 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1432801998.3499.23.camel@infradead.org> References: <1432801998.3499.23.camel@infradead.org> <1432084120-7918-1-git-send-email-mmarek@suse.cz> <18832.1432044859.1@warthog.procyon.org.uk> <19779.1432656938@warthog.procyon.org.uk> <5566A53C.6020309@suse.cz> To: David Woodhouse Cc: dhowells@redhat.com, Michal Marek , torvalds@linux-foundation.org, aricart@memnix.com, linux-kernel@vger.kernel.org, sedat.dilek@gmail.com, keyrings@linux-nfs.org, rusty@rustcorp.com.au, linux-security-module@vger.kernel.org, james.l.morris@oracle.com Subject: Re: [PATCH 1/3] X.509: Fix certificate gathering again MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <32481.1432807089.1@warthog.procyon.org.uk> Date: Thu, 28 May 2015 10:58:09 +0100 Message-ID: <32482.1432807089@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Woodhouse wrote: > > The only issue is that the makefile expressions are a bit hairy. For > > starters, we already have definitions for $(quote) and $(space) in > > kbuild. I'll have a closer look at the config_filename macro and try to > > simplify it somehow. But it's just cosmetics, the patch can be merged as > > is for now. > > I've actually changed my mind about the 'awk | base64 -d' bit. The error > handling is too poor. I'd like to do that in C with a variant of the > existing extract_cert tool, and make sure we have proper X.509 > certificates and error handling/reporting. You could also do it in perl pretty easily. David