From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755794AbbCRPDq (ORCPT ); Wed, 18 Mar 2015 11:03:46 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:51328 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755717AbbCRPDm (ORCPT ); Wed, 18 Mar 2015 11:03:42 -0400 From: "Rafael J. Wysocki" To: Martin Kepplinger Cc: lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] acpi: battery: make warning greppable Date: Wed, 18 Mar 2015 16:27:36 +0100 Message-ID: <3248282.q652f4oAaQ@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.19.0+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1426204097-3024-1-git-send-email-martink@posteo.de> References: <1426204097-3024-1-git-send-email-martink@posteo.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, March 13, 2015 12:48:17 AM Martin Kepplinger wrote: > Signed-off-by: Martin Kepplinger > --- > I was so angry now, I had to write a change. Please keep things greppable and > save unnecessary questions and time this way. Queued up for 4.1, thanks! > drivers/acpi/battery.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c > index d98ba43..baebd1a 100644 > --- a/drivers/acpi/battery.c > +++ b/drivers/acpi/battery.c > @@ -530,8 +530,8 @@ static int acpi_battery_get_state(struct acpi_battery *battery) > battery->rate_now != ACPI_BATTERY_VALUE_UNKNOWN && > (s16)(battery->rate_now) < 0) { > battery->rate_now = abs((s16)battery->rate_now); > - printk_once(KERN_WARNING FW_BUG "battery: (dis)charge rate" > - " invalid.\n"); > + printk_once(KERN_WARNING FW_BUG > + "battery: (dis)charge rate invalid.\n"); > } > > if (test_bit(ACPI_BATTERY_QUIRK_PERCENTAGE_CAPACITY, &battery->flags) > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.