From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752608AbbHZXKQ (ORCPT ); Wed, 26 Aug 2015 19:10:16 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:48338 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751769AbbHZXKP (ORCPT ); Wed, 26 Aug 2015 19:10:15 -0400 From: "Rafael J. Wysocki" To: Guenter Roeck Cc: Greg Kroah-Hartman , Steve Glendinning , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, "Rafael J. Wysocki" , Jeremy Linton , tony@atomide.com Subject: Re: [PATCH -next v2 1/2] device property: Return -ENXIO if there is no suitable FW interface Date: Thu, 27 Aug 2015 01:37:47 +0200 Message-ID: <3249742.BGnB0hq1eB@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.1.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1440620445-14413-1-git-send-email-linux@roeck-us.net> References: <1440620445-14413-1-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, August 26, 2015 01:20:44 PM Guenter Roeck wrote: > Return -ENXIO if device property array access functions don't find > a suitable firmware interface. > > This lets drivers decide if they should use available platform data > instead. > > Cc: Rafael J. Wysocki > Signed-off-by: Guenter Roeck > --- > v2: Added patch > > drivers/base/property.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/base/property.c b/drivers/base/property.c > index 287704d680bf..9600b824d138 100644 > --- a/drivers/base/property.c > +++ b/drivers/base/property.c > @@ -69,6 +69,9 @@ static int pset_prop_read_array(struct property_set *pset, const char *name, > struct property_entry *prop; > unsigned int item_size; > > + if (!pset) > + return -ENXIO; > + This isn't exactly straightforward, because it relies on the fact that pset_prop_read_array() is the last thing tried by FWNODE_PROP_READ_ARRAY() and fwnode_property_read_string_array(). A comment about that might be helpful. Thanks, Rafael