From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752542AbcBWPBt (ORCPT ); Tue, 23 Feb 2016 10:01:49 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:61120 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751469AbcBWPBs (ORCPT ); Tue, 23 Feb 2016 10:01:48 -0500 From: Arnd Bergmann To: Russell King - ARM Linux Cc: Santosh Shilimkar , Nishanth Menon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [RFC] ARM: keystone: possibly fix big-endian kernels Date: Tue, 23 Feb 2016 16:01:06 +0100 Message-ID: <3249746.5p1eRtyJ9a@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160223145318.GK19428@n2100.arm.linux.org.uk> References: <1456238609-962461-1-git-send-email-arnd@arndb.de> <20160223145318.GK19428@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:bc1BtmVaQQ8qs/hybGTGsChQGMp5/eNWoO70WIDbSxdZGmizaHW +Rmh4wKXel4ZuLwKlYY1KbAYl+UaOp6dS9dXvzKqPc2fT/Kb6KeorerQ5hmPSqC1Y2hJx1h 43ckFEnogQ+1t5/mohWNFnYNzIc6hgIljGfomLCSs6cXXaMjEav/v9JPQeKUzGGlyPJL4A2 jUjjVcHZk3N7skd1cs87g== X-UI-Out-Filterresults: notjunk:1;V01:K0:sDqMGGES5xg=:436K9oiLczde0nDFynEGfP 0C6UnntN7SWt2iVvQ3E7tJnODICi0ro1N/zTvA4Tc5i137GFDVMhLugg1FL8XDwmCalJZt+N5 3BsQM+/T3/5tRMAF+MfSfMlWpDl2ru2Qx7NSwpj57hdJEvYzrpU92K4x45gG6xuFFVHBWtfVA l50HD8IljXAIdbaM/+MMxFqJ48NK8dqL8OuhPS24stNtDcbOtQtSMTcFj6pImJaYjGiLws9pT cdP1SxM/f4+2a6QIHDScF6fqstCk9HfwodoamzhhPXqlyaYhCab6AubNqU0KoQEKByiq8UluW qoL3COdN1ZXY78Nnc/U5eDcmO44J9juJvVsJCcNYI8oQDwsyP3qhCtjDITxpiKLXorw415HwN mJUoNIXqnRyqOkwg6qcWd1agCbkVztq7NSM1t9EzxsaHnA6SsymG1ycP8wrgUJxWPOc4yBjWp ZC0aeB2CaypTE7gPPwBlWxB+7PNXg9PxkbKJ0Dmk9Q3qHlA8EKZENId91IDku26Q8Ee/xE7M8 e+6qbQle1zorALubIVM2ZWjLAuXjZUU0UNyiDKnbHuFbrjuI7R8H+BUPMVjS0EMeT4xFFPzfx Wnbxh3/DK2Ld4GVdeZs/6RT7oJ4qfn1NzufV9p2KTCBSPHO9ZNChFM3bJRLMOFIPLBLVJqJAe 1xMcnNI1s0p5xG/yXl+Dcpw1OPqm1yNz2lPgiqRAe24hLt4PzNEhdOndC+hPHsaZ3uMUyL5hq qFI69qPsJ16KyfVP Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 23 February 2016 14:53:18 Russell King - ARM Linux wrote: > On Tue, Feb 23, 2016 at 03:43:21PM +0100, Arnd Bergmann wrote: > > While discussing a regressing in the netcp driver, I wondered > > whether Keystone can work with a big-endian kernel, and noticed > > that we don't switch endianess when we enter the kernel on the > > secondary CPU, or when we call into smc. > > NAK. Sorry Arnd, you're worringly wrong on this. > > secondary_startup will do the setend if necessary, there's no need > to do this kind of junk in each and every platform. It's been this > way since: > > commit 97bcb0fea590d3d704f985bec08f342d28992634 > Author: Ben Dooks > Date: Fri Feb 1 09:40:42 2013 +0000 > > So, I hope you've not been telling platform folk to do this. Please > audit the arm-soc code to make sure, thanks. > I see my mistake now: I looked at the secondary_startup() function by looking up the location in ctags, and that pointed me to arch/arm/kernel/head-nommu.S. I was surprised when I didn't see the setend() in there, but didn't realize that I was looking in the wrong place, but it made some sense when I found the setend in a couple of other platforms that all need a wrapper anyway. Sorry about the noise. Arnd