From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Lukasz Anaczkowski <lukasz.anaczkowski@intel.com>
Cc: len.brown@intel.com, mingo@redhat.com, x86@kernel.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH v2] ACPI/SRAT: fix SRAT order parsing when both LAPIC and X2APIC present
Date: Wed, 27 Apr 2016 23:23:24 +0200 [thread overview]
Message-ID: <32506564.fbJE22l67l@vostro.rjw.lan> (raw)
In-Reply-To: <1461230940-5037-2-git-send-email-lukasz.anaczkowski@intel.com>
On Thursday, April 21, 2016 11:29:00 AM Lukasz Anaczkowski wrote:
> SRAT maps APIC ID to proximity domains ids (PXM). Mapping from PXM to
> NUMA node ids is based on order of entries in SRAT table.
> SRAT table has just LAPIC entires or mix of LAPIC and X2APIC entries.
> As long as there are only LAPIC entires, mapping from proximity domain
> id to NUMA node id is as assumed by BIOS. However, once APIC entries are
> mixed, X2APIC entries would be first mapped which causes unexpected NUMA
> node mapping.
> To fix that, change parsing to check each entry against both LAPIC and
> X2APIC so mapping is in the SRAT/PXM order.
> This is supplemental change to the fix made by d81056b5278 (thus
> "Fixes:" tag) and using same mechanism introduced by 9b3fedd (ACPI / tables:
> Add acpi_subtable_proc to ACPI table parsers).
>
> Fixes: d81056b5278 (Handle apic/x2apic entries in MADT in correct order)
> Signed-off-by: Lukasz Anaczkowski <lukasz.anaczkowski@intel.com>
Applied, thanks!
prev parent reply other threads:[~2016-04-27 21:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 8:21 [PATCH] " Lukasz Anaczkowski
2016-04-21 0:07 ` Rafael J. Wysocki
2016-04-21 9:28 ` Lukasz Anaczkowski
2016-04-21 9:29 ` [PATCH v2] " Lukasz Anaczkowski
2016-04-27 21:23 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32506564.fbJE22l67l@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.anaczkowski@intel.com \
--cc=mingo@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®