From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3199FC4332B for ; Fri, 20 Mar 2020 08:20:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DE55B20767 for ; Fri, 20 Mar 2020 08:20:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QCoGdzyy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726806AbgCTIUa (ORCPT ); Fri, 20 Mar 2020 04:20:30 -0400 Received: from us-smtp-delivery-74.mimecast.com ([216.205.24.74]:29118 "EHLO us-smtp-delivery-74.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726657AbgCTIUa (ORCPT ); Fri, 20 Mar 2020 04:20:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584692429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VVZY6TeI0YOm1FYG0w30u2dqA8tug6BHP6KzUJXch3w=; b=QCoGdzyya9ukt/wRDa4wC3ON5V3UK13QfXp55/FjzVJYzpv/molcLNQzJ91RkCw63Vy6Y+ tHIU3/ROUyPes0IBFUb4fdKlQUhk+2J5TDLi83vZpZkyWLzdMAl+U66u6RaCPbVm3mAh7n WUyq3n9UiaD1igLOdDQ64g5ZaVpdsjc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-111-Nm9VmDiBOxqeGfERJwsHVA-1; Fri, 20 Mar 2020 04:20:27 -0400 X-MC-Unique: Nm9VmDiBOxqeGfERJwsHVA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B69A7800D5A; Fri, 20 Mar 2020 08:20:24 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-113-126.rdu2.redhat.com [10.10.113.126]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5E2B85D9CA; Fri, 20 Mar 2020 08:20:20 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20200318221457.1330-2-longman@redhat.com> References: <20200318221457.1330-2-longman@redhat.com> <20200318221457.1330-1-longman@redhat.com> To: Waiman Long Cc: dhowells@redhat.com, Jarkko Sakkinen , James Morris , "Serge E. Hallyn" , Mimi Zohar , "David S. Miller" , Jakub Kicinski , keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, netdev@vger.kernel.org, linux-afs@lists.infradead.org, Sumit Garg , Jerry Snitselaar , Roberto Sassu , Eric Biggers , Chris von Recklinghausen Subject: Re: [PATCH v5 1/2] KEYS: Don't write out to userspace while holding key semaphore MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3251034.1584692419.1@warthog.procyon.org.uk> Date: Fri, 20 Mar 2020 08:20:19 +0000 Message-ID: <3251035.1584692419@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Waiman Long wrote: > + if ((ret > 0) && (ret <= buflen)) { That's a bit excessive on the bracketage, btw, but don't worry about it unless you respin the patches. David