From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752647AbdJSVRE (ORCPT ); Thu, 19 Oct 2017 17:17:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36490 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752425AbdJSVQ6 (ORCPT ); Thu, 19 Oct 2017 17:16:58 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5AA4960178 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=dhowells@redhat.com Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20171019185016.GA18770@embeddedor.com> References: <20171019185016.GA18770@embeddedor.com> To: "Gustavo A. R. Silva" Cc: dhowells@redhat.com, "David S. Miller" , linux-afs@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: rxrpc: mark expected switch fall-throughs MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <32523.1508447816.1@warthog.procyon.org.uk> Date: Thu, 19 Oct 2017 22:16:56 +0100 Message-ID: <32524.1508447816@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 19 Oct 2017 21:16:58 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Gustavo A. R. Silva wrote: > + /* fall through */ All new comments in rxrpc should begin with a capital letter; I'm switching to this as I modify the lines with comments on. Fix checkpatch or gcc or whatever takes -Wimplicit-fallthrough to stop being silly. > - /* Fall through */ > - > + /* fall through */ No. Firstly, it should be 'F'; secondly, don't remove the blank line - it's there for a reason. > + /* fall through */ Capital 'F'. > - > + /* fall through */ Don't remove the blank line. Capital 'F'. > + /* fall through */ Capital 'F'. David