From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5C454499A4 for ; Mon, 13 Jul 2026 19:52:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783972340; cv=none; b=HmYm+bEOizGZODCyhXl00QFMHPjE8I3C0H8MVqTqfz3nYeg2miqC4pX6OLxJ0TS39AAxCinMK2LWzEbWg3qNlKKZA9Y5zy3hvwJtRs1b9Dp8XGeeiTx/EbF7TMYR2nbVxh9WBePaBdSWmZHntLnTPhpMx9jrIgFTZouF95Jih+s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783972340; c=relaxed/simple; bh=NpItpBHbzQXrD8NlvPJ4kPXYymbJbifRzE/eRmJKAYU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Je/g0ajR0qXCf0FIJfH2yaLdeE9GD7MzWOLY3GkB/emTgIgFvFrnkFZDCNHPN5XpsD5EV/fMhmA5KqQJoTQ6+prt6C14eFCHLw6tEGOgTmz4gVRtomXPRQhSutYPp32IiwwlSd06en9A+zvthS2vYfn1SHhM3XnkGmPtu1yP2Yc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=TCunWP9o; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TCunWP9o" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783972337; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ebEVzm3HmPm1KEoHOqy8jH6oE1PVwmUJHpt/zJcOqNQ=; b=TCunWP9oTdZMx4vvYxrDxz6LlrpkNCt1jATFWa7vKKh9zV6oFTw4pfTGS2SMpR4X34SeZe J3rnbl580yYNVG/flrPmxM9Nx1ZVUEL1OFj+mAyaR5bsp+puQdiiCizH5JlGCn71LKenfr 1EzuVPTVcfUZcPfwJvanHbTTVZ4xaJU= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-311-OgXyGd3MNrSokVWW1hA5lA-1; Mon, 13 Jul 2026 15:52:14 -0400 X-MC-Unique: OgXyGd3MNrSokVWW1hA5lA-1 X-Mimecast-MFC-AGG-ID: OgXyGd3MNrSokVWW1hA5lA_1783972333 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 476F41800D92; Mon, 13 Jul 2026 19:52:12 +0000 (UTC) Received: from [10.22.89.233] (unknown [10.22.89.233]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id CD9CE765; Mon, 13 Jul 2026 19:52:09 +0000 (UTC) Message-ID: <32543c25-dc4a-4590-a88c-e8bfd76c24ad@redhat.com> Date: Mon, 13 Jul 2026 15:52:09 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] sched/isolation: Defer freeing of cpumask memblock memory to initcall To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, Phil Auld , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , K Prateek Nayak , Frederic Weisbecker References: <20260701195810.477326-1-longman@redhat.com> Content-Language: en-US From: Waiman Long In-Reply-To: <20260701195810.477326-1-longman@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 On 7/1/26 3:58 PM, Waiman Long wrote: > When testing a linux-next kernel with commit 59bd1d914bb5 ("memblock: > warn when freeing reserved memory before memory map is initialized"), > the following warning was hit when there was a "nohz_full" kernel boot > parameter. > > Cannot free reserved memory because of deferred initialization of the memory map > WARNING: mm/memblock.c:904 at __free_reserved_area+0xde/0xf0, CPU#0: swapper/0/0 > : > Call Trace: > > memblock_phys_free+0xcb/0x100 > housekeeping_init+0x14c/0x170 > start_kernel+0x207/0x450 > x86_64_start_reservations+0x24/0x30 > x86_64_start_kernel+0xda/0xe0 > common_startup_64+0x13e/0x141 > > > IOW, we shouldn't free memblock allocated memory so early > in the boot process when memory map isn't fully initialized in > deferred_init_memmap(). > > Fix it by saving the housekeeping cpumask memblock memory to be > freed into a llist free list in housekeeping_init() and add a new > housekeeping_late_init() helper to defer the actual freeing of memblock > memory to when initcall's are being processed. The cpumask memblock > memory is treated as a llist_node with the size of a "long" type which > is also smallest cpumask size that can be allocated. > > The non-atomic version of the llist APIs are used as there is no > contention. > > This commit depends on the presence of commit 7c2eee9c1367 ("memblock: > don't touch memblock arrays when memblock_free() is called late") > to prevent a KASAN UAF bug report [1]. > > [1] https://lore.kernel.org/lkml/20260505051821.1107133-1-longman@redhat.com/ > > Fixes: 27c3a5967f05 ("sched/isolation: Convert housekeeping cpumasks to rcu pointers") > Reviewed-by: Frederic Weisbecker > Reviewed-by: Phil Auld > Signed-off-by: Waiman Long Peter, Are you OK with this patch as I would like to get it merged into v7.3 if possible? Cheers, Longman > --- > kernel/sched/isolation.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > [v4] Collect tags and update commit log > > diff --git a/kernel/sched/isolation.c b/kernel/sched/isolation.c > index ef152d401fe2..156025ef81b7 100644 > --- a/kernel/sched/isolation.c > +++ b/kernel/sched/isolation.c > @@ -8,6 +8,7 @@ > * > */ > #include > +#include > #include > #include "sched.h" > > @@ -27,6 +28,7 @@ struct housekeeping { > }; > > static struct housekeeping housekeeping; > +static __initdata LLIST_HEAD(memblock_freelist); > > bool housekeeping_enabled(enum hk_type type) > { > @@ -189,10 +191,22 @@ void __init housekeeping_init(void) > WARN_ON_ONCE(cpumask_empty(omask)); > cpumask_copy(nmask, omask); > RCU_INIT_POINTER(housekeeping.cpumasks[type], nmask); > - memblock_free(omask, cpumask_size()); > + __llist_add((struct llist_node *)omask, &memblock_freelist); > } > } > > +static int __init housekeeping_late_init(void) > +{ > + struct llist_node *llnode, *pos, *t; > + > + /* Free allocated memblock memory, if any */ > + llnode = __llist_del_all(&memblock_freelist); > + llist_for_each_safe(pos, t, llnode) > + memblock_free(pos, cpumask_size()); > + return 0; > +} > +pure_initcall(housekeeping_late_init); > + > static void __init housekeeping_setup_type(enum hk_type type, > cpumask_var_t housekeeping_staging) > {