From: Valdis.Kletnieks@vt.edu
To: Andi Kleen <ak@linux.intel.com>
Cc: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
Mike Travis <travis@sgi.com>, Roland Dreier <rdreier@cisco.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH] x86, mce: disable MCE if cpu has no MCE banks
Date: Wed, 28 Oct 2009 08:03:03 -0400 [thread overview]
Message-ID: <32564.1256731383@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Wed, 28 Oct 2009 06:24:45 BST." <4AE7D59D.9070307@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 472 bytes --]
On Wed, 28 Oct 2009 06:24:45 BST, Andi Kleen said:
> >>> mce: CPU supports 0 MCE banks
>
> That message can be just removed I think. I don't see much value in it
> because the value is in sysfs and when you see the CPU type you can easily
> determine it anyways.
Maybe it should only print a message if it finds an unexpected number of banks?
"Hey dood - we're on a Core3.5 and there should be 6 banks here, but the
hardware says there's only 4. What's up with that?"
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2009-10-28 12:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-15 21:21 [PATCH] x86: Don't print number of MCE banks for every CPU Roland Dreier
2009-10-16 7:20 ` Ingo Molnar
2009-10-16 7:22 ` [tip:x86/urgent] " tip-bot for Roland Dreier
2009-10-27 19:42 ` [PATCH] " Mike Travis
2009-10-27 20:53 ` Mike Travis
2009-10-28 4:07 ` [PATCH] x86, mce: disable MCE if cpu has no MCE banks Hidetoshi Seto
2009-10-28 5:24 ` Andi Kleen
2009-10-28 6:26 ` Hidetoshi Seto
2009-10-28 6:48 ` Andi Kleen
2009-10-28 8:18 ` Hidetoshi Seto
2009-10-28 17:09 ` Mike Travis
2009-10-28 17:12 ` Roland Dreier
2009-10-28 17:37 ` Mike Travis
2009-10-28 18:03 ` Roland Dreier
2009-10-28 12:03 ` Valdis.Kletnieks [this message]
2009-10-28 13:44 ` Andi Kleen
2009-10-28 4:26 ` [PATCH] x86: Don't print number of MCE banks for every CPU Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32564.1256731383@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=ak@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rdreier@cisco.com \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=tglx@linutronix.de \
--cc=travis@sgi.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®