mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Martin Liška" <mliska@suse.cz>
To: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Subject: [PATCH] perf: Print debuginfod queries if -v option is used
Date: Fri, 12 Aug 2022 13:43:53 +0200	[thread overview]
Message-ID: <325871cf-b71f-6237-8793-82182272ece8@suse.cz> (raw)
In-Reply-To: <2983e2e0-6850-ad59-79d8-efe83b22cffe@suse.cz>

When ending a perf record session, the querying of a debuginfod
server can take quite some time. Inform a user about it when
-v options is used.

Signed-off-by: Martin Liska <mliska@suse.cz>
---
 tools/perf/util/build-id.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/perf/util/build-id.c b/tools/perf/util/build-id.c
index 0cc68cdd84c8..d1cfce0613ee 100644
--- a/tools/perf/util/build-id.c
+++ b/tools/perf/util/build-id.c
@@ -653,7 +653,9 @@ static char *build_id_cache__find_debug(const char *sbuild_id,
 
 #ifdef HAVE_DEBUGINFOD_SUPPORT
 	if (realname == NULL) {
-		debuginfod_client* c = debuginfod_begin();
+		debuginfod_client* c;
+		pr_debug("Downloading debug info with build id %s\n", sbuild_id);
+		c = debuginfod_begin();
 		if (c != NULL) {
 			int fd = debuginfod_find_debuginfo(c,
 					(const unsigned char*)sbuild_id, 0,
-- 
2.37.1


  reply	other threads:[~2022-08-12 11:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-12 11:42 [PATCH] perf: fix coding style in build-id.c Martin Liška
2022-08-12 11:43 ` Martin Liška [this message]
2022-08-12 13:24   ` [PATCH] perf: Print debuginfod queries if -v option is used Arnaldo Carvalho de Melo
2022-08-12 13:23 ` [PATCH] perf: fix coding style in build-id.c Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=325871cf-b71f-6237-8793-82182272ece8@suse.cz \
    --to=mliska@suse.cz \
    --cc=acme@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®