From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A8C6C433DF for ; Wed, 5 Aug 2020 18:14:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4BA7420656 for ; Wed, 5 Aug 2020 18:14:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="cJiqL12y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728413AbgHESOj (ORCPT ); Wed, 5 Aug 2020 14:14:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729161AbgHESJI (ORCPT ); Wed, 5 Aug 2020 14:09:08 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83E15C06179E for ; Wed, 5 Aug 2020 11:09:07 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id g19so13170748plq.0 for ; Wed, 05 Aug 2020 11:09:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version; bh=QLQQ3+0etev233V3umPOvDVR32FRU3B4OHKUUP2KCtU=; b=cJiqL12yAVnWOtPxTPDWYZdMhDSWBAVmkAM12MtrQWair/KCdQo04Q3JIQaoAM68oK ktSPgagxplpFLOSivwPxXlyLmZ92ZTz3JVHDcF6/Cz4OlbXaPaTiRZjvjuSzWmWhXBzE yzJ+fL6mCIagoCzT1NECUKisLKh6z4D7js2Hf3U7aCoqSrbYX0WVKFekkz4uJhiiIet7 DhXKPeB7VM8W0WHLbH73QWjOPLzuqi7sEOCCSHiYDjdSCrJo1OD5COzxsMXQtU1T0EOw Y2rxz7mQriURh7LCeOKmkx27XTY8t5Uz3lKEJGFq5TO8vbur3wZg1crfB4zhD6bw96lq OkeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version; bh=QLQQ3+0etev233V3umPOvDVR32FRU3B4OHKUUP2KCtU=; b=QO3mLhK2PPg0hOxm0at/APNuQD6+P0OH29Ib5qzn2+Phxv+hhkyZGNNajFOrnwiyp/ 2skyrYmISV3dQnM2oi9a4EF3wKu7yIv7On2gtDpiuP4qrxAAVf2UzreP7tbMoGvWNdRM uS7tuEsohi8koTGiZ7/k9GE9pslYO1qM3HscKrTAWqzn8t8bvrfL16uJTvoayY5H1+2L bnb0XPvgqqvRIEsx8baXFF7b++x/YXjYLhvsEHLEVVFPxxwjv8WfYORtdR020CLvIUpI 4qkxLEqSFVcx5KVCtOecGdXnX31opqIzZKO/NbBvC7D/TcQ//WmVx50neU7bcc2iHLzl TPuQ== X-Gm-Message-State: AOAM532QCioM7KMnMHbCHbUlwwG3XU9wkcw1muKTiEZg9/utxxfzAOVU yKMA+a0d40YwLrTjr+vPSXwqeoHVjr0= X-Google-Smtp-Source: ABdhPJzgLgfCkhTYirh3jlA82isYOiQXoI3I2L0JOH5MsNNl4huINEybPkouEx/HAXGjPugwTQeLcA== X-Received: by 2002:a17:902:b686:: with SMTP id c6mr4212408pls.133.1596650947056; Wed, 05 Aug 2020 11:09:07 -0700 (PDT) Received: from [10.213.170.159] (fmdmzpr04-ext.fm.intel.com. [192.55.55.39]) by smtp.gmail.com with ESMTPSA id fv21sm3722351pjb.16.2020.08.05.11.09.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Aug 2020 11:09:06 -0700 (PDT) From: "Sean V Kelley" To: "Jonathan Cameron" Cc: bhelgaas@google.com, rjw@rjwysocki.net, ashok.raj@intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, "Qiuxu Zhuo" Subject: Re: [PATCH V2 9/9] PCI/AER: Add RCEC AER error injection support Date: Wed, 05 Aug 2020 11:09:04 -0700 X-Mailer: MailMate (1.13.1r5671) Message-ID: <32674ABF-0189-4477-8BEA-84DA393FD148@intel.com> In-Reply-To: <20200805185450.0000512d@Huawei.com> References: <20200804194052.193272-1-sean.v.kelley@intel.com> <20200804194052.193272-10-sean.v.kelley@intel.com> <20200805185450.0000512d@Huawei.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5 Aug 2020, at 10:54, Jonathan Cameron wrote: > On Tue, 4 Aug 2020 12:40:52 -0700 > Sean V Kelley wrote: > >> From: Qiuxu Zhuo >> >> The Root Complex Event Collectors(RCEC) appear as peers to Root Ports >> and also have the AER capability. So add RCEC support to the current AER >> error injection driver. >> >> Co-developed-by: Sean V Kelley >> Signed-off-by: Qiuxu Zhuo >> Signed-off-by: Sean V Kelley > > Silly English subtlety inline. > >> --- >> drivers/pci/pcie/aer_inject.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/pci/pcie/aer_inject.c b/drivers/pci/pcie/aer_inject.c >> index c2cbf425afc5..2077dc826fdf 100644 >> --- a/drivers/pci/pcie/aer_inject.c >> +++ b/drivers/pci/pcie/aer_inject.c >> @@ -333,8 +333,11 @@ static int aer_inject(struct aer_error_inj *einj) >> if (!dev) >> return -ENODEV; >> rpdev = pcie_find_root_port(dev); >> + /* If Root port not found, try to find an RCEC */ >> + if (!rpdev) >> + rpdev = dev->rcec; >> if (!rpdev) { >> - pci_err(dev, "Root port not found\n"); >> + pci_err(dev, "Root port or RCEC not found\n"); > > That is a bit confusing, could be > > RP | !RCEC > > "Neither root port nor RCEC found\n" perhaps? Sounds good to me. Will correct. Thanks, Sean > > >> ret = -ENODEV; >> goto out_put; >> }