From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05D5BC3DA7D for ; Tue, 3 Jan 2023 08:57:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236939AbjACI5M (ORCPT ); Tue, 3 Jan 2023 03:57:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236957AbjACI5I (ORCPT ); Tue, 3 Jan 2023 03:57:08 -0500 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F18EFE71 for ; Tue, 3 Jan 2023 00:57:06 -0800 (PST) Received: by mail-lj1-x22b.google.com with SMTP id s22so31157463ljp.5 for ; Tue, 03 Jan 2023 00:57:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FVam3FPvVcVUPkFARUn9WWGX9bvQ9k6HzVFVKcvWyZE=; b=tbfh3qioo77N98XjSFjd7PWy0XS7UHqQ0rnPICB/GFgnLr36lA59Nnhk2zRCgNwf3E yZfUrCAVxeP05N4N6KGfR+8H84WM+ckoAFIxPQlFOhVaJEc/2zev65dxW4n2if7eR/RB Q76GsIylyfR9RUSXCXRyZyyj94MSAp2Us7ZP+TTLNv+NFUfQXAzu48phTLoc2x1YxADn GzPuByvzjlv2WY2cs+5nocxxigfu99C5WmdAmD3ns4tKA1CA2O5w/6BhM2lgeSCWFxiq 5Dv6IJ3fvjIzabxCErbEWBLQ5C5cFq6iyXb21tkmYiFFkkgIAgh4JdN/yPOb782/X7yw kqtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FVam3FPvVcVUPkFARUn9WWGX9bvQ9k6HzVFVKcvWyZE=; b=fWHidMiKkgzUN4EdPmA264ElA0HGSZuNbSaK881H188bbZHO3aT55e0uFUHVxuYApp 9oGFTygdQv6NM8r8D595fEZZSJ4fUmoIBZ7NgPYDmCvywU8xMMxRLOxPYcBmV9dpd9x5 3G0uDfxvC6poWv9b047OBr8qV4jgHsculK5djFxeF4NA9xpDjjyBmq9cFrEZ5iDK6jyA vb4nDTO21QD/useZzoUp5P38fRIDbBKfq+i0f5Flps9rL9CVqWFJO1fS1rJH5GjJ4lDl Vjb2fynHNqVPaV/ueNC42DG3J/VRQ1drp4hg91eQgbNI5Jmhdm9jzWhDDR24jYaIq2H7 wU+Q== X-Gm-Message-State: AFqh2krK4QZ2PKITk97q28q464DfQFOwCJrSG3IWKeGhdP5uvx8YCadr DhboEAInnMwMGMMvr3vYUqiTBg== X-Google-Smtp-Source: AMrXdXsAmGHVUPFl2qLHgz7MtYi89rEbq9xWFBU46j9e11S6S1IWHRAtPUrkkcXlHtb2NXJtGJ+4xw== X-Received: by 2002:a2e:aa9f:0:b0:27f:cb0c:fd1b with SMTP id bj31-20020a2eaa9f000000b0027fcb0cfd1bmr7425321ljb.8.1672736225351; Tue, 03 Jan 2023 00:57:05 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id f13-20020a05651c03cd00b0027fea3a3318sm608902ljp.23.2023.01.03.00.57.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jan 2023 00:57:04 -0800 (PST) Message-ID: <3267da40-5c53-0b79-fd65-3009ee17c7ee@linaro.org> Date: Tue, 3 Jan 2023 09:57:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 1/4] dt-bindings: clock: qcom,sc7280-lpasscc: Remove qdsp6ss reg property Content-Language: en-US To: Srinivasa Rao Mandadapu , swboyd@chromium.org, agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org, broonie@kernel.org, quic_plai@quicinc.com, krzysztof.kozlowski+dt@linaro.org, konrad.dybcio@somainline.org, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, quic_rohkumar@quicinc.com References: <1672407799-13768-1-git-send-email-quic_srivasam@quicinc.com> <1672407799-13768-2-git-send-email-quic_srivasam@quicinc.com> <0d225fb0-7bc7-4de0-0f07-039502926e6b@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/01/2023 06:51, Srinivasa Rao Mandadapu wrote: > > On 1/2/2023 9:33 PM, Krzysztof Kozlowski wrote: > Thanks for Your time Krzyszto!!! >> On 30/12/2022 14:43, Srinivasa Rao Mandadapu wrote: >>> The qdsp6ss memory region is being shared by ADSP remoteproc device and >>> lpasscc clock device, hence causing memory conflict. >>> As the qdsp6ss clocks are being enabled in remoteproc driver, remove >>> clock controlling in the clock driver. >>> >> That's an ABI break change. You cannot just drop it because the driver >> will fail now to probe with old DTS. >> >> This ABI break (and Fixes tag below) requires extensive justification >> where is the bug and how it affects users. Otherwise, I see no reason >> for ABI changes. > > As ADSP path is not used so far due to various vendor requirements, we > haven't seen this conflict till now. The device is used in sc7280.dtsi (and it is not disabled), thus it is available in every board. > > Actually, in the below commit,  clock handling in remoteproc driver has > already up-streamed by Bjorn. > > If we add PIL device node and use remoteproc driver, qcom_q6v5_adsp.c, > it's mandatory to remove it from clock > > driver. > > Also the memory region is used by clock driver is part of > LPASS_QDSP6V67SS register region. > > Here is the commit 0c6de4c299cc8f3283c38f3778777e00ed7e4b69 > ("remoteproc: qcom: qdsp6-adsp: Add support for QCS404 CDSP") The commit introduces qcom,qcs404-cdsp-pil which is not used in upstream DTS... Anyway none of the reasons above explain to me why ABI has to be broken. To remind - valid reasons are usually only: "it never worked" or "I was introduced recently so there are no users". > For ABI Break resolution shall I include, device tree changes also in > this series? Or Could you please suggest better approach? Lack of DTS changes causes upstream to be broken. This is independent of ABI break. ABI means supporting users of the binding, so firmware, other OS, out-of-tree DTS users etc. All of them are broken. You need to keep backwards compatibility. Best regards, Krzysztof