From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754891AbcFPQsd (ORCPT ); Thu, 16 Jun 2016 12:48:33 -0400 Received: from mail-db3on0064.outbound.protection.outlook.com ([157.55.234.64]:27335 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754864AbcFPQs2 (ORCPT ); Thu, 16 Jun 2016 12:48:28 -0400 X-Greylist: delayed 3591 seconds by postgrey-1.27 at vger.kernel.org; Thu, 16 Jun 2016 12:48:28 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ogerlitz@mellanox.com; Subject: Re: [patch] devlink: clean up a condition To: Dan Carpenter References: <20160616065032.GB23129@mwanda> CC: Leon Romanovsky , , , Saeed Mahameed , Hadar Har-Zion From: Or Gerlitz Message-ID: <326e2050-176c-291a-a1ec-2d5f13930657@mellanox.com> Date: Thu, 16 Jun 2016 17:15:49 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160616065032.GB23129@mwanda> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [193.47.165.251] X-ClientProxiedBy: AM5PR0501CA0041.eurprd05.prod.outlook.com (10.164.187.51) To AM5PR0501MB2114.eurprd05.prod.outlook.com (10.167.215.19) X-MS-Office365-Filtering-Correlation-Id: eeb857b9-84ca-4077-9036-08d395f0ba5d X-Microsoft-Exchange-Diagnostics: 1;AM5PR0501MB2114;2:V9Ya5xqQVIy24XOpl7PAwVVkOt62Csyx1fiERXv5sLNXEFW20umocsjBHBFCU/BGpmRhPYHp0LztECzMBS2syrsfxdyC4gSqv5zvz2wNyme4hNCSsHlVad835OYhp1IVOMDMVNaygHZ4i5+6vV7WkgIacFMmvr1GJsdnmZXrGXZNuekhjrBB24Ob/5iOVeSH;3:RsUOTtznzre/ng5HEdEphc6FpRMidHUih53i/oYoGc/kBnqbvLLlwGWZ2jryOYzrvTULHaNjqZSr6gS6bGsZnKa2DUmOp9b8OoHigtQ1wGP4Yi9ipQ5+HUMJ8QQBxpf+;25:pPXp0TZOMfFzY4zQwZCNWjyrneGAUVHKmv8WqMyAc9c64sj8cU5ond8KmQi5bt4S7U8JnChyfODcfPm/Hs12zGzHzHxzw69bPP80NFbaWysoYAgqFK01All7GCguiTjSzA+bhnm2k/x7LsIewz97muOIS3+f9nsTMgC8wgmhUL+/l4vfrY9fADL7wtcAc5TN/UBa4tHripdqjndnr3DVjExng67bB0jze3TGacuAbxyAG1L8pOFIitmZrBd0A0JMKSV7AiomSjsVoJLtW2AxNwGxX1hKLg/NWW9xeRBUPsgO3saIjVU0qDtwIopnoMMGPvPbFyjlmZPgjIIR57Ouj4Dl7bKSYQ8ANJtc7EywZBgcQA6gXsqnKiyiC9Wb2wdrUlInRRLKuobRjX086KrsbNbxl6RAk/p5bkU020fMyUo= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0501MB2114; X-Microsoft-Exchange-Diagnostics: 1;AM5PR0501MB2114;20:55GBEBFz7vp+BJPlVmlazJWbC1zFOIxku3OxRL0dGsgy1xsmfud4e0+OZHrk002pC01aH2p8TYhxx4LATNIYld1J4nc3HlF0HqKLBA4J8iSZIQ3Z18quc9MngdDA+pUHoHutBO9rxrlJF8aZvyDHZaYuUeqApHDZSBrKoyp++gV/JWtR7CumfTsMP9t8RlVzfs996h8nLZPME0UawBmCRmjQSQjijfZH3a4//TiPdx31UW4nK+SM3CkkfTvEvQYeVa5R9eDuC5ckwGW3akuiZBwAVV4ouJkxFRoi9V7jcrIMBcKVYoy8qAYf4/6WiplLY8yU0uggjG6ThcdItdGNHUee3YGFvTcKktBhVdR4Kf2Ra/t/eL0eZ9wE9J30TNLWEXwL6/3+D/nM1mi56ELYXWhK986ki3DlfoyoDKd3zHPiD0M5w+V8Prwr1SlgE75/CtxA3HF3wmOjhFFn9Ws4N2hY3nG0FEV325JD4I9BV3y0lqJMtHNicUTj+I8QtEiH;4:qmAJ0se+k2BPfJ+uoaG752UKP5oJotgF1KK39FBkMeDSIiWGOmpsu2wI4lFprkkMAnnaJbK6TlTNQjQDCfRdS7ohARJuHb6Mo4RNZX/90GIqypINLn595uWaHLJRdmYfMHFfFGGZozdRKCo4D2MJtNfj54xCVkK28yQ2Z885rZfQ5SrRD3cld563SLvltLYlrlJj2K6TVKJX5EikI+hqjgBagcVaC9lo7zzEsodVIX3zDrzMPngPe1+Y8K+i+ePLpQYdLJsGE14P9QWchfr7kxSyAk4bPDHeomrrZR/XTHx7CiZpsY0IjTlYi3rlJ98K3bxDdbyEnGwWSAMjLtAs1aYibTkMN1hpn5rqdr+WzthKj8eXjyC6h2gBLgy4WERWIngGWOHgLZCvkMdMPZuobmQ29wEOwnETf/QeYHzyBJJXkJUkc59XRXflS/0McBzD X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(146099531331640); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:AM5PR0501MB2114;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0501MB2114; X-Forefront-PRVS: 09752BC779 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(7916002)(189002)(377454003)(24454002)(199003)(50986999)(101416001)(76176999)(8676002)(81156014)(81166006)(54356999)(47776003)(3846002)(23746002)(230700001)(106356001)(33646002)(105586002)(4001350100001)(2906002)(36756003)(6116002)(4001430100002)(586003)(68736007)(77096005)(50466002)(2950100001)(97736004)(31696002)(189998001)(5008740100001)(19580405001)(19580395003)(64126003)(83506001)(5004730100002)(92566002)(65806001)(65956001)(66066001)(86362001)(110136002)(31686004)(42186005)(107886002)(4326007)(65826006);DIR:OUT;SFP:1101;SCL:1;SRVR:AM5PR0501MB2114;H:[10.12.129.45];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;CAT:NONE;LANG:en;CAT:NONE; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;AM5PR0501MB2114;23:jKub+cgcR4VHws8QVidWtjC3U5/b4Uynkx6?= =?Windows-1252?Q?8kyxfusUabPt72Z645uR3vv9ggGxApCF4+LoI9pEe0wURyfJnXXAuzfs?= =?Windows-1252?Q?0gEPX36RMatIp0mK1xSIk/3ycUIwNGTf5E1qvjaGFX6jTS9zorZEkEj1?= =?Windows-1252?Q?P1K7noXyFADCPkhebG7m7KLizU9zVyIx9wnS2XWmVqdRKV3tm8Jp5T9/?= =?Windows-1252?Q?DE3Ix5CU4WIF+FQ+C7LFGODpV9HKgEg7OIaYTBF9K/5UNoQ6vw52xSvH?= =?Windows-1252?Q?BxweGZTAvfYQrJUdxB2rm9viGCntI7ZtRpAfGLGEotl91FV27pDS8+Sh?= =?Windows-1252?Q?um4NGb2PosInK5CanAdelsymrvCONUWoDfw8A6jUFcTWsDIX4olDHzJQ?= =?Windows-1252?Q?Zru+an93wd/x9/UTAEjApFuAEx2/8AOGkDhUKn9RJ92FKAxY+kTBzxNF?= =?Windows-1252?Q?KDiMURB5vxRXB8nGRsJv0P0XB+CDCUW/LXEwgr23sV7JfudHRfyewXvd?= =?Windows-1252?Q?naRazHUVJ54c4+bSdCFZR0V9wyzFxgTzEu+0SZutdn741xiKlh+tGgOc?= =?Windows-1252?Q?1orbbLmdy78yBqKDNmvqQYrEMm7z1luMhjvAXELv+Z4C4VQmoRqJ66js?= =?Windows-1252?Q?Eqvf9zKpC2LvU16vFzbj5kDP/hnsnmUV7gfrf1/O4sLiTFAL6YJBuv79?= =?Windows-1252?Q?6NIIcJVlz7YRhfPGXof1OoW3/bk5+UC8i11wIMgKZLWddiAs0fVfBEsT?= =?Windows-1252?Q?F68zYZzdcuPtVxw6WB/egHNmLYKAtvTSw6WhA61DGpBKg2LGdZtvNmn+?= =?Windows-1252?Q?23Xln5v3HA8FT6YSKQY0Q0/25t/i/GwT3qUZxqtF8yPRFhyz7k5j2q+L?= =?Windows-1252?Q?wDLbU/IhtzR+FZ7FQ8Vri5t9stWit3nU7RRES/1QfSPuJvmetzfW7Qot?= =?Windows-1252?Q?b99TcE0zlGmbYa4n8FJ/4gRZCXJVY12neC6LzTsgkosYqc/BTw3ibp5r?= =?Windows-1252?Q?6o796okUx+Qn67OJXMRScigHmzB16xL4mpB1Quv/B2dxitiHFWqZ3HqK?= =?Windows-1252?Q?mEO6oPt1QQpw4oZCWmvlwqQtBF06w/7Xq4qur3xtUL7R9o0ZTEjbiq6D?= =?Windows-1252?Q?gsAC9IaAreaHeqUKxbH7HQwS6EyAqAWo6cXhmlZ5/xSmxcdxBM14awlt?= =?Windows-1252?Q?+MvlipEqBl22oDaxLqeKxbkteetDfHbtLByVJYyjsewUmK8GRa7dkEl9?= =?Windows-1252?Q?1/rEMimTXHOJ8VD7IQGUr5kuAkMHWpejSS570ROM5h2CVknMLLg1aIr/?= =?Windows-1252?Q?5DNF72fQolBhie+FzPKUbTpRx61Yju9WF/xYF+Zr5NH/kXPaUNR8islE?= =?Windows-1252?Q?Kz+zI/Ztwm9xaX43QRR/LmE9OwuXFZ+aInIU1B8ZC9mmd/oHl0xM+Hgk?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;AM5PR0501MB2114;6:hw2FLtRuS3YaBWfInRo2O5EXP+sAs1uUkCtXRVkuVN36V4DXjaWPw4G6P7e+6QH3EBg/KE5oqBfrPs/U6yAFDB736T4FceFqywRPWAMpCsplo6r8P/L4OdGvOvCgFhUQ/PsbbrRnjpBrJYHbybVhGqm2RDOEXANKEX7wRGw22mGkWjFXNzxqzVflPpx+cFrwmBcWCLTYCvLJH8neP6KU73EUX3w6OB0vrJA7pkhzAjSV9po13dnhkDRtdjbvc/gN10zyyOFLqF/XIL9lOdDEOjem5nTaIuGetxr8wIOxO+nW1pol4HPrOSjJdu4Wk6vCbzuFTyympJhA0c+pZ6fffw==;5:u9ZJsd7wI8mG1Q3JCffQAc/av8kqhQPr7jOrTUe8XOa3GaC1c8WBhLXMAzyPTUbrsH8Ax6whsbRf7g0F1zdyJNU8HTR0/zcBXqwbf8nXPL5QkiTxXh3qbrW7kSN68NxTxhSmgI/FCLG3gGT8UViGcQ==;24:7c7jm7Otba4bvTwpJqHBWAJLBNkUQL8RSZNZWP0/0gmgktuZvK1Po5TOQ87M5808xwt6Sye51i+PNYMW2NHKuPE23mqPIqvIcqFh3t8d9vg=;7:LdvRWmRxxIQE/m/TWZVgNlJ7prIDActF0eCZE/jMmsXthInBc0YblpNl0fbzzm2wimqFGbJXUWr8LH1X2Vh0tjr5fRW+5OFldM63Oy6kQlx9Bx/nKGtPUmqLBM0XcYvauMIs/aUdcYlU2qd7MEv+tHeI2z/198r9YHE1xw2M9wGFXuUIx2RjdzwQSK9aF11qwpQfEDiauba56PH4vK9FRg== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2016 14:15:53.5291 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0501MB2114 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/16/2016 9:50 AM, Dan Carpenter wrote: > Presumably having a _get() function implies that we also have a _set() > function but lets make it match when we're calling. > > Signed-off-by: Dan Carpenter > > diff --git a/net/core/devlink.c b/net/core/devlink.c > index a4f88cb..b2e592a 100644 > --- a/net/core/devlink.c > +++ b/net/core/devlink.c > @@ -1461,7 +1461,7 @@ static int devlink_nl_cmd_eswitch_mode_set_doit(struct sk_buff *skb, > > mode = nla_get_u16(info->attrs[DEVLINK_ATTR_ESWITCH_MODE]); > > - if (ops && ops->eswitch_mode_get) > + if (ops && ops->eswitch_mode_set) > return ops->eswitch_mode_set(devlink, mode); > return -EOPNOTSUPP; > } good catch Dan, we will incorporate that into the patch set