From: Randy Dunlap <rdunlap@infradead.org>
To: Baolin Wang <baolin.wang7@gmail.com>, linus.walleij@linaro.org
Cc: orsonzhai@gmail.com, zhang.lyra@gmail.com,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: sprd: Fix the kconfig warning
Date: Mon, 2 Mar 2020 20:45:35 -0800 [thread overview]
Message-ID: <3271ce73-7165-c545-43e7-93d85a7c3680@infradead.org> (raw)
In-Reply-To: <eeb12d7843fb06f80e19f98eb25711231c3b610f.1583205650.git.baolin.wang7@gmail.com>
On 3/2/20 7:32 PM, Baolin Wang wrote:
> On X86 plaform, if the CONFIG_OF is not selected, and set the
> CONFIG_SPRD_SC9860 as 'm', that will cause below waring:
>
> WARNING: unmet direct dependencies detected for PINCTRL_SPRD
> Depends on [n]: PINCTRL [=y] && OF [=n] && (ARCH_SPRD || COMPILE_TEST [=y])
> Selected by [m]:
> - PINCTRL_SPRD_SC9860 [=m] && PINCTRL [=y]
>
> Thus move the configuration dependency under CONFIG_PINCTRL_SPRD_SC9860
> to fix the warning.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Baolin Wang <baolin.wang7@gmail.com>
Works for me. Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
> ---
> drivers/pinctrl/sprd/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/sprd/Kconfig b/drivers/pinctrl/sprd/Kconfig
> index c9e7f0b..eef35d0 100644
> --- a/drivers/pinctrl/sprd/Kconfig
> +++ b/drivers/pinctrl/sprd/Kconfig
> @@ -4,9 +4,7 @@
> #
>
> config PINCTRL_SPRD
> - tristate "Spreadtrum pinctrl driver"
> - depends on OF
> - depends on ARCH_SPRD || COMPILE_TEST
> + tristate
> select PINMUX
> select PINCONF
> select GENERIC_PINCONF
> @@ -16,6 +14,8 @@ config PINCTRL_SPRD
>
> config PINCTRL_SPRD_SC9860
> tristate "Spreadtrum SC9860 pinctrl driver"
> + depends on OF
> + depends on ARCH_SPRD || COMPILE_TEST
> select PINCTRL_SPRD
> help
> Say Y here to enable Spreadtrum SC9860 pinctrl driver
>
--
~Randy
next prev parent reply other threads:[~2020-03-03 4:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 3:32 Baolin Wang
2020-03-03 4:45 ` Randy Dunlap [this message]
2020-03-03 5:02 ` Baolin Wang
2020-03-03 12:46 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3271ce73-7165-c545-43e7-93d85a7c3680@infradead.org \
--to=rdunlap@infradead.org \
--cc=baolin.wang7@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®