From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751964AbcFVKNt (ORCPT <rfc822;w@1wt.eu>);
	Wed, 22 Jun 2016 06:13:49 -0400
Received: from mout.kundenserver.de ([212.227.126.131]:65216 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751425AbcFVKNh (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 22 Jun 2016 06:13:37 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>, "Theodore Ts'o" <tytso@mit.edu>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] compat: remove compat_printk
Date: Wed, 22 Jun 2016 12:15:17 +0200
Message-ID: <32739965.DkybxvdJlf@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <20160621163857.cf59ebebf39c38d67d71eb80@linux-foundation.org>
References: <20160617142903.3070388-1-arnd@arndb.de> <20160621163857.cf59ebebf39c38d67d71eb80@linux-foundation.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:Fc5wBy2TwxoRmIntSPcg7liAIuvaJ0gNUtYpNURYr0VA0avCSdl
 f+vlSGaf3CuHIlyinLnQWmiL39CM2Nt+vBGPS+ubYjcQXOa2b38ULXcZrh4chCqcRA8oiu/
 30VAxzaZDLrhC2A4P0SwmjmvNj9tiUG+wNnvvne/Nwopj1Dyc5JmRKV0z/S/0BIxyHUU32b
 OUTV+FSWSs1P9r54t+IdA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:q8Uju0AYTZU=:7O7Oz05Dy5WmC9dIVosYeh
 ZrQRD4vHm/as/UXbEBL11OWkFvQzBb1HFcYexxJFl0x/AipPBlgbjdyVCZv6p0ZVh6ftctvLl
 8hzqoSNZAuTlKabd1fFhhQDy6zd4jZ1r4YRUiT9sirGu8uQ6VxzHeEK4CUTU2hwD5Mh7Y7afh
 cNQAQlGya/DEgHZ+NNMF2RJp5eCsibzcUVrc7kQ8WyWr1/2W0s9MZjuu/4Fi/zfLwyTCPG9FU
 yiMDXBqlXbcOp+M+NgYYI2Tx5qvLblTJBZ4HyfpAQfRQm79xqo8UebMDWV3FULCQtda27UyTf
 Po379CLhIZnq0Fg6EGTqJxMZWF1f5zpmtXTuRsO2ywdu77l2vz5Pw1gJ7stxWrJ0dNUpJOmon
 Ok5PKQ5dFSaLUW20IVve83r55FTDKGIEEk8DLjJnq9G6G5S/IopMgVEWDE295LmDO1H5AWSpP
 Kbyo/7FAm2PQpErz659FpKdMqNnV9eYf/1msBfZbAc5We3X2OQc2t5cmgIvrSqrRKFS2Fhcri
 Lg7bLuOKkpfmTm1IPYZKovuFgMnBGutV7e12XybxqZ5M7yJJFD/iojcj7eq56Z38Y7UAwl2JW
 b1It4f7BhMaws758t1HruWftCUNPMRYYOqZWIWvX0PcCViWm1q2/qSG0FMFpOopo+oKgYXV3A
 +GXAplmEKzHEbz20IfFk8DYVrADWakW5n8UJdUc5CRpe3OCLaonRufgy15GVij9IUpzYITVLX
 BGIp/xh54DvGgFJU
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday, June 21, 2016 4:38:57 PM CEST Andrew Morton wrote:
> > @@ -1077,15 +1076,6 @@ static struct ctl_table kern_table[] = {
> >               .extra1         = &neg_one,
> >       },
> >  #endif
> > -#ifdef CONFIG_COMPAT
> > -     {
> > -             .procname       = "compat-log",
> > -             .data           = &compat_log,
> > -             .maxlen         = sizeof (int),
> > -             .mode           = 0644,
> > -             .proc_handler   = proc_dointvec,
> > -     },
> > -#endif
> 
> How do we know we can simply remove /proc/sys/kernel/compat-log without
> breaking any userspace?
> 

Good point. I guess we can leave this in place just in case (with a comment)
and just remove the compat_printk function. We could probably have a Kconfig
symbol for obsolete sysctl files, but if this is the only one controlled
by it, it's probably not worth the effort.

	Arnd