From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751049AbcL2UaZ (ORCPT ); Thu, 29 Dec 2016 15:30:25 -0500 Received: from argos.tuxed.org ([176.9.87.227]:54681 "EHLO argos.tuxed.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750782AbcL2UaX (ORCPT ); Thu, 29 Dec 2016 15:30:23 -0500 Subject: Re: [RFC PATCH v2 3/4] hwmon: adc128d818: Trivial code style fixup To: Guenter Roeck References: <20161223221205.8825-1-mail@alexanderkoch.net> <20161223221205.8825-4-mail@alexanderkoch.net> <650d2371-57da-2494-7628-5a8bc5b756bf@roeck-us.net> <3b34c8aa-9d9a-cf88-0d84-8e0d47f9bf44@alexanderkoch.net> <20161229194646.GA1575@roeck-us.net> From: Alexander Koch Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, jdelvare@suse.com, trivial@kernel.org Message-ID: <3274026c-9575-b85e-54da-dd1cd3c3ce2f@alexanderkoch.net> Date: Thu, 29 Dec 2016 21:30:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20161229194646.GA1575@roeck-us.net> Content-Type: text/plain; charset=windows-1252 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uBTKUUYO012747 On 12/29/2016 08:46 PM, Guenter Roeck wrote: > On Thu, Dec 29, 2016 at 07:22:12PM +0100, Alexander Koch wrote: >> On 12/26/2016 11:47 AM, Guenter Roeck wrote: >>> On 12/23/2016 02:12 PM, Alexander Koch wrote: >>>> Replace sysfs symbolic file permissions, e.g. 'S_IRUGO', by octal >>>> permissions. This fixes checkpatch.pl warnings. >>>> >>>> Signed-off-by: Alexander Koch >>> Please do not bother with those warnings and ignore checkpatch. >>> We are in the process of doing an automated conversion. >> Okay, so I shall create v3 of the patchset, without these changes. I've >> found a typo in the 4th patch so I thought about going v3 anyways. >> >> I've tested operation modes 1-3 on real hardware today and found no >> issues so far, so I hope v3 will have good chances of getting accepted. >> > Pretty much. One request, though: If there is no configuration data > from DT, I would like the driver to read the mode from the chip - if for > nothing else, this will let me test all modes, but it also supports the > case where the chip is configured by BIOS/ROMMON. Aye, will add this as new fourth patch then. I assume the chip reset in adc128_init_client() clears the chip mode as well, so I will read it in the operation mode block in adc128_probe(). Just out of interest: how does this help you test the modes? Do you configure the chip externally and test it on a platform without devicetree support? Cheers, Alex