From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754636AbbIIAi5 (ORCPT ); Tue, 8 Sep 2015 20:38:57 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:50283 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752627AbbIIAit (ORCPT ); Tue, 8 Sep 2015 20:38:49 -0400 From: "Rafael J. Wysocki" To: Viresh Kumar Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, preeti.lkml@gmail.com, open list Subject: Re: [PATCH V2 3/9] cpufreq: ondemand: only queue canceled works from update_sampling_rate() Date: Wed, 09 Sep 2015 03:06:39 +0200 Message-ID: <32794142.WpJFa6Ni1D@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.1.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20150908015831.GY26760@linux> References: <1806697.T1XSqGqSN5@vostro.rjw.lan> <20150908015831.GY26760@linux> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, September 08, 2015 07:28:31 AM Viresh Kumar wrote: > On 08-09-15, 03:11, Rafael J. Wysocki wrote: > > There really are two cases, either you pass a CPU or gov_queue_work() has to > > walk policy->cpus. > > Right (At least for now, we are doing just that.) > > > Doing it the way you did hides that IMO. > > Maybe. But I see it otherwise. Adding special meaning to a variable > (like int cpu == -1 being the special case to specify policy->cpus) > hides things morei, as we need to look at how it is decoded finally in > the routine gov_queue_work(). Oh well. I've just realized that if you combined this patch with the [6/9], you wouldn't need to make any changes to gov_queue_work() at all, because that patch removes the case in point entirely. Thanks, Rafael