From: Mark Brown <broonie@kernel.org>
To: Weizhao Ouyang <o451686892@gmail.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Shuah Khan <shuah@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kselftest/arm64: abi: fix SVCR detection
Date: Mon, 9 Dec 2024 12:36:52 +0000 [thread overview]
Message-ID: <3279e669-1ee2-4792-9e10-8b40928de6b4@sirena.org.uk> (raw)
In-Reply-To: <20241209105237.10498-1-o451686892@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 633 bytes --]
On Mon, Dec 09, 2024 at 06:52:37PM +0800, Weizhao Ouyang wrote:
> When using svcr_in to check ZA and Streaming Mode, we should make sure
> that the value in x2 is correct, otherwise it may trigger an Illegal
> instruction if FEAT_SVE and !FEAT_SME.
> // Set SVCR if we're doing SME
> - cbz x1, 1f
> adrp x2, svcr_in
> ldr x2, [x2, :lo12:svcr_in]
> + cbz x1, 1f
> msr S3_3_C4_C2_2, x2
This is against an older verison of the code so wouldn't apply now.
It's not also checking the value of SVCR, this is checking the SME flag
passed in via x1. You can see that the SVCR value is loaded into x2 but
the check is against x1.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-12-09 12:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 10:52 Weizhao Ouyang
2024-12-09 12:36 ` Mark Brown [this message]
2024-12-09 12:51 ` Weizhao Ouyang
2024-12-09 13:12 ` Mark Brown
2024-12-09 13:26 ` Weizhao Ouyang
2024-12-09 13:51 ` Mark Brown
2024-12-09 14:04 ` Weizhao Ouyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3279e669-1ee2-4792-9e10-8b40928de6b4@sirena.org.uk \
--to=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=o451686892@gmail.com \
--cc=shuah@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®