From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753119AbcLHO0r (ORCPT ); Thu, 8 Dec 2016 09:26:47 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:51500 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932090AbcLHO0n (ORCPT ); Thu, 8 Dec 2016 09:26:43 -0500 MIME-version: 1.0 Content-type: text/plain; charset=utf-8; format=flowed X-AuditID: cbfec7f5-f79ce6d000004c54-69-58496d9f183e Subject: Re: [PATCH 0/7] Move dell-led to drivers/platform/x86 To: =?UTF-8?B?TWljaGHFgiBLxJlwaWXFhA==?= , Richard Purdie , Matthew Garrett , =?UTF-8?Q?Pali_Roh=c3=a1r?= , Darren Hart , Jaroslav Kysela , Takashi Iwai Cc: Bob Rodgers , Louis Davis , Jim Dailey , Alex Hung , Hui Wang , linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org From: Jacek Anaszewski Message-id: <327c8edc-5a1e-8a94-85b2-4a2febc03352@samsung.com> Date: Thu, 08 Dec 2016 15:26:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 In-reply-to: <20161208123618.28603-1-kernel@kempniu.pl> Content-transfer-encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA01Sa0hTYRjuO+fsnONqcpoz3+wiDfyRlWkXOlgNi4rTj6CISiqooYdlOY2d tmX2Yy61XKXNpMu6zExLlHTNC+pMUnEFq0jaumgao1xSiYFYama5joH/nvd7nud93+flo3H5 O0kknZp+gtelq9OUpJRocI+9WGHXbk+Ke/o6jK3r3M96u9ox1nInjp381IGzgU9Ogr3r9UrY V803Sbb+WzViu29NYKzPf4NgrZ5fGJvfXChhq1oG8CmrA7Gu5n4J6/j5ACUynGPYTHI200WS K7p+DeeabL0UV1sRw5V2mHGudfAeybXYRyVc9dsRiqup8xHcsHPxztn7pRtS+LRUA69bqTos PXLVuvn4hYUnn7cNUybUGm5BNA3MGuisT7GgkCk4D1721ZAWJKXlTDmCXJdVIhbDCK70/yBF 1Rowl/pwkbiH4I55BAUJGTMXRi/3EUGMMwkQmMyddgcQNBV7qCARxqjA3uCkgoSCqcCgqfU9 Eh0uDDrHE4OYZOJhbOArJnZVwW3P4L/RBBMNZb0lKLh3OJMErl4++BzCrIMyXz8ltomCNu9n ItgfGCsN/upsXMy5CJyPcTHBFnj04gom4jD48qSOEvFCyD/Xhoneywi63O8kYlGF4GF+PiGq 1oPpz/h0zFAoarg6PUAG5/LkooSDWkfftHwTWOzdlHgJC4LicjN5CUXZZlzMNuNithkhShBe iRS8XtBqeGFtrKDWCvp0TWxyhtaJpj6cZ/LJSCMqdye0I4ZGyjmyxCguSS5RG4RMbTsCGlcq ZM+Obk+Sy1LUmad4XcYhnT6NF9rRAppQRshaSrz75IxGfYI/xvPHed1/FqNDIk0oOZC8J2Zi WWAv9r0/pyvHeOr+mYpZq+b3uF+NLf3w7IbxWuHe2KLUobxdPaeXNhoOKg1+4Y1z9xLTrN8f 12016vtqth2g5LnG1ZlZi3F/W/xBBRFBhn7NLpj7Mc7tz/JXdjAFZaW1xTvPVkaqzMuNKt9G jcFIn1fg0bxpR+hQupIQjqjjY3CdoP4LObNlO2wDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrNIsWRmVeSWpSXmKPExsVy+t/xa7rbcj0jDJruK1hsORplceXiISaL roUGFv+eHGa2ePZkE4vF4itXWC0u75rDZrH1zTpGi1tz/zBZXH04m8Vi4unfTBadu/pZLVbv ecEM1LqB0WL3rqesFhu+r2V0EPDY8LmJzWNWQy+bx6SZM5g9ds66y+6xeYWWx6LDTcwe+94u Y/PYM/8Hq8e6G1/ZPdZvucri8XmTXAB3lJtNRmpiSmqRQmpecn5KZl66rVJoiJuuhZJCXmJu qq1ShK5vSJCSQlliTimQZ2SABhycA9yDlfTtEtwypk90KuiRqTh78DN7A+M+0S5GTg4JAROJ pkVXmSFsMYkL99azdTFycQgJLGGUaG1/xwSS4BUQlPgx+R4LiM0sYCbx5eVhVoiiZ4wS05bv YQVJCAvYSczftokdJCEisIJJ4mD3NahRPYwSRzdOA8swC+xmknh4fAPYXDYBQ4mfL15D7bCT mHf6LRuIzSKgKrHk7gJGEFtUIELi1qqPYDangLnEkqtP2SHukJc4eOU5ywRGgVlITpyF5MRZ SMoWMDKvYhRJLS3OTc8tNtQrTswtLs1L10vOz93ECIz4bcd+bt7BeGlj8CFGAQ5GJR5eB3mP CCHWxLLiytxDjBIczEoivGeyPCOEeFMSK6tSi/Lji0pzUosPMZoCHTuRWUo0OR+YjPJK4g1N DM0tDY2MLSzMjYyUxHlLPlwJFxJITyxJzU5NLUgtgulj4uCUamDkFZsT8VHieM9Xy8Jczo4A JSnJHSydetXLTlpNVk760aNzdZcQz+y08zG/jp7uSbp9i9//4M+7TI2ZLOcnXD7/pPbFdZ/N SSoLf/HPmDCl1sM8ec45ywOxWyQ3ROupv3nl8k9LYvIktcjf7lO3XbBev8qEzVbxfHJLSxLb 0Z0fJwbO6umYdFNEiaU4I9FQi7moOBEAe4NqyQ4DAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161208142638eucas1p24eabf32b927ee28a64af50c514da134a X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?SmFjZWsgQW5hc3pld3NraRtTUlBPTC1TeXN0ZW0gRlcgIChN?= =?UTF-8?B?Qikb7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?SmFjZWsgQW5hc3pld3NraRtTUlBPTC1TeXN0ZW0gRlcgIChN?= =?UTF-8?B?QikbU2Ftc3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgU29mdHdhcmUgRW5naW5l?= =?UTF-8?B?ZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjc1MjY=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20161208123909epcas3p23229f5e0d337e19a27b272211798d364 X-RootMTR: 20161208123909epcas3p23229f5e0d337e19a27b272211798d364 References: <20161208123618.28603-1-kernel@kempniu.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michał, Thanks for the patch set. On 12/08/2016 01:36 PM, Michał Kępień wrote: > This patch series moves the dell-led driver from the LED subsystem to > the x86 platform driver subsystem. I decided to also CC the sound > subsystem contacts for the whole series as > sound/pci/hda/dell_wmi_helper.c is also affected. > > The original motivation behind this effort was to move all code using > the dell-smbios module to the x86 platform driver subsystem. While I > was investigating the possibilites to do that, it quickly emerged that > dell-led can and in fact should be moved to the x86 platform driver > subsystem in its entirety. > > dell-led consists of two major parts: > > - the part exposing a microphone mute LED interface, introduced in > db6d8cc ("dell-led: add mic mute led interface"); this interface is > used by sound/pci/hda/dell_wmi_helper.c; while the original > implementation used a WMI interface, it was changed to use > dell-smbios in cf0d7ea ("dell-led: use dell_smbios_find_token() for > finding mic DMI tokens") and 0c41a08 ("dell-led: use > dell_smbios_send_request() for performing SMBIOS calls"), > > - the part handling an activity LED present in Dell Latitude 2100 > netbooks, introduced in 72dcd8d ("leds: Add Dell Business Class > Netbook LED driver"); it binds to a specific WMI GUID and then > registers a LED device which is controlled using WMI (i.e. it is > basically a WMI driver). > > Patches 1-4 clean up the microphone mute LED interface to minimize the > amount of code moved around. > > Patch 5 moves the microphone mute LED interface to > drivers/platform/x86/dell-laptop.c, effectively causing > sound/pci/hda/dell_wmi_helper.c to depend on CONFIG_DELL_LAPTOP instead > of CONFIG_LEDS_DELL_NETBOOKS. > > Patch 6 reverts dell-led to the state it was in after its initial commit > 72dcd8d ("leds: Add Dell Business Class Netbook LED driver") by removing > all remnants of the microphone mute LED handling code. > > Patch 7 moves all that is left of dell-led (i.e. the activity LED part, > as originally implemented), to a new module which is placed in > drivers/platform/x86/dell-wmi-led.c. > > This patch series is based on linux-leds/for-4.11 as the LED subsystem > is affected by all patches except patch 3. > > If anyone reading this has access to a Dell device which has an activity > LED and/or a microphone mute LED currently supported by dell-led, I > would love to hear from you as I do not have the hardware needed to > practically test this patch series. I think that it is necessary to find someone who will give their Tested-by. What I can accept immediately is moving the driver in the current shape to x86 platform drivers. I could expose a stable branch with that patch for the x86 platform maintainers then. > drivers/leds/Kconfig | 9 --- > drivers/leds/Makefile | 1 - > drivers/platform/x86/Kconfig | 8 +++ > drivers/platform/x86/Makefile | 1 + > drivers/platform/x86/dell-laptop.c | 28 ++++++++ > .../dell-led.c => platform/x86/dell-wmi-led.c} | 75 +++------------------- > include/linux/dell-led.h | 6 +- > sound/pci/hda/dell_wmi_helper.c | 18 +++--- > 8 files changed, 55 insertions(+), 91 deletions(-) > rename drivers/{leds/dell-led.c => platform/x86/dell-wmi-led.c} (73%) > -- Best regards, Jacek Anaszewski